From nobody Mon Feb 9 19:52:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1489570534972844.6260192112375; Wed, 15 Mar 2017 02:35:34 -0700 (PDT) Received: from localhost ([::1]:35384 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1co5LA-0004Kq-OQ for importer@patchew.org; Wed, 15 Mar 2017 05:35:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1co5Fx-0000oZ-50 for qemu-devel@nongnu.org; Wed, 15 Mar 2017 05:30:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1co5Fw-0000Vx-4N for qemu-devel@nongnu.org; Wed, 15 Mar 2017 05:30:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55190) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1co5Fv-0000Ub-TL for qemu-devel@nongnu.org; Wed, 15 Mar 2017 05:30:08 -0400 Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EFE9E81243; Wed, 15 Mar 2017 09:30:07 +0000 (UTC) Received: from localhost (ovpn-116-16.ams2.redhat.com [10.36.116.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0430F2D582; Wed, 15 Mar 2017 09:30:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EFE9E81243 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=stefanha@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com EFE9E81243 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Date: Wed, 15 Mar 2017 17:29:37 +0800 Message-Id: <20170315092940.1367-6-stefanha@redhat.com> In-Reply-To: <20170315092940.1367-1-stefanha@redhat.com> References: <20170315092940.1367-1-stefanha@redhat.com> X-Scanned-By: MIMEDefang 2.74 on 10.5.11.28 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 15 Mar 2017 09:30:08 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC v2 5/8] qcow2: add bdrv_measure() support X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , John Snow , Nir Soffer , Maor Lipchuk , Stefan Hajnoczi , Alberto Garcia Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Use qcow2_calc_prealloc_size() to get the required file size. Signed-off-by: Stefan Hajnoczi --- TODO: * Query block status and only count allocated clusters if in_bs !=3D NULL * Exclude backing file clusters if in_bs !=3D NULL and -o backing_file=3D is given --- block/qcow2.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index 19be468..a4caf97 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -2940,6 +2940,58 @@ static coroutine_fn int qcow2_co_flush_to_os(BlockDr= iverState *bs) return 0; } =20 +static void qcow2_measure(QemuOpts *opts, BlockDriverState *in_bs, + BlockMeasureInfo *info, Error **errp) +{ + Error *local_err =3D NULL; + uint64_t allocated_bytes =3D 0; + uint64_t prealloc_size; + uint64_t size; + uint64_t refcount_bits; + size_t cluster_size; + int version; + + size =3D ROUND_UP(qemu_opt_get_size_del(opts, BLOCK_OPT_SIZE, 0), + BDRV_SECTOR_SIZE); + + cluster_size =3D qcow2_opt_get_cluster_size_del(opts, &local_err); + if (local_err) { + goto err; + } + + version =3D qcow2_opt_get_version_del(opts, &local_err); + if (local_err) { + goto err; + } + + refcount_bits =3D qcow2_opt_get_refcount_bits_del(opts, version, &loca= l_err); + if (local_err) { + goto err; + } + + if (in_bs) { + int64_t ssize =3D bdrv_getlength(in_bs); + if (ssize < 0) { + error_setg_errno(errp, -ssize, "Unable to get image size"); + return; + } + + size =3D ssize; + + /* TODO How many clusters are allocated modulo backing file in opt= s? */ + } + + prealloc_size =3D qcow2_calc_prealloc_size(size, cluster_size, + ctz32(refcount_bits)); + info->required_bytes =3D prealloc_size - (align_offset(size, cluster_s= ize) - + allocated_bytes); + info->fully_allocated_bytes =3D prealloc_size; + return; + +err: + error_propagate(errp, local_err); +} + static int qcow2_get_info(BlockDriverState *bs, BlockDriverInfo *bdi) { BDRVQcow2State *s =3D bs->opaque; @@ -3487,6 +3539,7 @@ BlockDriver bdrv_qcow2 =3D { .bdrv_snapshot_delete =3D qcow2_snapshot_delete, .bdrv_snapshot_list =3D qcow2_snapshot_list, .bdrv_snapshot_load_tmp =3D qcow2_snapshot_load_tmp, + .bdrv_measure =3D qcow2_measure, .bdrv_get_info =3D qcow2_get_info, .bdrv_get_specific_info =3D qcow2_get_specific_info, =20 --=20 2.9.3