From nobody Sat May 4 00:46:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1489491636607579.385273660481; Tue, 14 Mar 2017 04:40:36 -0700 (PDT) Received: from localhost ([::1]:57906 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnkod-0006Jb-EL for importer@patchew.org; Tue, 14 Mar 2017 07:40:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnknr-0006I4-MO for qemu-devel@nongnu.org; Tue, 14 Mar 2017 07:39:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnkno-0005UF-I7 for qemu-devel@nongnu.org; Tue, 14 Mar 2017 07:39:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52774) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cnkno-0005SY-D7 for qemu-devel@nongnu.org; Tue, 14 Mar 2017 07:39:44 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DC19E47CF for ; Tue, 14 Mar 2017 11:39:43 +0000 (UTC) Received: from donizetti.redhat.com (ovpn-117-149.ams2.redhat.com [10.36.117.149]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v2EBdgOQ005635; Tue, 14 Mar 2017 07:39:42 -0400 From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 14 Mar 2017 12:39:41 +0100 Message-Id: <20170314113941.15362-1-pbonzini@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 14 Mar 2017 11:39:43 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] coverity-model: model address_space_read/write X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: armbru@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When more complexity was added to facilitate inlining, Coverity lost the ability to use the address_space_rw model for address_space_read/write. This causes false positive defects when Coverity sees a length-8 write in address_space_read and a length-4 (e.g. int*) buffer to read into. As long as the size of the buffer is okay, this is a false positive. Signed-off-by: Paolo Bonzini --- scripts/coverity-model.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/scripts/coverity-model.c b/scripts/coverity-model.c index ee5bf9d..2e30150 100644 --- a/scripts/coverity-model.c +++ b/scripts/coverity-model.c @@ -79,6 +79,25 @@ MemTxResult address_space_rw(AddressSpace *as, hwaddr ad= dr, MemTxAttrs attrs, return result; } =20 +MemTxResult address_space_read(AddressSpace *as, hwaddr addr, + MemTxAttrs attrs, + uint8_t *buf, int len) +{ + MemTxResult result; + __bufwrite(buf, len); + return result; +} + +MemTxResult address_space_write(AddressSpace *as, hwaddr addr, + MemTxAttrs attrs, + const uint8_t *buf, int len) +{ + MemTxResult result; + __bufread(buf, len); + return result; +} + + /* Tainting */ =20 typedef struct {} name2keysym_t; --=20 2.9.3