From nobody Fri May 3 06:09:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1489487387019783.0413354560071; Tue, 14 Mar 2017 03:29:47 -0700 (PDT) Received: from localhost ([::1]:57611 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnji5-0000LZ-Pi for importer@patchew.org; Tue, 14 Mar 2017 06:29:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnjgq-0008Iu-US for qemu-devel@nongnu.org; Tue, 14 Mar 2017 06:28:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnjgn-00025v-P7 for qemu-devel@nongnu.org; Tue, 14 Mar 2017 06:28:29 -0400 Received: from [59.151.112.132] (port=28475 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnjgn-00023A-DU for qemu-devel@nongnu.org; Tue, 14 Mar 2017 06:28:25 -0400 Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 14 Mar 2017 18:28:20 +0800 Received: from G08CNEXCHPEKD01.g08.fujitsu.local (unknown [10.167.33.80]) by cn.fujitsu.com (Postfix) with ESMTP id AEF6E48A2968; Tue, 14 Mar 2017 18:28:20 +0800 (CST) Received: from localhost (10.167.226.75) by G08CNEXCHPEKD01.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server id 14.3.319.2; Tue, 14 Mar 2017 18:28:18 +0800 X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; d="scan'208";a="16553069" From: Chao Fan To: , , , , Date: Tue, 14 Mar 2017 18:27:47 +0800 Message-ID: <20170314102747.31395-1-fanc.fnst@cn.fujitsu.com> X-Mailer: git-send-email 2.9.3 MIME-Version: 1.0 X-yoursite-MailScanner-ID: AEF6E48A2968.ACE07 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: fanc.fnst@cn.fujitsu.com X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 59.151.112.132 Subject: [Qemu-devel] [PATCH] Output dirty-bytes-rate instead of dirty-pages-rate X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: douly.fnst@cn.fujitsu.com, caoj.fnst@cn.fujitsu.com, Chao Fan , maozy.fnst@cn.fujitsu.com, Li Zhijian Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In hmp, dirty-bytes-rate is more friendly than dirty-pages-rate. It's also better for other tools to determine the cpu throttle value in different architecture. Signed-off-by: Chao Fan Signed-off-by: Li Zhijian --- hmp.c | 6 +++--- migration/migration.c | 2 +- qapi-schema.json | 8 ++++---- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hmp.c b/hmp.c index 261843f..7334bc5 100644 --- a/hmp.c +++ b/hmp.c @@ -215,9 +215,9 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict) info->ram->normal_bytes >> 10); monitor_printf(mon, "dirty sync count: %" PRIu64 "\n", info->ram->dirty_sync_count); - if (info->ram->dirty_pages_rate) { - monitor_printf(mon, "dirty pages rate: %" PRIu64 " pages\n", - info->ram->dirty_pages_rate); + if (info->ram->dirty_bytes_rate) { + monitor_printf(mon, "dirty bytes rate: %" PRIu64 " bytes/s\n", + info->ram->dirty_bytes_rate); } if (info->ram->postcopy_requests) { monitor_printf(mon, "postcopy request count: %" PRIu64 "\n", diff --git a/migration/migration.c b/migration/migration.c index 3dab684..7e7b62c 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -648,7 +648,7 @@ static void populate_ram_info(MigrationInfo *info, Migr= ationState *s) =20 if (s->state !=3D MIGRATION_STATUS_COMPLETED) { info->ram->remaining =3D ram_bytes_remaining(); - info->ram->dirty_pages_rate =3D s->dirty_pages_rate; + info->ram->dirty_bytes_rate =3D s->dirty_bytes_rate; } } =20 diff --git a/qapi-schema.json b/qapi-schema.json index 32b4a4b..83a45f8 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -565,9 +565,6 @@ # # @normal-bytes: number of normal bytes sent (since 1.2) # -# @dirty-pages-rate: number of pages dirtied by second by the -# guest (since 1.3) -# # @mbps: throughput in megabits/sec. (since 1.6) # # @dirty-sync-count: number of times that dirty ram was synchronized (sinc= e 2.1) @@ -575,12 +572,15 @@ # @postcopy-requests: The number of page requests received from the destin= ation # (since 2.7) # +# @dirty-bytes-rate: how many bytes dirtied by second by the +# guest (since 2.9) +# # Since: 0.14.0 ## { 'struct': 'MigrationStats', 'data': {'transferred': 'int', 'remaining': 'int', 'total': 'int' , 'duplicate': 'int', 'skipped': 'int', 'normal': 'int', - 'normal-bytes': 'int', 'dirty-pages-rate' : 'int', + 'normal-bytes': 'int', 'dirty-bytes-rate' : 'int', 'mbps' : 'number', 'dirty-sync-count' : 'int', 'postcopy-requests' : 'int' } } =20 --=20 2.9.3