From nobody Fri May 3 04:43:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1489465660293444.0289791147933; Mon, 13 Mar 2017 21:27:40 -0700 (PDT) Received: from localhost ([::1]:56297 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cne3e-0007S6-Id for importer@patchew.org; Tue, 14 Mar 2017 00:27:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cne2d-0007Rm-09 for qemu-devel@nongnu.org; Tue, 14 Mar 2017 00:26:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cne2c-0007AF-7X for qemu-devel@nongnu.org; Tue, 14 Mar 2017 00:26:35 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:32855) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cne2b-00077f-R3; Tue, 14 Mar 2017 00:26:34 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 3vj1s125Y0z9s2G; Tue, 14 Mar 2017 15:26:29 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1489465589; bh=jNoKdkAJlXX4OhaAA+Jl7Q3Gic5sEwXZttcbruDZF9g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TLZrKfu8mQpjWFhsRljJrjxi3VJSqEbNjM23oHvaYsXdYgdi4Ke1AwdRLio8JHONm duaFQAl2gVhuw6I/NSsg7eXMYfWk3A5a8bB2TY68an5gbXYp9EBY9u2oLJ92imO+wz f6QWQHUcAARg6HIKJr38uDd6WBb+p7Y9f+NnNdZ0= From: David Gibson To: peter.maydell@linaro.org Date: Tue, 14 Mar 2017 15:26:23 +1100 Message-Id: <20170314042626.20020-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170314042626.20020-1-david@gibson.dropbear.id.au> References: <20170314042626.20020-1-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PULL 1/4] target/ppc: Fix wrong number of UAMR register X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, thuth@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, agraf@suse.de, aik@ozlabs.ru, qemu-ppc@nongnu.org, pbonzini@redhat.com, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Thomas Huth The SPR UAMR has the number 13, and not 12. (Fortunately it seems like Linux is not using this register yet - only the privileged version with number 29 ... that's why nobody noticed this problem yet) Signed-off-by: Thomas Huth Signed-off-by: David Gibson --- target/ppc/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h index 7c4a1f5..5ee33b3 100644 --- a/target/ppc/cpu.h +++ b/target/ppc/cpu.h @@ -1408,7 +1408,7 @@ int ppc_compat_max_threads(PowerPCCPU *cpu); #define SPR_601_UDECR (0x006) #define SPR_LR (0x008) #define SPR_CTR (0x009) -#define SPR_UAMR (0x00C) +#define SPR_UAMR (0x00D) #define SPR_DSCR (0x011) #define SPR_DSISR (0x012) #define SPR_DAR (0x013) /* DAE for PowerPC 601 */ --=20 2.9.3 From nobody Fri May 3 04:43:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1489465661974305.11912004296516; Mon, 13 Mar 2017 21:27:41 -0700 (PDT) Received: from localhost ([::1]:56299 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cne3g-0007Sv-JW for importer@patchew.org; Tue, 14 Mar 2017 00:27:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cne2d-0007Ro-Kd for qemu-devel@nongnu.org; Tue, 14 Mar 2017 00:26:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cne2c-0007AU-BA for qemu-devel@nongnu.org; Tue, 14 Mar 2017 00:26:35 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:54363) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cne2b-00077g-TW; Tue, 14 Mar 2017 00:26:34 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 3vj1s130pcz9s78; Tue, 14 Mar 2017 15:26:29 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1489465589; bh=llbAvyIeEry/Tqd+C0WJciVTNVrK2XZSTZhLHmX8KJc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bZhK5ost5RrI7aaqrUM3ePeONOMlQ7gacuXdInUxNMXATHIIjXVqEVx+Wdc7Wlaz5 PZxdVBn+eA8QAk65pvH7Tv8M0v4X75d/F2n+mdBBCmkDBAmfFscG17+AA3Q9QqIvJt LSv0WkaJNwRdnP2UN7db6q76dxOrnb5K79601ozk= From: David Gibson To: peter.maydell@linaro.org Date: Tue, 14 Mar 2017 15:26:24 +1100 Message-Id: <20170314042626.20020-3-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170314042626.20020-1-david@gibson.dropbear.id.au> References: <20170314042626.20020-1-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PULL 2/4] target/ppc: fix cpu_ov setting for 32-bit X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, thuth@redhat.com, Nikunj A Dadhania , qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, agraf@suse.de, aik@ozlabs.ru, qemu-ppc@nongnu.org, pbonzini@redhat.com, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Nikunj A Dadhania A bug was introduced in following commit: dc0ad84 target/ppc: update overflow flags for add/sub As for 32-bit ppc target extracting bit 63 for overflow is not correct. Made it dependent on TARGET_LOG_BITS. This had broken booting MacOS 9.2.1 image Reported-by: Mark Cave-Ayland Signed-off-by: Nikunj A Dadhania Signed-off-by: David Gibson Tested-by: Mark Cave-Ayland --- target/ppc/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index b6abc60..f40b5a1 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -818,7 +818,7 @@ static inline void gen_op_arith_compute_ov(DisasContext= *ctx, TCGv arg0, if (is_isa300(ctx)) { tcg_gen_extract_tl(cpu_ov32, cpu_ov, 31, 1); } - tcg_gen_extract_tl(cpu_ov, cpu_ov, 63, 1); + tcg_gen_extract_tl(cpu_ov, cpu_ov, TARGET_LONG_BITS - 1, 1); } tcg_gen_or_tl(cpu_so, cpu_so, cpu_ov); } --=20 2.9.3 From nobody Fri May 3 04:43:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1489465790676743.2764638769879; Mon, 13 Mar 2017 21:29:50 -0700 (PDT) Received: from localhost ([::1]:56311 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cne5l-00015J-BG for importer@patchew.org; Tue, 14 Mar 2017 00:29:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48949) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cne2f-0007S3-7O for qemu-devel@nongnu.org; Tue, 14 Mar 2017 00:26:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cne2c-00079u-4v for qemu-devel@nongnu.org; Tue, 14 Mar 2017 00:26:37 -0400 Received: from ozlabs.org ([103.22.144.67]:39877) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cne2b-00077W-BF; Tue, 14 Mar 2017 00:26:34 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 3vj1s155rpz9s7H; Tue, 14 Mar 2017 15:26:29 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1489465589; bh=QaCKbTMcjvuJY/SuT1Xh6/PmHnJEvVWcj32aTR0FIHo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L0M0uTsqfIX5WeH30p9CvLu+9UHZ1KKdKeYz7j+PP24jLyDZ0/GEQPNtj+eIh55Qm XtIf8z/S+zuYZpixIW7pu7dF0TBrmxumqXWOXRp+x1oWCO+ATmAqUb3AVQJdGE4057 VgVIUofOC+A/OgUukBIRMJ2Dk5pFAxyC6xgZXZTs= From: David Gibson To: peter.maydell@linaro.org Date: Tue, 14 Mar 2017 15:26:25 +1100 Message-Id: <20170314042626.20020-4-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170314042626.20020-1-david@gibson.dropbear.id.au> References: <20170314042626.20020-1-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 103.22.144.67 Subject: [Qemu-devel] [PULL 3/4] pseries: Don't expose PCIe extended config space on older machine types X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, thuth@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, agraf@suse.de, aik@ozlabs.ru, qemu-ppc@nongnu.org, pbonzini@redhat.com, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" bb9986452 "spapr_pci: Advertise access to PCIe extended config space" allowed guests to access the extended config space of PCI Express devices via the PAPR interfaces, even though the paravirtualized bus mostly acts like plain PCI. However, that patch enabled access unconditionally, including for existing machine types, which is an unwise change in behaviour. This patch limits the change to pseries-2.9 (and later) machine types. Suggested-by: Andrea Bolognani Signed-off-by: David Gibson --- hw/ppc/spapr.c | 9 +++++++-- hw/ppc/spapr_pci.c | 4 +++- include/hw/pci-host/spapr.h | 2 ++ 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index c3bb991..6ee566d 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -3163,8 +3163,13 @@ DEFINE_SPAPR_MACHINE(2_9, "2.9", true); /* * pseries-2.8 */ -#define SPAPR_COMPAT_2_8 \ - HW_COMPAT_2_8 +#define SPAPR_COMPAT_2_8 \ + HW_COMPAT_2_8 \ + { \ + .driver =3D TYPE_SPAPR_PCI_HOST_BRIDGE, \ + .property =3D "pcie-extended-configuration-space", \ + .value =3D "off", \ + }, =20 static void spapr_machine_2_8_instance_options(MachineState *machine) { diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 919d3c2..98c52e4 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -1321,7 +1321,7 @@ static int spapr_populate_pci_child_dt(PCIDevice *dev= , void *fdt, int offset, _FDT(fdt_setprop(fdt, offset, "assigned-addresses", (uint8_t *)rp.assigned, rp.assigned_len)); =20 - if (pci_is_express(dev)) { + if (sphb->pcie_ecs && pci_is_express(dev)) { _FDT(fdt_setprop_cell(fdt, offset, "ibm,pci-config-space-type", 0x= 1)); } =20 @@ -1858,6 +1858,8 @@ static Property spapr_phb_properties[] =3D { DEFINE_PROP_UINT32("numa_node", sPAPRPHBState, numa_node, -1), DEFINE_PROP_BOOL("pre-2.8-migration", sPAPRPHBState, pre_2_8_migration, false), + DEFINE_PROP_BOOL("pcie-extended-configuration-space", sPAPRPHBState, + pcie_ecs, true), DEFINE_PROP_END_OF_LIST(), }; =20 diff --git a/include/hw/pci-host/spapr.h b/include/hw/pci-host/spapr.h index dfa7614..1c2e970 100644 --- a/include/hw/pci-host/spapr.h +++ b/include/hw/pci-host/spapr.h @@ -80,6 +80,8 @@ struct sPAPRPHBState { =20 uint32_t numa_node; =20 + bool pcie_ecs; /* Allow access to PCIe extended config space? */ + /* Fields for migration compatibility hacks */ bool pre_2_8_migration; uint32_t mig_liobn; --=20 2.9.3 From nobody Fri May 3 04:43:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1489465664565220.65800654217776; Mon, 13 Mar 2017 21:27:44 -0700 (PDT) Received: from localhost ([::1]:56300 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cne3j-0007TZ-1C for importer@patchew.org; Tue, 14 Mar 2017 00:27:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cne2f-0007S4-7g for qemu-devel@nongnu.org; Tue, 14 Mar 2017 00:26:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cne2c-00079w-5B for qemu-devel@nongnu.org; Tue, 14 Mar 2017 00:26:37 -0400 Received: from ozlabs.org ([103.22.144.67]:53359) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cne2b-00077X-BI; Tue, 14 Mar 2017 00:26:34 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 3vj1s147Xpz9s7C; Tue, 14 Mar 2017 15:26:29 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1489465589; bh=56TF73Ov6L8EnrNE5X4cTSS4mhDHul3BT4PZ7feZjac=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a/KJAKFcgKnJ4egxhlONrnowG6SqkhgsfO1nIlEhlnyv18cODTezcmYXoy1bGIqUK bD4tLChsIP5qY2ClYere8q1hyqdQb5hq3H9uWMMzuHbTnuBMfDPAFJO9uTV4ABLV6A KspLsVR/c55jQ2voWlccr3LHPGkycrWbbmRjBjSY= From: David Gibson To: peter.maydell@linaro.org Date: Tue, 14 Mar 2017 15:26:26 +1100 Message-Id: <20170314042626.20020-5-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170314042626.20020-1-david@gibson.dropbear.id.au> References: <20170314042626.20020-1-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 103.22.144.67 Subject: [Qemu-devel] [PULL 4/4] dtc: Update submodule to avoid build errors X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, thuth@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, agraf@suse.de, aik@ozlabs.ru, qemu-ppc@nongnu.org, pbonzini@redhat.com, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The currently included version of the dtc/libfdt submodule has some build errors on certain distributions (including RHEL7). This is due to some poorly named macros in libfdt.h; they're designed for use with the sparse static checker, but use reserved names which conflict with some symbols in the standard headers. That's been corrected in upstream dtc, this updates the qemu submodule to bring the fix to qemu. Signed-off-by: David Gibson --- dtc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dtc b/dtc index fa8bc7f..558cd81 160000 --- a/dtc +++ b/dtc @@ -1 +1 @@ -Subproject commit fa8bc7f928ac25f23532afc8beb2073efc8fb063 +Subproject commit 558cd81bdd432769b59bff01240c44f82cfb1a9d --=20 2.9.3