From nobody Sun Oct 5 21:00:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 14894358279714.412306871176838; Mon, 13 Mar 2017 13:10:27 -0700 (PDT) Received: from localhost ([::1]:54166 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnWIU-0003eI-JW for importer@patchew.org; Mon, 13 Mar 2017 16:10:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnW4f-0000iv-39 for qemu-devel@nongnu.org; Mon, 13 Mar 2017 15:56:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnW4e-0002Wl-3b for qemu-devel@nongnu.org; Mon, 13 Mar 2017 15:56:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43302) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cnW4d-0002WD-RS for qemu-devel@nongnu.org; Mon, 13 Mar 2017 15:56:08 -0400 Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C96E4C05B1D3 for ; Mon, 13 Mar 2017 19:56:07 +0000 (UTC) Received: from red.redhat.com (unknown [10.10.121.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id 21CCB2D5C9; Mon, 13 Mar 2017 19:56:07 +0000 (UTC) From: Eric Blake To: qemu-devel@nongnu.org Date: Mon, 13 Mar 2017 14:55:31 -0500 Message-Id: <20170313195547.21466-15-eblake@redhat.com> In-Reply-To: <20170313195547.21466-1-eblake@redhat.com> References: <20170313195547.21466-1-eblake@redhat.com> X-Scanned-By: MIMEDefang 2.74 on 10.5.11.28 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 13 Mar 2017 19:56:07 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 14/30] trace: Fix parameter types in hw/display X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stefanha@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" An upcoming patch will let the compiler warn us when we are silently losing precision in traces; update the trace definitions to pass through the full value at the callsite. Signed-off-by: Eric Blake --- hw/display/trace-events | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/hw/display/trace-events b/hw/display/trace-events index 3e896d2..515767d 100644 --- a/hw/display/trace-events +++ b/hw/display/trace-events @@ -10,17 +10,17 @@ xenfb_input_connected(void *xendev, int abs_pointer_wan= ted) "%p abs %d" # hw/display/g364fb.c g364fb_read(uint64_t addr, uint32_t val) "read addr=3D0x%"PRIx64": 0x%x" -g364fb_write(uint64_t addr, uint32_t new) "write addr=3D0x%"PRIx64": 0x%x" +g364fb_write(uint64_t addr, uint64_t new) "write addr=3D0x%"PRIx64": 0x%" = PRIx64 # hw/display/milkymist-tmu2.c -milkymist_tmu2_memory_read(uint32_t addr, uint32_t value) "addr %08x value= %08x" -milkymist_tmu2_memory_write(uint32_t addr, uint32_t value) "addr %08x valu= e %08x" +milkymist_tmu2_memory_read(hwaddr addr, uint32_t value) "addr %08" HWADDR_= PRIx " value %08x" +milkymist_tmu2_memory_write(hwaddr addr, uint64_t value) "addr %08" HWADDR= _PRIx " value %08" PRIx64 milkymist_tmu2_start(void) "Start TMU" milkymist_tmu2_pulse_irq(void) "Pulse IRQ" # hw/display/milkymist-vgafb.c -milkymist_vgafb_memory_read(uint32_t addr, uint32_t value) "addr %08x valu= e %08x" -milkymist_vgafb_memory_write(uint32_t addr, uint32_t value) "addr %08x val= ue %08x" +milkymist_vgafb_memory_read(hwaddr addr, uint32_t value) "addr %08" HWADDR= _PRIx " value %08x" +milkymist_vgafb_memory_write(hwaddr addr, uint64_t value) "addr %08" HWADD= R_PRIx " value %08" PRIx64 # hw/display/vmware_vga.c vmware_value_read(uint32_t index, uint32_t value) "index %d, value 0x%x" @@ -61,11 +61,11 @@ qxl_create_guest_primary_rest(int qid, int32_t stride, = uint32_t type, uint32_t f qxl_destroy_primary(int qid) "%d" qxl_enter_vga_mode(int qid) "%d" qxl_exit_vga_mode(int qid) "%d" -qxl_hard_reset(int qid, int64_t loadvm) "%d loadvm=3D%"PRId64 +qxl_hard_reset(int qid, int loadvm) "%d loadvm=3D%d" qxl_interface_async_complete_io(int qid, uint32_t current_async, void *coo= kie) "%d current=3D%d cookie=3D%p" qxl_interface_attach_worker(int qid) "%d" qxl_interface_get_init_info(int qid) "%d" -qxl_interface_set_compression_level(int qid, int64_t level) "%d %"PRId64 +qxl_interface_set_compression_level(int qid, int level) "%d %d" qxl_interface_update_area_complete(int qid, uint32_t surface_id, uint32_t = dirty_left, uint32_t dirty_right, uint32_t dirty_top, uint32_t dirty_bottom= ) "%d surface=3D%d [%d,%d,%d,%d]" qxl_interface_update_area_complete_rest(int qid, uint32_t num_updated_rect= s) "%d #=3D%d" qxl_interface_update_area_complete_overflow(int qid, int max) "%d max=3D%d" @@ -112,7 +112,7 @@ qxl_interrupt_client_monitors_config(int qid, int num_h= eads, void *heads) "%d %d qxl_client_monitors_config_unsupported_by_guest(int qid, uint32_t int_mask= , void *client_monitors_config) "%d %X %p" qxl_client_monitors_config_unsupported_by_device(int qid, int revision) "%= d revision=3D%d" qxl_client_monitors_config_capped(int qid, int requested, int limit) "%d %= d %d" -qxl_client_monitors_config_crc(int qid, unsigned size, uint32_t crc32) "%d= %u %u" +qxl_client_monitors_config_crc(int qid, size_t size, uint32_t crc32) "%d %= zu %u" qxl_set_client_capabilities_unsupported_by_revision(int qid, int revision)= "%d revision=3D%d" # hw/display/qxl-render.c @@ -127,7 +127,7 @@ vga_vbe_read(uint32_t index, uint32_t val) "index 0x%x,= val 0x%x" vga_vbe_write(uint32_t index, uint32_t val) "index 0x%x, val 0x%x" # hw/display/cirrus_vga.c -vga_cirrus_read_io(uint32_t addr, uint32_t val) "addr 0x%x, val 0x%x" -vga_cirrus_write_io(uint32_t addr, uint32_t val) "addr 0x%x, val 0x%x" +vga_cirrus_read_io(hwaddr addr, int val) "addr 0x%" HWADDR_PRIx ", val 0x%= x" +vga_cirrus_write_io(hwaddr addr, uint64_t val) "addr 0x%" HWADDR_PRIx ", v= al 0x%" PRIx64 vga_cirrus_read_blt(uint32_t offset, uint32_t val) "offset 0x%x, val 0x%x" vga_cirrus_write_blt(uint32_t offset, uint32_t val) "offset 0x%x, val 0x%x" --=20 2.9.3