From nobody Thu Nov 6 15:16:10 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1489087939281589.7524184041933; Thu, 9 Mar 2017 11:32:19 -0800 (PST) Received: from localhost ([::1]:35967 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cm3nN-0000ie-PY for importer@patchew.org; Thu, 09 Mar 2017 14:32:17 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59777) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cm3mp-0000h8-RN for qemu-devel@nongnu.org; Thu, 09 Mar 2017 14:31:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cm3mm-0000yu-En for qemu-devel@nongnu.org; Thu, 09 Mar 2017 14:31:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40020) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cm3mm-0000yN-95 for qemu-devel@nongnu.org; Thu, 09 Mar 2017 14:31:40 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 124E14E359 for ; Thu, 9 Mar 2017 19:31:38 +0000 (UTC) Received: from localhost (ovpn-116-55.gru2.redhat.com [10.97.116.55]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v29JVa1E004381; Thu, 9 Mar 2017 14:31:37 -0500 From: Eduardo Habkost To: qemu-devel@nongnu.org, Paolo Bonzini Date: Thu, 9 Mar 2017 16:31:17 -0300 Message-Id: <20170309193117.24885-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 09 Mar 2017 19:31:39 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH for-2.10] kvm: Print MSR information if KVM_SET_MSRS failed X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When a KVM_SET_MSRS ioctl() fails, it is difficult to find out which MSR caused the problem. Print an error message for debugging, before we trigger the (ret =3D=3D cpu->kvm_msr_buf->nmsrs) assert. Signed-off-by: Eduardo Habkost Reviewed-by: Dr. David Alan Gilbert Suggested-by: Dr. David Alan Gilbert --- target/i386/kvm.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/target/i386/kvm.c b/target/i386/kvm.c index 887a81268f..3a874e4717 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -1807,6 +1807,12 @@ static int kvm_put_msrs(X86CPU *cpu, int level) return ret; } =20 + if (ret < cpu->kvm_msr_buf->nmsrs) { + struct kvm_msr_entry *e =3D &cpu->kvm_msr_buf->entries[ret]; + error_report("error: failed to set MSR 0x%" PRIx32 " to 0x%" PRIx6= 4, + (uint32_t)e->index, (uint64_t)e->data); + } + assert(ret =3D=3D cpu->kvm_msr_buf->nmsrs); return 0; } --=20 2.11.0.259.g40922b1