From nobody Thu Nov 6 17:20:49 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 148908377645036.130404574357044; Thu, 9 Mar 2017 10:22:56 -0800 (PST) Received: from localhost ([::1]:35688 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cm2iD-0003fH-9a for importer@patchew.org; Thu, 09 Mar 2017 13:22:53 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40260) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cm2gQ-0002l2-4P for qemu-devel@nongnu.org; Thu, 09 Mar 2017 13:21:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cm2gO-0004p7-SZ for qemu-devel@nongnu.org; Thu, 09 Mar 2017 13:21:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35158) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cm2gO-0004ot-LB for qemu-devel@nongnu.org; Thu, 09 Mar 2017 13:21:00 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D4BE176F4 for ; Thu, 9 Mar 2017 18:21:00 +0000 (UTC) Received: from localhost (ovpn-116-55.gru2.redhat.com [10.97.116.55]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v29IKwlW031051; Thu, 9 Mar 2017 13:21:00 -0500 From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Thu, 9 Mar 2017 15:20:49 -0300 Message-Id: <20170309182049.30040-3-ehabkost@redhat.com> In-Reply-To: <20170309182049.30040-1-ehabkost@redhat.com> References: <20170309182049.30040-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 09 Mar 2017 18:21:00 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH for-2.9? v2 2/2] vl: Print warning when a default config file is loaded X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Markus Armbruster Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" In case there were options set in the default config file, print a warning so users can update their scripts. If somebody wants to keep the config file as-is, avoid the warning and use a command-line that will work in future QEMU versions, they can use: $QEMU -nodefconfig -readconfig /etc/qemu/qemu.conf I was going to add an additional message suggesting it as a solution, but I thought it could make it more confusing. The solution can be documented in the QEMU 2.9 ChangeLog. Reviewed-by: Markus Armbruster Signed-off-by: Eduardo Habkost --- vl.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/vl.c b/vl.c index 7f1644a2be..dae86fd4a8 100644 --- a/vl.c +++ b/vl.c @@ -2939,6 +2939,12 @@ static int qemu_read_default_config_file(void) return ret; } =20 + if (ret > 0) { + loc_set_none(); + error_report("Warning: Future QEMU versions won't load %s automati= cally", + CONFIG_QEMU_CONFDIR "/qemu.conf"); + } + return 0; } =20 --=20 2.11.0.259.g40922b1