From nobody Fri May 3 07:57:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1488654071638326.226680006225; Sat, 4 Mar 2017 11:01:11 -0800 (PST) Received: from localhost ([::1]:36303 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckEvW-0000Ub-8p for importer@patchew.org; Sat, 04 Mar 2017 14:01:10 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58036) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckErt-0006jw-CA for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:57:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckErq-0008A9-AF for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:57:25 -0500 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:35549) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ckErq-0008A1-6F for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:57:22 -0500 Received: by mail-qk0-x241.google.com with SMTP id n127so35021506qkf.2 for ; Sat, 04 Mar 2017 10:57:22 -0800 (PST) Received: from yoga.lan ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id k8sm10048006qke.54.2017.03.04.10.57.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Mar 2017 10:57:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+5B40VakQzH/npqj/ZH8G8pC+QMY2u8Mh7U71XsFK5Y=; b=ktfdAF4BPu02oHm8uviaTJdiHnaWh1RVs79ib3MzPE1f57NVql1FA/1xlVml1Spn68 a0ui/xcKdST6qSaONZp61EUBZ7PZTfi0DtEiF6JPKxcuBVM1EOQ/10TZCp/dVAwZIv9o QnxYmqTFns7E3fqAtH0dtfs9shOgPZ1FgJ8/6WnD0Ycagxt9kzww1HXvbx7+BHzbUX5m +uTy78khLivYn7RxFPPrMSBceojm5pCkJgpE8dMw3t4+lX513YJ2ka+K1IP78RIV0J5T 0TwDSBlfet1q3imG9Y8hNXi6YEKSgcs/2Hcfms9tPIh969fD6f5hoMRvIgmoG6jr4VRz x/Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=+5B40VakQzH/npqj/ZH8G8pC+QMY2u8Mh7U71XsFK5Y=; b=KrLaoeqvqTYNFha2PqXeN7oE+UfbpHj8oZIbFyQ2YHmBPElozuvIdnxtS/edNjoFZf LUp8Vq+1r4JFrm85t/pY8E8Jt2y/TTwX3LTcJiik7UoEE8Seg11Ek+7e84MyfGu4WWWM rVmtXSWAbJCfGyZRRRgjeOY7F2D7xTxm2jUuuTEU87152g73SZg0amZifCQEC+OJ2G/A ZmLDrU53wS95E+XkyLvrZQx/pj5k8hIomot51az825+mvUSc7DnVfmtkx2dVdCc1x2Lm sZlwMjq5rNE10x+qWNP8bVwLoeeekxS4fgmCtZGSUKxu7qGFOxm6N6xqYS3mVD4Xbp2+ 6l9Q== X-Gm-Message-State: AMke39nHHRE4rqfzmfbkwr9tyOfmalzWwWXMnm8GMZwID5GXg4z4J+TkR3+O7S31xBVnJg== X-Received: by 10.55.212.199 with SMTP id s68mr8629047qks.245.1488653841687; Sat, 04 Mar 2017 10:57:21 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Aurelien Jarno , Yongbok Kim Date: Sat, 4 Mar 2017 15:56:48 -0300 Message-Id: <20170304185652.10675-2-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170304185652.10675-1-f4bug@amsat.org> References: <20170304185652.10675-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c09::241 Subject: [Qemu-devel] [PATCH 1/5] target-mips: fix compiler warnings (clang 5) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 static code analyzer complain: target/mips/helper.c:453:5: warning: Function call argument is an uninitial= ized value qemu_log_mask(CPU_LOG_MMU, ^~~~~~~~~~~~~~~~~~~~~~~~~~ 'physical' and 'prot' are uninitialized if 'ret' is not TLBRET_MATCH. Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Yongbok Kim --- target/mips/helper.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/target/mips/helper.c b/target/mips/helper.c index d2e77958fd..e359ca3b44 100644 --- a/target/mips/helper.c +++ b/target/mips/helper.c @@ -450,10 +450,18 @@ int mips_cpu_handle_mmu_fault(CPUState *cs, vaddr add= ress, int rw, access_type =3D ACCESS_INT; ret =3D get_physical_address(env, &physical, &prot, address, rw, access_type); - qemu_log_mask(CPU_LOG_MMU, - "%s address=3D%" VADDR_PRIx " ret %d physical " TARGET_FMT_plx - " prot %d\n", - __func__, address, ret, physical, prot); + switch (ret) { + case TLBRET_MATCH: + qemu_log_mask(CPU_LOG_MMU, + "%s address=3D%" VADDR_PRIx " physical " TARGET_FMT_= plx + " prot %d\n", __func__, address, physical, prot); + break; + default: + qemu_log_mask(CPU_LOG_MMU, + "%s address=3D%" VADDR_PRIx " ret %d\n", __func__, a= ddress, + ret); + break; + } if (ret =3D=3D TLBRET_MATCH) { tlb_set_page(cs, address & TARGET_PAGE_MASK, physical & TARGET_PAGE_MASK, prot | PAGE_EXEC, --=20 2.11.0 From nobody Fri May 3 07:57:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 148865396502726.872662935102653; Sat, 4 Mar 2017 10:59:25 -0800 (PST) Received: from localhost ([::1]:36291 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckEtn-0007bj-RM for importer@patchew.org; Sat, 04 Mar 2017 13:59:23 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckEru-0006kl-8c for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:57:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckErt-0008BN-Dk for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:57:26 -0500 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:34272) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ckErt-0008BA-7u for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:57:25 -0500 Received: by mail-qk0-x242.google.com with SMTP id g129so6729831qkd.1 for ; Sat, 04 Mar 2017 10:57:25 -0800 (PST) Received: from yoga.lan ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id k8sm10048006qke.54.2017.03.04.10.57.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Mar 2017 10:57:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=inf3THUuQsTcaxCYsYLR5XDufpc0tAswAJc2UdCcJtQ=; b=VZPFu1+BOwAb7ZGkCvb19QEv+ovPMAttbjz2L3iY+XBWH7r+P7J7zuCRQoEpaDSyno 3hYypdIMuC5PfofsfqujxWtKmxDzgdmfHRAWJl8Vy04XNNRBdXFHA71e4ADRSWIEzfYg Nj0lwEx3l5UFWLnru7NmmgkmSC9nFbL+y85MbNX9Pmt51KHJ3t+aFDmyKKSp0zWv9Geg TEylp+uLk7AqSvchKoVxH+zVmbYMV/X2Gdk6EGGGhDgLIT0TBu/B9o48VMr297hWauNd 24/uJzF40t6TpImwCrEO2UyE8GqjmvgmS9bAAMG25vMoZ5H9Kn4Eq891udAZdisfP3h/ KSow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=inf3THUuQsTcaxCYsYLR5XDufpc0tAswAJc2UdCcJtQ=; b=sxKO62VPxlZ+KtaL/XaP7Q8i6M0/+aE0cqV5j2H9f4X3ATeGcgvioJuPm7tSml7eVg 5AkaH1MLPd2czVTPv4ZXqSGWboo9X198gIJEJYTDwtmx/u/seypb/aS3eDJtFbcFNW3b 17AER7ThRaTTylMjwKl7eQb/01l9RveaPFCNxND1YaIO3gec1NmsRpyBu1OlgHul03qt EH5qWfVe+DLqiYgGx9vfdBseQcdNdZuLZERYz+49g7SBKrIWWDytySodEWe646fAD0+F xRiG5bREJ9JrMM11E+tmepZ1yobGplUHaoH+2GQIxOgPy99EI9J0hTJ+DgUNopFaETHd OkdQ== X-Gm-Message-State: AMke39mXX+lIuTasE1/a4tovLuidQLXu+vCYI5o+5jmuyWR0SnWvZKpPNlesLzgq2QUUEg== X-Received: by 10.55.212.8 with SMTP id l8mr9266956qki.52.1488653844725; Sat, 04 Mar 2017 10:57:24 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Aurelien Jarno , Yongbok Kim Date: Sat, 4 Mar 2017 15:56:49 -0300 Message-Id: <20170304185652.10675-3-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170304185652.10675-1-f4bug@amsat.org> References: <20170304185652.10675-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c09::242 Subject: [Qemu-devel] [PATCH 2/5] target-mips: remove old & unuseful comments X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Yongbok Kim --- target/mips/translate.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 8b4a072ecb..1fe0ff39f2 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -5137,7 +5137,6 @@ static void gen_mfc0(DisasContext *ctx, TCGv arg, int= reg, int sel) // gen_helper_mfc0_contextconfig(arg); /* SmartMIPS ASE */ rn =3D "ContextConfig"; goto cp0_unimplemented; -// break; case 2: CP0_CHECK(ctx->ulri); tcg_gen_ld32s_tl(arg, cpu_env, @@ -5791,7 +5790,6 @@ static void gen_mtc0(DisasContext *ctx, TCGv arg, int= reg, int sel) // gen_helper_mtc0_contextconfig(cpu_env, arg); /* SmartMIPS AS= E */ rn =3D "ContextConfig"; goto cp0_unimplemented; -// break; case 2: CP0_CHECK(ctx->ulri); tcg_gen_st_tl(arg, cpu_env, @@ -6454,7 +6452,6 @@ static void gen_dmfc0(DisasContext *ctx, TCGv arg, in= t reg, int sel) // gen_helper_dmfc0_contextconfig(arg); /* SmartMIPS ASE */ rn =3D "ContextConfig"; goto cp0_unimplemented; -// break; case 2: CP0_CHECK(ctx->ulri); tcg_gen_ld_tl(arg, cpu_env, @@ -7092,7 +7089,6 @@ static void gen_dmtc0(DisasContext *ctx, TCGv arg, in= t reg, int sel) // gen_helper_mtc0_contextconfig(cpu_env, arg); /* SmartMIPS ASE= */ rn =3D "ContextConfig"; goto cp0_unimplemented; -// break; case 2: CP0_CHECK(ctx->ulri); tcg_gen_st_tl(arg, cpu_env, --=20 2.11.0 From nobody Fri May 3 07:57:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1488654185046139.05279549758427; Sat, 4 Mar 2017 11:03:05 -0800 (PST) Received: from localhost ([::1]:36314 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckExL-0002Ec-Kf for importer@patchew.org; Sat, 04 Mar 2017 14:03:03 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckEry-0006oW-EP for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:57:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckErx-0008DG-Hw for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:57:30 -0500 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:32979) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ckErx-0008D5-Dz for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:57:29 -0500 Received: by mail-qk0-x244.google.com with SMTP id j127so16936612qke.0 for ; Sat, 04 Mar 2017 10:57:29 -0800 (PST) Received: from yoga.lan ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id k8sm10048006qke.54.2017.03.04.10.57.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Mar 2017 10:57:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jj/GPb8wrhHotIqr5ni7TsJiR1d1ZgX5K7ycZZ4zjaY=; b=LedKl6GyDB2RxL2Y7NlWJu63Dt9d2ZHQ82awODn4kFWh452uVVUvy/bCPvzXdB05H6 P+vWepmmkj/9Eag331zRvjiLzC4S99VciqQox8ruepHsrakVIX7gPTfiP+hXyw1H4JfF lEzXClZI8pcQECS44SMmNWhqS94FCfQpbz2XQAxkxo1/+Uq4kvuQ3MoORYGxZNYQMvdd FHRexzFlV4e+FzCkF+2tDv8Bb7jUByob7je2mf7+/7Vtd6sHIt5VO/2u8PzHoLv2tZrR hfc0HKtWhUiAGFeaimGy/wEHASprfEn2rIf+4zROSHiZAqJrjmtpQixf6mzFlbYUjinU RUbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=jj/GPb8wrhHotIqr5ni7TsJiR1d1ZgX5K7ycZZ4zjaY=; b=dlPlU/8ebjglQWJYsvC1NyhSoXHsH3oTKwrUpIX8j/84E4Z2jrGHwkj12sSGOSlbOY GiYlomy/itiqNPDyVMqhnRSJ7/hblvT2R9rkx+uUPfcNProy0NOH1A1IsfGYX4Avb9oW KLmCaQoFVRuVpdnyn+0ymEP6XTNwb2UGyozKWm0LqmICuWMA7EuBqFstJd+kv0YjT6pM bdCWms7FrYf1FJ9A4PsHu5SfmIdw6QfLrY8iBRfBGfmSWzh3QYbyqOA7qJ5LT3tlZf+/ EdJqqpnaELKRmRB0SjtHX17+21s5JUWm8P6lbMnFRG9xiy3Xm4kH3ilUqHW8wVq0O/o9 hWIA== X-Gm-Message-State: AMke39kCe7UJZA8Mp7GbPoPietPw30Huv0QAHzVbr8W3o1un2sf07c9M1cvVXPW7iFJ7eA== X-Received: by 10.237.63.39 with SMTP id p36mr8147486qtf.187.1488653848886; Sat, 04 Mar 2017 10:57:28 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Aurelien Jarno , Yongbok Kim Date: Sat, 4 Mar 2017 15:56:50 -0300 Message-Id: <20170304185652.10675-4-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170304185652.10675-1-f4bug@amsat.org> References: <20170304185652.10675-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PATCH 3/5] target-mips: log bad coprocessor0 register accesses with LOG_UNIMP X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Yongbok Kim --- target/mips/translate.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 1fe0ff39f2..5c030a90cd 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -4872,7 +4872,7 @@ static void gen_mfhc0(DisasContext *ctx, TCGv arg, in= t reg, int sel) return; =20 cp0_unimplemented: - LOG_DISAS("mfhc0 %s (reg %d sel %d)\n", rn, reg, sel); + qemu_log_mask(LOG_UNIMP, "mfhc0 %s (reg %d sel %d)\n", rn, reg, sel); tcg_gen_movi_tl(arg, 0); } =20 @@ -4944,7 +4944,7 @@ static void gen_mthc0(DisasContext *ctx, TCGv arg, in= t reg, int sel) =20 (void)rn; /* avoid a compiler warning */ cp0_unimplemented: - LOG_DISAS("mthc0 %s (reg %d sel %d)\n", rn, reg, sel); + qemu_log_mask(LOG_UNIMP, "mthc0 %s (reg %d sel %d)\n", rn, reg, sel); } =20 static inline void gen_mfc0_unimplemented(DisasContext *ctx, TCGv arg) @@ -5627,7 +5627,7 @@ static void gen_mfc0(DisasContext *ctx, TCGv arg, int= reg, int sel) return; =20 cp0_unimplemented: - LOG_DISAS("mfc0 %s (reg %d sel %d)\n", rn, reg, sel); + qemu_log_mask(LOG_UNIMP, "mfc0 %s (reg %d sel %d)\n", rn, reg, sel); gen_mfc0_unimplemented(ctx, arg); } =20 @@ -6294,7 +6294,7 @@ static void gen_mtc0(DisasContext *ctx, TCGv arg, int= reg, int sel) return; =20 cp0_unimplemented: - LOG_DISAS("mtc0 %s (reg %d sel %d)\n", rn, reg, sel); + qemu_log_mask(LOG_UNIMP, "mtc0 %s (reg %d sel %d)\n", rn, reg, sel); } =20 #if defined(TARGET_MIPS64) @@ -6928,7 +6928,7 @@ static void gen_dmfc0(DisasContext *ctx, TCGv arg, in= t reg, int sel) return; =20 cp0_unimplemented: - LOG_DISAS("dmfc0 %s (reg %d sel %d)\n", rn, reg, sel); + qemu_log_mask(LOG_UNIMP, "dmfc0 %s (reg %d sel %d)\n", rn, reg, sel); gen_mfc0_unimplemented(ctx, arg); } =20 @@ -7593,7 +7593,7 @@ static void gen_dmtc0(DisasContext *ctx, TCGv arg, in= t reg, int sel) return; =20 cp0_unimplemented: - LOG_DISAS("dmtc0 %s (reg %d sel %d)\n", rn, reg, sel); + qemu_log_mask(LOG_UNIMP, "dmtc0 %s (reg %d sel %d)\n", rn, reg, sel); } #endif /* TARGET_MIPS64 */ =20 --=20 2.11.0 From nobody Fri May 3 07:57:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 148865415402762.91996536637669; Sat, 4 Mar 2017 11:02:34 -0800 (PST) Received: from localhost ([::1]:36312 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckEwq-0001gJ-IT for importer@patchew.org; Sat, 04 Mar 2017 14:02:32 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckEs3-0006sp-T7 for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:57:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckEs0-0008Et-R3 for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:57:35 -0500 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:32984) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ckEs0-0008El-MA for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:57:32 -0500 Received: by mail-qk0-x241.google.com with SMTP id j127so16936811qke.0 for ; Sat, 04 Mar 2017 10:57:32 -0800 (PST) Received: from yoga.lan ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id k8sm10048006qke.54.2017.03.04.10.57.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Mar 2017 10:57:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Qzc/iR4goD0DWigEWxBNYhQPFAdeddk7CvTjpHRdPsg=; b=srIM8L16CUSu2s8ogjKSPJHRjqfdJlpmIBEgg+zXTPc7qScnHKaP3yRHC+KKeiB34W k+DsVfTBg3uoLeLh2zTdyKL6eBng4WfCH93V1i+YqQ1A98dlTLl1PMElGwbiLGkwvkbu 6dN50C8BPC8TQ93eqnA4ceW89znMmxx0fAd81kgOnjMZQj5EjiGDvLZDOzfWHUnDsnfE VlmNlqYNUrcy8tMDj/u5dCK7Jx1EOHKJ+d+g68jSSaXJ/GH1S6LHSy934zgjTh5MSYJU gRUmqjd15HnZJkNpU7yjc+j3UTR7XAr3XDDxjxzAawzh3MPirNQ7qIqYPwYDAYlMu9S8 Abvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Qzc/iR4goD0DWigEWxBNYhQPFAdeddk7CvTjpHRdPsg=; b=Gesj2eJeFegXZfPTq+0Ja9hwoOsDsoKLHLSop7XI9ByiN0gR0scxYPVEAM0inR2l1C PSN5wFwC/0HI5vPv53Tfk6FJStnz8uo4dMCIS3PQ6/RPuN/8hyEoBMVjcQwe1AdddAdz mc7/RaLjRAT/2H3nzgb/NrDBVgy+fJOpr84/Y+PzeYJNOOyOlEUnVgZ8aSzL7fLjEKP/ aJMV+ZHSj4OW/oj1CV4uI5hS+whFjczJUWzCpwaQYKGprvOwD7ppi5ssTapkjwZ7FSm0 Bg82NxRNssm/97FBhQayy0B+D6rIofgYGIwDDTTdninQYX79gC1fs/SRnmwKDuHXbITT V1Tg== X-Gm-Message-State: AMke39nvomA7y37U3eMqL3nQQl7YlPUcd1eLlTJp5jttLSTqxJLcN3BFFRQKFs0Tu33SKA== X-Received: by 10.200.44.235 with SMTP id 40mr8935155qtx.178.1488653852092; Sat, 04 Mar 2017 10:57:32 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Aurelien Jarno , Yongbok Kim Date: Sat, 4 Mar 2017 15:56:51 -0300 Message-Id: <20170304185652.10675-5-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170304185652.10675-1-f4bug@amsat.org> References: <20170304185652.10675-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c09::241 Subject: [Qemu-devel] [PATCH 4/5] target-mips: replace break by goto cp0_unimplemented X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 this fixes many warnings like: target/mips/translate.c:6253:13: warning: Value stored to 'rn' is never read rn =3D "invalid sel"; ^ ~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Yongbok Kim --- target/mips/translate.c | 88 ++++++++++++++++++++++++---------------------= ---- 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 5c030a90cd..fc11e15a17 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -5458,19 +5458,19 @@ static void gen_mfc0(DisasContext *ctx, TCGv arg, i= nt reg, int sel) case 1: // gen_helper_mfc0_tracecontrol(arg); /* PDtrace support */ rn =3D "TraceControl"; -// break; + goto cp0_unimplemented; case 2: // gen_helper_mfc0_tracecontrol2(arg); /* PDtrace support */ rn =3D "TraceControl2"; -// break; + goto cp0_unimplemented; case 3: // gen_helper_mfc0_usertracedata(arg); /* PDtrace support */ rn =3D "UserTraceData"; -// break; + goto cp0_unimplemented; case 4: // gen_helper_mfc0_tracebpc(arg); /* PDtrace support */ rn =3D "TraceBPC"; -// break; + goto cp0_unimplemented; default: goto cp0_unimplemented; } @@ -5496,31 +5496,31 @@ static void gen_mfc0(DisasContext *ctx, TCGv arg, i= nt reg, int sel) case 1: // gen_helper_mfc0_performance1(arg); rn =3D "Performance1"; -// break; + goto cp0_unimplemented; case 2: // gen_helper_mfc0_performance2(arg); rn =3D "Performance2"; -// break; + goto cp0_unimplemented; case 3: // gen_helper_mfc0_performance3(arg); rn =3D "Performance3"; -// break; + goto cp0_unimplemented; case 4: // gen_helper_mfc0_performance4(arg); rn =3D "Performance4"; -// break; + goto cp0_unimplemented; case 5: // gen_helper_mfc0_performance5(arg); rn =3D "Performance5"; -// break; + goto cp0_unimplemented; case 6: // gen_helper_mfc0_performance6(arg); rn =3D "Performance6"; -// break; + goto cp0_unimplemented; case 7: // gen_helper_mfc0_performance7(arg); rn =3D "Performance7"; -// break; + goto cp0_unimplemented; default: goto cp0_unimplemented; } @@ -6116,13 +6116,13 @@ static void gen_mtc0(DisasContext *ctx, TCGv arg, i= nt reg, int sel) rn =3D "TraceControl"; /* Stop translation as we may have switched the execution mode= */ ctx->bstate =3D BS_STOP; -// break; + goto cp0_unimplemented; case 2: // gen_helper_mtc0_tracecontrol2(cpu_env, arg); /* PDtrace supp= ort */ rn =3D "TraceControl2"; /* Stop translation as we may have switched the execution mode= */ ctx->bstate =3D BS_STOP; -// break; + goto cp0_unimplemented; case 3: /* Stop translation as we may have switched the execution mode= */ ctx->bstate =3D BS_STOP; @@ -6130,13 +6130,13 @@ static void gen_mtc0(DisasContext *ctx, TCGv arg, i= nt reg, int sel) rn =3D "UserTraceData"; /* Stop translation as we may have switched the execution mode= */ ctx->bstate =3D BS_STOP; -// break; + goto cp0_unimplemented; case 4: // gen_helper_mtc0_tracebpc(cpu_env, arg); /* PDtrace support */ /* Stop translation as we may have switched the execution mode= */ ctx->bstate =3D BS_STOP; rn =3D "TraceBPC"; -// break; + goto cp0_unimplemented; default: goto cp0_unimplemented; } @@ -6161,31 +6161,31 @@ static void gen_mtc0(DisasContext *ctx, TCGv arg, i= nt reg, int sel) case 1: // gen_helper_mtc0_performance1(arg); rn =3D "Performance1"; -// break; + goto cp0_unimplemented; case 2: // gen_helper_mtc0_performance2(arg); rn =3D "Performance2"; -// break; + goto cp0_unimplemented; case 3: // gen_helper_mtc0_performance3(arg); rn =3D "Performance3"; -// break; + goto cp0_unimplemented; case 4: // gen_helper_mtc0_performance4(arg); rn =3D "Performance4"; -// break; + goto cp0_unimplemented; case 5: // gen_helper_mtc0_performance5(arg); rn =3D "Performance5"; -// break; + goto cp0_unimplemented; case 6: // gen_helper_mtc0_performance6(arg); rn =3D "Performance6"; -// break; + goto cp0_unimplemented; case 7: // gen_helper_mtc0_performance7(arg); rn =3D "Performance7"; -// break; + goto cp0_unimplemented; default: goto cp0_unimplemented; } @@ -6766,19 +6766,19 @@ static void gen_dmfc0(DisasContext *ctx, TCGv arg, = int reg, int sel) case 1: // gen_helper_dmfc0_tracecontrol(arg, cpu_env); /* PDtrace supp= ort */ rn =3D "TraceControl"; -// break; + goto cp0_unimplemented; case 2: // gen_helper_dmfc0_tracecontrol2(arg, cpu_env); /* PDtrace sup= port */ rn =3D "TraceControl2"; -// break; + goto cp0_unimplemented; case 3: // gen_helper_dmfc0_usertracedata(arg, cpu_env); /* PDtrace sup= port */ rn =3D "UserTraceData"; -// break; + goto cp0_unimplemented; case 4: // gen_helper_dmfc0_tracebpc(arg, cpu_env); /* PDtrace support = */ rn =3D "TraceBPC"; -// break; + goto cp0_unimplemented; default: goto cp0_unimplemented; } @@ -6803,31 +6803,31 @@ static void gen_dmfc0(DisasContext *ctx, TCGv arg, = int reg, int sel) case 1: // gen_helper_dmfc0_performance1(arg); rn =3D "Performance1"; -// break; + goto cp0_unimplemented; case 2: // gen_helper_dmfc0_performance2(arg); rn =3D "Performance2"; -// break; + goto cp0_unimplemented; case 3: // gen_helper_dmfc0_performance3(arg); rn =3D "Performance3"; -// break; + goto cp0_unimplemented; case 4: // gen_helper_dmfc0_performance4(arg); rn =3D "Performance4"; -// break; + goto cp0_unimplemented; case 5: // gen_helper_dmfc0_performance5(arg); rn =3D "Performance5"; -// break; + goto cp0_unimplemented; case 6: // gen_helper_dmfc0_performance6(arg); rn =3D "Performance6"; -// break; + goto cp0_unimplemented; case 7: // gen_helper_dmfc0_performance7(arg); rn =3D "Performance7"; -// break; + goto cp0_unimplemented; default: goto cp0_unimplemented; } @@ -7417,25 +7417,25 @@ static void gen_dmtc0(DisasContext *ctx, TCGv arg, = int reg, int sel) /* Stop translation as we may have switched the execution mode= */ ctx->bstate =3D BS_STOP; rn =3D "TraceControl"; -// break; + goto cp0_unimplemented; case 2: // gen_helper_mtc0_tracecontrol2(cpu_env, arg); /* PDtrace supp= ort */ /* Stop translation as we may have switched the execution mode= */ ctx->bstate =3D BS_STOP; rn =3D "TraceControl2"; -// break; + goto cp0_unimplemented; case 3: // gen_helper_mtc0_usertracedata(cpu_env, arg); /* PDtrace supp= ort */ /* Stop translation as we may have switched the execution mode= */ ctx->bstate =3D BS_STOP; rn =3D "UserTraceData"; -// break; + goto cp0_unimplemented; case 4: // gen_helper_mtc0_tracebpc(cpu_env, arg); /* PDtrace support */ /* Stop translation as we may have switched the execution mode= */ ctx->bstate =3D BS_STOP; rn =3D "TraceBPC"; -// break; + goto cp0_unimplemented; default: goto cp0_unimplemented; } @@ -7460,31 +7460,31 @@ static void gen_dmtc0(DisasContext *ctx, TCGv arg, = int reg, int sel) case 1: // gen_helper_mtc0_performance1(cpu_env, arg); rn =3D "Performance1"; -// break; + goto cp0_unimplemented; case 2: // gen_helper_mtc0_performance2(cpu_env, arg); rn =3D "Performance2"; -// break; + goto cp0_unimplemented; case 3: // gen_helper_mtc0_performance3(cpu_env, arg); rn =3D "Performance3"; -// break; + goto cp0_unimplemented; case 4: // gen_helper_mtc0_performance4(cpu_env, arg); rn =3D "Performance4"; -// break; + goto cp0_unimplemented; case 5: // gen_helper_mtc0_performance5(cpu_env, arg); rn =3D "Performance5"; -// break; + goto cp0_unimplemented; case 6: // gen_helper_mtc0_performance6(cpu_env, arg); rn =3D "Performance6"; -// break; + goto cp0_unimplemented; case 7: // gen_helper_mtc0_performance7(cpu_env, arg); rn =3D "Performance7"; -// break; + goto cp0_unimplemented; default: goto cp0_unimplemented; } --=20 2.11.0 From nobody Fri May 3 07:57:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1488654085873436.28187385134447; Sat, 4 Mar 2017 11:01:25 -0800 (PST) Received: from localhost ([::1]:36304 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckEvk-0000ha-JU for importer@patchew.org; Sat, 04 Mar 2017 14:01:24 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58123) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckEs4-0006tD-Ov for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:57:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckEs3-0008Fx-P6 for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:57:36 -0500 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:36165) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ckEs3-0008Fo-K3 for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:57:35 -0500 Received: by mail-qk0-x244.google.com with SMTP id n141so11289041qke.3 for ; Sat, 04 Mar 2017 10:57:35 -0800 (PST) Received: from yoga.lan ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id k8sm10048006qke.54.2017.03.04.10.57.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Mar 2017 10:57:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cZ/jmbE6hqOCkd4CfcY/kyL0OmTuT3QsE6ayM5Z9SoU=; b=HQ3z9XXgl+JC5hOaUUSfQ2/5g9TrHr7zrM6Ywnp5AKYZlU/Itqo6UZMNpBmB1bMV+0 lGRJcVTyS+l01qsP8o5JLn5wmeQi7wNNqBTr7EzJXtOu21tNNwzt/1GFNGuvFSB/kH6p TV3yOI5Iu3q5zzXny5ofLxiOraedr1s8FjOHy2fabKccbwjgYY82D0FvpZFO9msj97k5 QURabe5X+iwAOMaZOElQiRCVAS8Z5Qk5xdgzHrYZ2U9Xb9GuoWalJ9DzqQCPLBDKzVnT x4rnyDNiLatlo5YlhziAaeP2rOrB550eN2VssIsSGh5xZE5diDx/QUqJvj0nU26ZcsIC Cp1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=cZ/jmbE6hqOCkd4CfcY/kyL0OmTuT3QsE6ayM5Z9SoU=; b=PIm6jM4tN5opdWVWDKhk80vstDRP17hoW36ar5sqHBqqwJUJhssTEiRF0VMktBbKJk grmVrkdJWv9oZm7mvnqjHNg3ffnjKs8q/12ID1oEZNp13WBW/Peuy3k7Dvkpyz3MYUpm Btm5evHcTVgiiiK7lZeQZl7FKDe2atRrzvptLw+IOAwaO47E7oIq6hRRbcnNz9jIHDmy RFeKmkq/RiIWvohyBnVdCHvHKi/rwuXTjeu3+X8nqSuEO93POqqWlsG+zomBwlucQe5v G2gDq5F3vMyKbiv2a/6/kx6jiUaPSK6dpW6ez5dW3L1bREpOlUWb7r8LhzBdx3N2v51g 763Q== X-Gm-Message-State: AMke39lxroketBhP5lW0lwndL7zidC6YdhIkS9zuhk6jl3EazdtHEEocj4v6ISWiqBvesA== X-Received: by 10.200.46.27 with SMTP id r27mr9261657qta.221.1488653855049; Sat, 04 Mar 2017 10:57:35 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Aurelien Jarno , Yongbok Kim Date: Sat, 4 Mar 2017 15:56:52 -0300 Message-Id: <20170304185652.10675-6-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170304185652.10675-1-f4bug@amsat.org> References: <20170304185652.10675-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PATCH 5/5] target-mips: replace few LOG_DISAS() with trace points X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Yongbok Kim --- Makefile.objs | 1 + target/mips/trace-events | 5 +++++ target/mips/translate.c | 25 +++++++++++-------------- 3 files changed, 17 insertions(+), 14 deletions(-) create mode 100644 target/mips/trace-events diff --git a/Makefile.objs b/Makefile.objs index e740500e2d..6167e7b17d 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -157,6 +157,7 @@ trace-events-subdirs +=3D audio trace-events-subdirs +=3D net trace-events-subdirs +=3D target/arm trace-events-subdirs +=3D target/i386 +trace-events-subdirs +=3D target/mips trace-events-subdirs +=3D target/sparc trace-events-subdirs +=3D target/s390x trace-events-subdirs +=3D target/ppc diff --git a/target/mips/trace-events b/target/mips/trace-events new file mode 100644 index 0000000000..43824089b3 --- /dev/null +++ b/target/mips/trace-events @@ -0,0 +1,5 @@ +# See docs/tracing.txt for syntax documentation. + +# target/mips/translate.c +mips_translate_c0(const char *instr, const char *rn, int reg, int sel) "%s= %s (reg %d sel %d)" +mips_translate_tr(const char *instr, int rt, int u, int sel, int h) "%s (r= eg %d u %d sel %d h %d)" diff --git a/target/mips/translate.c b/target/mips/translate.c index fc11e15a17..78b7264add 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -33,6 +33,7 @@ #include "sysemu/kvm.h" #include "exec/semihost.h" =20 +#include "target/mips/trace.h" #include "trace-tcg.h" #include "exec/log.h" =20 @@ -4866,9 +4867,7 @@ static void gen_mfhc0(DisasContext *ctx, TCGv arg, in= t reg, int sel) default: goto cp0_unimplemented; } - - (void)rn; /* avoid a compiler warning */ - LOG_DISAS("mfhc0 %s (reg %d sel %d)\n", rn, reg, sel); + trace_mips_translate_c0("mfhc0", rn, reg, sel); return; =20 cp0_unimplemented: @@ -4941,8 +4940,8 @@ static void gen_mthc0(DisasContext *ctx, TCGv arg, in= t reg, int sel) default: goto cp0_unimplemented; } + trace_mips_translate_c0("mthc0", rn, reg, sel); =20 - (void)rn; /* avoid a compiler warning */ cp0_unimplemented: qemu_log_mask(LOG_UNIMP, "mthc0 %s (reg %d sel %d)\n", rn, reg, sel); } @@ -5622,8 +5621,7 @@ static void gen_mfc0(DisasContext *ctx, TCGv arg, int= reg, int sel) default: goto cp0_unimplemented; } - (void)rn; /* avoid a compiler warning */ - LOG_DISAS("mfc0 %s (reg %d sel %d)\n", rn, reg, sel); + trace_mips_translate_c0("mfc0", rn, reg, sel); return; =20 cp0_unimplemented: @@ -6284,8 +6282,8 @@ static void gen_mtc0(DisasContext *ctx, TCGv arg, int= reg, int sel) default: goto cp0_unimplemented; } - (void)rn; /* avoid a compiler warning */ - LOG_DISAS("mtc0 %s (reg %d sel %d)\n", rn, reg, sel); + trace_mips_translate_c0("mtc0", rn, reg, sel); + /* For simplicity assume that all writes can cause interrupts. */ if (ctx->tb->cflags & CF_USE_ICOUNT) { gen_io_end(); @@ -6923,8 +6921,7 @@ static void gen_dmfc0(DisasContext *ctx, TCGv arg, in= t reg, int sel) default: goto cp0_unimplemented; } - (void)rn; /* avoid a compiler warning */ - LOG_DISAS("dmfc0 %s (reg %d sel %d)\n", rn, reg, sel); + trace_mips_translate_c0("dmfc0", rn, reg, sel); return; =20 cp0_unimplemented: @@ -7583,8 +7580,8 @@ static void gen_dmtc0(DisasContext *ctx, TCGv arg, in= t reg, int sel) default: goto cp0_unimplemented; } - (void)rn; /* avoid a compiler warning */ - LOG_DISAS("dmtc0 %s (reg %d sel %d)\n", rn, reg, sel); + trace_mips_translate_c0("dmtc0", rn, reg, sel); + /* For simplicity assume that all writes can cause interrupts. */ if (ctx->tb->cflags & CF_USE_ICOUNT) { gen_io_end(); @@ -7803,7 +7800,7 @@ static void gen_mftr(CPUMIPSState *env, DisasContext = *ctx, int rt, int rd, default: goto die; } - LOG_DISAS("mftr (reg %d u %d sel %d h %d)\n", rt, u, sel, h); + trace_mips_translate_tr("mftr", rt, u, sel, h); gen_store_gpr(t0, rd); tcg_temp_free(t0); return; @@ -8008,7 +8005,7 @@ static void gen_mttr(CPUMIPSState *env, DisasContext = *ctx, int rd, int rt, default: goto die; } - LOG_DISAS("mttr (reg %d u %d sel %d h %d)\n", rd, u, sel, h); + trace_mips_translate_tr("mttr", rd, u, sel, h); tcg_temp_free(t0); return; =20 --=20 2.11.0