From nobody Sat May 4 18:39:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1488653837502245.23612731121318; Sat, 4 Mar 2017 10:57:17 -0800 (PST) Received: from localhost ([::1]:36283 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckErk-0005sa-8C for importer@patchew.org; Sat, 04 Mar 2017 13:57:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57717) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckEqq-0005rI-H0 for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:56:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckEqp-0007Sl-M7 for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:56:20 -0500 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:32897) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ckEqp-0007SX-Hd for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:56:19 -0500 Received: by mail-qk0-x242.google.com with SMTP id j127so16932260qke.0 for ; Sat, 04 Mar 2017 10:56:19 -0800 (PST) Received: from yoga.lan ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id o14sm10065138qtc.46.2017.03.04.10.56.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Mar 2017 10:56:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZNny5TduYcsL1iaP55GB0BUf3QSakI7Nsdf80woC51k=; b=TgtDiaHHuguQ555UByqlFz65hz8iN4jrqaQY74qqxTN1ilsG4ZdKtS+cEVZejzrYDI 5wXT8UZcIY7Y22+3iD+X+i3AZ2LCOsgbbG4eDW3OvMDqaNiYBxI9mHKOmMf961nRfsFA uU5zfrCZumsvs8VesLtFh7xQEL3gv1Tlqqlb6Wq9sqcX6fQfh7zSSs2VcJa7YKOEY6cy WPbyOvX6Dh3orzrCA+abyKr6f2H9Gzk2DXconFoKcNCCAiXrE69G08rk97GUPZs0ey27 oxqEsB0GRFAVKRigHWPgrenzrMKm+0EshcS7ACshLnNYXW62ejo0XWhb8w0liouDwJOt nu2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ZNny5TduYcsL1iaP55GB0BUf3QSakI7Nsdf80woC51k=; b=l4ljkT9e+exCvdjzas8d6x9z1rJKG41hetJks1aj3yAFoow4SOVwq0QJ7xovHlhDU8 pCBV3OaV1GJmFCSIcugioKzclesMTtqtcPiBqcgAFQuMkQoKP3yQs77DYx1MMPBY9J4Z j+ZK5OexcZ91akVNbcFvWukkjfh8jYcX9qTuOmNigeQvS1evO5YNSH2h5AqA0JtoHaty y/y6Z+rDvpcmHmxOAO2szebiRNqNr6X05+C4FpvUtG4ylNFe3XzKIFmM8QPLvEsP8IJM eC6WvQNAjXsc5dTCHw74s2cFsqchvqEUL3veTpjtCjrlFu55GvzF8Iha0j0x/5Ft/sJR 52Aw== X-Gm-Message-State: AMke39kSgpzQGMoLadU05v2jZ1zS20YvaY26D7hOkRYHXt61h5fX6OjjRyQArm7xIVe/qQ== X-Received: by 10.233.239.140 with SMTP id d134mr7832901qkg.313.1488653778942; Sat, 04 Mar 2017 10:56:18 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Michael Roth , Peter Crosthwaite , Alexander Graf , Gerd Hoffmann Date: Sat, 4 Mar 2017 15:55:31 -0300 Message-Id: <20170304185533.10618-2-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170304185533.10618-1-f4bug@amsat.org> References: <20170304185533.10618-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::242 Subject: [Qemu-devel] [PATCH 1/3] usb-ccid: make ccid_write_data_block() cope with null buffers X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 static code analyzer complain: hw/usb/dev-smartcard-reader.c:816:5: warning: Null pointer passed as an arg= ument to a 'nonnull' parameter memcpy(p->abData, data, len); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- hw/usb/dev-smartcard-reader.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c index 757b8b3f5a..c38a4e5886 100644 --- a/hw/usb/dev-smartcard-reader.c +++ b/hw/usb/dev-smartcard-reader.c @@ -799,8 +799,14 @@ static void ccid_write_parameters(USBCCIDState *s, CCI= D_Header *recv) static void ccid_write_data_block(USBCCIDState *s, uint8_t slot, uint8_t s= eq, const uint8_t *data, uint32_t len) { - CCID_DataBlock *p =3D ccid_reserve_recv_buf(s, sizeof(*p) + len); + CCID_DataBlock *p; =20 + if (len =3D=3D 0) { + return; + } + g_assert(data !=3D NULL); + + p =3D ccid_reserve_recv_buf(s, sizeof(*p) + len); if (p =3D=3D NULL) { return; } --=20 2.11.0 From nobody Sat May 4 18:39:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1488653949284878.7484538262831; Sat, 4 Mar 2017 10:59:09 -0800 (PST) Received: from localhost ([::1]:36290 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckEtY-0007Qn-3d for importer@patchew.org; Sat, 04 Mar 2017 13:59:08 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckEqz-0005va-DE for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:56:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckEqy-0007cX-Pp for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:56:29 -0500 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:32911) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ckEqy-0007c1-Lf for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:56:28 -0500 Received: by mail-qk0-x244.google.com with SMTP id j127so16932753qke.0 for ; Sat, 04 Mar 2017 10:56:28 -0800 (PST) Received: from yoga.lan ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id o14sm10065138qtc.46.2017.03.04.10.56.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Mar 2017 10:56:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SqjCnCGnucxBra+5LhiSayVshgbtJGEVJX9iVTpgv6Y=; b=T80tfzCuYPiHPcc6zH0Dgc7ft3jCYepanlWku0hxk8SjV7ccZBmzaLJK8CjwSmBc8/ 5Pg0oxkYTMkcsldijx1Gi5ZvN3G0VCySnnqcAZLY1pXHQQ3vqMmPbZ1lbqrVQPI8gN5Q AwC2ueXQv0sGk1ScuNzDH1iOm4y6BqssegHbgPc0xQzilFtfi6jGRI5zpdyNIqoxsTHB /+m2TFTdVZZT5TERR159iTkwWmli8G2Z8wdTR9bXWPPkMaM9sM23bz96TUxmn14pkce0 vM2+y6rb0dXWwo9nvE0byTBMjn9BK/7je7a9fHK5twEt6xUGgb/03VzsZhN1M3+WM/Lm ziPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=SqjCnCGnucxBra+5LhiSayVshgbtJGEVJX9iVTpgv6Y=; b=AcgzMmRxL2tvoQ4Ytkg4rVBTKFpRZL177Fbozs3iN4wS1zSZoruDMGWD1H7M/awWcy i7mqhtstHhpS6DOq43duhZjYsTmd1J2X2OaOHIhMVpHB525mIdffPlTIr8GlmnTXCAFn cZtQVHiVWETNu7fsLClFyHE46r/wR9pGYl7jMO9uZq6/azYVowcGEMZqj/IA0tB6p88q bjnu939Ao+UE6InZx3pZszvkTIVfwYClnG57HW9YJygA8y4xYKs3q1UxUj9dwQbX41ij nUJJwywq2tmnzCujApM3JQ8p6Fs6sLgJvD8izl9vBQteQ7VmFsrKeDy5znhYLqtzqUFn COOQ== X-Gm-Message-State: AMke39mCahre90/K2ihNro4xTJT5B1+9ji7b6esOCiEp5hJfVjPbL7wQKa6xodUP0dDUNg== X-Received: by 10.237.59.150 with SMTP id r22mr5630722qte.100.1488653788066; Sat, 04 Mar 2017 10:56:28 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Michael Roth , Peter Crosthwaite , Alexander Graf , Gerd Hoffmann Date: Sat, 4 Mar 2017 15:55:32 -0300 Message-Id: <20170304185533.10618-3-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170304185533.10618-1-f4bug@amsat.org> References: <20170304185533.10618-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PATCH 2/3] device_tree: fix compiler warnings (clang 5) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 static code analyzer complain: device_tree.c:155:18: warning: Null pointer passed as an argument to a 'non= null' parameter while ((de =3D readdir(d)) !=3D NULL) { ^~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- device_tree.c | 1 + 1 file changed, 1 insertion(+) diff --git a/device_tree.c b/device_tree.c index 6e06320830..a24ddff02b 100644 --- a/device_tree.c +++ b/device_tree.c @@ -148,6 +148,7 @@ static void read_fstree(void *fdt, const char *dirname) d =3D opendir(dirname); if (!d) { error_setg(&error_fatal, "%s cannot open %s", __func__, dirname); + return; } =20 while ((de =3D readdir(d)) !=3D NULL) { --=20 2.11.0 From nobody Sat May 4 18:39:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1488653850615825.5925489438855; Sat, 4 Mar 2017 10:57:30 -0800 (PST) Received: from localhost ([::1]:36284 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckErx-00060w-BY for importer@patchew.org; Sat, 04 Mar 2017 13:57:29 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckEr3-0005yp-Pt for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:56:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckEr3-0007eS-10 for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:56:33 -0500 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:32918) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ckEr2-0007eE-T4 for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:56:32 -0500 Received: by mail-qk0-x242.google.com with SMTP id j127so16933004qke.0 for ; Sat, 04 Mar 2017 10:56:32 -0800 (PST) Received: from yoga.lan ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id o14sm10065138qtc.46.2017.03.04.10.56.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Mar 2017 10:56:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=quEwaLWvptynyQXKirHCz0ViEa00Yg7/RL0vmC8SBXU=; b=V7eW+rfmNJ/3kao1FZqGi1jIG8aDLIxE19izYdrqWPEt2m16GVhI8EasQ53Pc0+Wy+ kI0Z9Eb6HP8sNCSVdeMJ3FB9spuMhAeqtpD5YSp173h0QrjuItgbU/LbhrgPopJQucfo N6ewYcAfpTKYwHXrBBD6kcMHOI4SNphIjDJEDTACo6yHAu80Agn5LdcN+t8I1kZg0tAU oRRBBuyYuhXkrzKOndjQ+8t47giF5pCGAXRubEnTs9Q50MvYy5tVDPxHAn9lqyweosrr kBz+SN/P9RahjO4RiVY55AVkp9TVV3pKJYLSCXeGZOYs2TtZ6O4760lnBG9sMGyTwqk7 9xZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=quEwaLWvptynyQXKirHCz0ViEa00Yg7/RL0vmC8SBXU=; b=HKQsZZM+DCMCzydXZW8QEnfkggUCV1shdMGjmaFgmXFG73aIscryYnr9IOhgK9Pf6D NCaQ0SbPqTJummNxvJgFUeJjZKxDbeWmCp2EIMZlQRhNmLpFmWEh65LMwZrFmSOUUg+v FDFPiviJSAGOwbqs0z7pA8axC58xoMW96PT6UO9vuJJlHg6dk5y8Uat11KLAUIHGlLK3 Vux5WlAbUzlbcxF5ZNc1pF2ngAspmADLrSnMZykKcCoO2pfJegBWbvuGrRDfCaIeHPu7 W7tgAR+8UbqwWtbfx8QB8J6H2u1nCgRbUClXyngxLnASew+atqo0dqP2J7uRJDOs8xGH Ja/A== X-Gm-Message-State: AMke39kQJlM4UF7c+iKaquBpYWkdpgE3ZuaYk+f6jF87EoWjIOe4AATU17hNF8Q54h8pYw== X-Received: by 10.55.138.129 with SMTP id m123mr2526049qkd.109.1488653792393; Sat, 04 Mar 2017 10:56:32 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Michael Roth , Peter Crosthwaite , Alexander Graf , Gerd Hoffmann Date: Sat, 4 Mar 2017 15:55:33 -0300 Message-Id: <20170304185533.10618-4-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170304185533.10618-1-f4bug@amsat.org> References: <20170304185533.10618-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::242 Subject: [Qemu-devel] [PATCH 3/3] qga: fix compiler warnings (clang 5) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 static code analyzer complain: qga/commands-posix.c:2127:9: warning: Null pointer passed as an argument to= a 'nonnull' parameter closedir(dp); ^~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- qga/commands-posix.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index ea37c097cf..9c4ef2d640 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -2119,9 +2119,11 @@ static void transfer_memory_block(GuestMemoryBlock *= mem_blk, bool sys2memblk, * we think this VM does not support online/offline memory block, * any other solution? */ - if (!dp && errno =3D=3D ENOENT) { - result->response =3D - GUEST_MEMORY_BLOCK_RESPONSE_TYPE_OPERATION_NOT_SUPPORTED; + if (!dp) { + if (errno =3D=3D ENOENT) { + result->response =3D + GUEST_MEMORY_BLOCK_RESPONSE_TYPE_OPERATION_NOT_SUPPORT= ED; + } goto out1; } closedir(dp); --=20 2.11.0