From nobody Tue Feb 10 04:16:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 148854674664156.428789797644185; Fri, 3 Mar 2017 05:12:26 -0800 (PST) Received: from localhost ([::1]:58004 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjn0R-0002GP-D9 for importer@patchew.org; Fri, 03 Mar 2017 08:12:23 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54631) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjmzR-0002DH-4j for qemu-devel@nongnu.org; Fri, 03 Mar 2017 08:11:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjmzQ-0007eZ-7E for qemu-devel@nongnu.org; Fri, 03 Mar 2017 08:11:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49056) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cjmzQ-0007dh-1P for qemu-devel@nongnu.org; Fri, 03 Mar 2017 08:11:20 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4BA5581231; Fri, 3 Mar 2017 13:11:20 +0000 (UTC) Received: from donizetti.redhat.com (ovpn-117-102.ams2.redhat.com [10.36.117.102]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v23DBEjd021579; Fri, 3 Mar 2017 08:11:19 -0500 From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Fri, 3 Mar 2017 14:11:12 +0100 Message-Id: <20170303131113.25898-5-pbonzini@redhat.com> In-Reply-To: <20170303131113.25898-1-pbonzini@redhat.com> References: <20170303131113.25898-1-pbonzini@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 03 Mar 2017 13:11:20 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 4/5] main-loop: remove now unnecessary optimization X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This optimization is not necessary anymore, because the vCPU now drops the I/O thread lock even with TCG. Drop it to simplify the code and avoid the "I/O thread spun for 1000 iterations" warning. Signed-off-by: Paolo Bonzini Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Edgar E. Iglesias --- vl.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/vl.c b/vl.c index bbbf1ba..b21b57e 100644 --- a/vl.c +++ b/vl.c @@ -1884,17 +1884,14 @@ static bool main_loop_should_exit(void) =20 static void main_loop(void) { - bool nonblocking; - int last_io =3D 0; #ifdef CONFIG_PROFILER int64_t ti; #endif do { - nonblocking =3D tcg_enabled() && last_io > 0; #ifdef CONFIG_PROFILER ti =3D profile_getclock(); #endif - last_io =3D main_loop_wait(nonblocking); + main_loop_wait(false); #ifdef CONFIG_PROFILER dev_time +=3D profile_getclock() - ti; #endif --=20 2.9.3