From nobody Thu Nov 6 19:05:53 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1488393085552907.7796549304006; Wed, 1 Mar 2017 10:31:25 -0800 (PST) Received: from localhost ([::1]:48163 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cj924-00082L-EO for importer@patchew.org; Wed, 01 Mar 2017 13:31:24 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cj8xf-00050H-3W for qemu-devel@nongnu.org; Wed, 01 Mar 2017 13:26:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cj8xd-0006yY-Un for qemu-devel@nongnu.org; Wed, 01 Mar 2017 13:26:51 -0500 Received: from mail.kernel.org ([198.145.29.136]:41354) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cj8xY-0006vQ-Q3; Wed, 01 Mar 2017 13:26:45 -0500 Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DA3B320383; Wed, 1 Mar 2017 18:26:42 +0000 (UTC) Received: from localhost.localdomain (bzq-109-67-52-244.red.bezeqint.net [109.67.52.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8D90D20218; Wed, 1 Mar 2017 18:26:39 +0000 (UTC) From: Krzysztof Kozlowski To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org Date: Wed, 1 Mar 2017 20:26:16 +0200 Message-Id: <20170301182618.22395-4-krzk@kernel.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170301182618.22395-1-krzk@kernel.org> References: <20170301182618.22395-1-krzk@kernel.org> X-Virus-Scanned: ClamAV using ClamSMTP X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 198.145.29.136 Subject: [Qemu-devel] [PATCH 3/5] hw/timer/exynos4210_mct: Cleanup indentation and empty new lines X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mitsyanko , Shannon Zhao , Krzysztof Kozlowski Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Statements under 'case' were in some places wrongly indented bringing confusion and making the code less readable. Remove also few unneeded blank lines. No functional changes. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Peter Maydell --- hw/timer/exynos4210_mct.c | 45 ++++++++++++++++++++-----------------------= -- 1 file changed, 20 insertions(+), 25 deletions(-) diff --git a/hw/timer/exynos4210_mct.c b/hw/timer/exynos4210_mct.c index 0c189348ae04..76634fb1b4fd 100644 --- a/hw/timer/exynos4210_mct.c +++ b/hw/timer/exynos4210_mct.c @@ -1015,9 +1015,9 @@ static uint64_t exynos4210_mct_read(void *opaque, hwa= ddr offset, =20 case G_COMP_L(0): case G_COMP_L(1): case G_COMP_L(2): case G_COMP_L(3): case G_COMP_U(0): case G_COMP_U(1): case G_COMP_U(2): case G_COMP_U(3): - index =3D GET_G_COMP_IDX(offset); - shift =3D 8 * (offset & 0x4); - value =3D UINT32_MAX & (s->g_timer.reg.comp[index] >> shift); + index =3D GET_G_COMP_IDX(offset); + shift =3D 8 * (offset & 0x4); + value =3D UINT32_MAX & (s->g_timer.reg.comp[index] >> shift); break; =20 case G_TCON: @@ -1066,7 +1066,6 @@ static uint64_t exynos4210_mct_read(void *opaque, hwa= ddr offset, lt_i =3D GET_L_TIMER_IDX(offset); =20 value =3D exynos4210_lfrc_get_count(&s->l_timer[lt_i]); - break; =20 case L0_TCON: case L1_TCON: @@ -1152,23 +1151,23 @@ static void exynos4210_mct_write(void *opaque, hwad= dr offset, =20 case G_COMP_L(0): case G_COMP_L(1): case G_COMP_L(2): case G_COMP_L(3): case G_COMP_U(0): case G_COMP_U(1): case G_COMP_U(2): case G_COMP_U(3): - index =3D GET_G_COMP_IDX(offset); - shift =3D 8 * (offset & 0x4); - s->g_timer.reg.comp[index] =3D - (s->g_timer.reg.comp[index] & - (((uint64_t)UINT32_MAX << 32) >> shift)) + - (value << shift); + index =3D GET_G_COMP_IDX(offset); + shift =3D 8 * (offset & 0x4); + s->g_timer.reg.comp[index] =3D + (s->g_timer.reg.comp[index] & + (((uint64_t)UINT32_MAX << 32) >> shift)) + + (value << shift); =20 - DPRINTF("comparator %d write 0x%llx val << %d\n", index, value, shift); + DPRINTF("comparator %d write 0x%llx val << %d\n", index, value, sh= ift); =20 - if (offset&0x4) { - s->g_timer.reg.wstat |=3D G_WSTAT_COMP_U(index); - } else { - s->g_timer.reg.wstat |=3D G_WSTAT_COMP_L(index); - } + if (offset&0x4) { + s->g_timer.reg.wstat |=3D G_WSTAT_COMP_U(index); + } else { + s->g_timer.reg.wstat |=3D G_WSTAT_COMP_L(index); + } =20 - exynos4210_gfrc_restart(s); - break; + exynos4210_gfrc_restart(s); + break; =20 case G_TCON: old_val =3D s->g_timer.reg.tcon; @@ -1206,7 +1205,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr= offset, break; =20 case G_INT_ENB: - /* Raise IRQ if transition from disabled to enabled and CSTAT pend= ing */ for (i =3D 0; i < MCT_GT_CMP_NUM; i++) { if ((value & G_INT_ENABLE(i)) > (s->g_timer.reg.tcon & @@ -1287,7 +1285,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr= offset, break; =20 case L0_TCNTB: case L1_TCNTB: - lt_i =3D GET_L_TIMER_IDX(offset); index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); =20 @@ -1315,7 +1312,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr= offset, break; =20 case L0_ICNTB: case L1_ICNTB: - lt_i =3D GET_L_TIMER_IDX(offset); index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); =20 @@ -1352,13 +1348,12 @@ static void exynos4210_mct_write(void *opaque, hwad= dr offset, if (icntb_max[lt_i] < value) { icntb_max[lt_i] =3D value; } -DPRINTF("local timer[%d] ICNTB write %llx; max=3D%x, min=3D%x\n\n", - lt_i, value, icntb_max[lt_i], icntb_min[lt_i]); + DPRINTF("local timer[%d] ICNTB write %llx; max=3D%x, min=3D%x\n\n", + lt_i, value, icntb_max[lt_i], icntb_min[lt_i]); #endif -break; + break; =20 case L0_FRCNTB: case L1_FRCNTB: - lt_i =3D GET_L_TIMER_IDX(offset); index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); =20 --=20 2.9.3