From nobody Thu Nov 6 19:08:54 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1488343528154317.6803249229938; Tue, 28 Feb 2017 20:45:28 -0800 (PST) Received: from localhost ([::1]:38333 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ciw8k-0007vB-UC for importer@patchew.org; Tue, 28 Feb 2017 23:45:26 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46163) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ciw7f-0007tx-1W for qemu-devel@nongnu.org; Tue, 28 Feb 2017 23:44:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ciw7e-0008S2-2B for qemu-devel@nongnu.org; Tue, 28 Feb 2017 23:44:19 -0500 Received: from ozlabs.org ([2401:3900:2:1::2]:46841) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ciw7d-0008RF-L5; Tue, 28 Feb 2017 23:44:17 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 3vY2sQ3824z9s81; Wed, 1 Mar 2017 15:44:10 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1488343450; bh=KOa44rmqmV7VcBddctafURO7TRuDGZHhh4X3Z2UPvM0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H+Af1XPJqVY3iuIUrwRnI/nUI0skO28tiGrdmMejRWvGM7/ezKnxJt49O6xv1jBWr oj0/xhFyLA6bveNeb28wIoSdmFvcIXn4mIWaHERCxd0cfjM8a5+AY9uYGaBBBKaHMp rXWFBX3UWqczBzX7aKFhZ/+5mrqPG6EOHWFw+ZAA= From: David Gibson To: peter.maydell@linaro.org Date: Wed, 1 Mar 2017 15:43:20 +1100 Message-Id: <20170301044405.1792-6-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170301044405.1792-1-david@gibson.dropbear.id.au> References: <20170301044405.1792-1-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PULL 05/50] target/ppc: introduce helper_update_ov_legacy X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, thuth@redhat.com, qemu-devel@nongnu.org, Nikunj A Dadhania , aik@ozlabs.ru, mdroth@linux.vnet.ibm.com, agraf@suse.de, qemu-ppc@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Nikunj A Dadhania Removes duplicate code and will be useful for consolidating flags Signed-off-by: Nikunj A Dadhania Signed-off-by: David Gibson --- target/ppc/int_helper.c | 34 +++++++++++++--------------------- 1 file changed, 13 insertions(+), 21 deletions(-) diff --git a/target/ppc/int_helper.c b/target/ppc/int_helper.c index dd0a892..da4e1a6 100644 --- a/target/ppc/int_helper.c +++ b/target/ppc/int_helper.c @@ -28,6 +28,15 @@ /*************************************************************************= ****/ /* Fixed point operations helpers */ =20 +static inline void helper_update_ov_legacy(CPUPPCState *env, int ov) +{ + if (unlikely(ov)) { + env->so =3D env->ov =3D 1; + } else { + env->ov =3D 0; + } +} + target_ulong helper_divweu(CPUPPCState *env, target_ulong ra, target_ulong= rb, uint32_t oe) { @@ -49,11 +58,7 @@ target_ulong helper_divweu(CPUPPCState *env, target_ulon= g ra, target_ulong rb, } =20 if (oe) { - if (unlikely(overflow)) { - env->so =3D env->ov =3D 1; - } else { - env->ov =3D 0; - } + helper_update_ov_legacy(env, overflow); } =20 return (target_ulong)rt; @@ -81,11 +86,7 @@ target_ulong helper_divwe(CPUPPCState *env, target_ulong= ra, target_ulong rb, } =20 if (oe) { - if (unlikely(overflow)) { - env->so =3D env->ov =3D 1; - } else { - env->ov =3D 0; - } + helper_update_ov_legacy(env, overflow); } =20 return (target_ulong)rt; @@ -105,11 +106,7 @@ uint64_t helper_divdeu(CPUPPCState *env, uint64_t ra, = uint64_t rb, uint32_t oe) } =20 if (oe) { - if (unlikely(overflow)) { - env->so =3D env->ov =3D 1; - } else { - env->ov =3D 0; - } + helper_update_ov_legacy(env, overflow); } =20 return rt; @@ -127,12 +124,7 @@ uint64_t helper_divde(CPUPPCState *env, uint64_t rau, = uint64_t rbu, uint32_t oe) } =20 if (oe) { - - if (unlikely(overflow)) { - env->so =3D env->ov =3D 1; - } else { - env->ov =3D 0; - } + helper_update_ov_legacy(env, overflow); } =20 return rt; --=20 2.9.3