[Qemu-devel] [PATCH 0/2] Fix stale 'trace-events-all' file in build dir

Daniel P. Berrange posted 2 patches 7 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170228122901.24520-1-berrange@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
Makefile                   | 39 +++++++++++++++++++--------------------
Makefile.target            |  6 +++---
target/s390x/Makefile.objs |  2 +-
tests/Makefile.include     |  2 +-
4 files changed, 24 insertions(+), 25 deletions(-)
[Qemu-devel] [PATCH 0/2] Fix stale 'trace-events-all' file in build dir
Posted by Daniel P. Berrange 7 years ago
If systemtap support was disabled, the trace-events-all file was
only getting regenerated at time of 'make instal'. This is bad
because it leaves stale files in the build dir for developers.

Daniel P. Berrange (2):
  makefile: merge GENERATED_HEADERS & GENERATED_SOURCES variables
  makefile: generate trace-events-all upfront

 Makefile                   | 39 +++++++++++++++++++--------------------
 Makefile.target            |  6 +++---
 target/s390x/Makefile.objs |  2 +-
 tests/Makefile.include     |  2 +-
 4 files changed, 24 insertions(+), 25 deletions(-)

-- 
2.9.3


Re: [Qemu-devel] [PATCH 0/2] Fix stale 'trace-events-all' file in build dir
Posted by Fam Zheng 7 years ago
On Tue, 02/28 12:28, Daniel P. Berrange wrote:
> If systemtap support was disabled, the trace-events-all file was
> only getting regenerated at time of 'make instal'. This is bad
> because it leaves stale files in the build dir for developers.

Apparently 6eab3544f472 wasn't a good job. :-/

For both patches:

Reviewed-by: Fam Zheng <famz@redhat.com>

Re: [Qemu-devel] [PATCH 0/2] Fix stale 'trace-events-all' file in build dir
Posted by Stefan Hajnoczi 7 years ago
On Tue, Feb 28, 2017 at 12:28:59PM +0000, Daniel P. Berrange wrote:
> If systemtap support was disabled, the trace-events-all file was
> only getting regenerated at time of 'make instal'. This is bad
> because it leaves stale files in the build dir for developers.
> 
> Daniel P. Berrange (2):
>   makefile: merge GENERATED_HEADERS & GENERATED_SOURCES variables
>   makefile: generate trace-events-all upfront
> 
>  Makefile                   | 39 +++++++++++++++++++--------------------
>  Makefile.target            |  6 +++---
>  target/s390x/Makefile.objs |  2 +-
>  tests/Makefile.include     |  2 +-
>  4 files changed, 24 insertions(+), 25 deletions(-)
> 
> -- 
> 2.9.3
> 
> 

Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan
Re: [Qemu-devel] [PATCH 0/2] Fix stale 'trace-events-all' file in build dir
Posted by Daniel P. Berrange 7 years ago
On Wed, Mar 01, 2017 at 12:19:34PM +0000, Stefan Hajnoczi wrote:
> On Tue, Feb 28, 2017 at 12:28:59PM +0000, Daniel P. Berrange wrote:
> > If systemtap support was disabled, the trace-events-all file was
> > only getting regenerated at time of 'make instal'. This is bad
> > because it leaves stale files in the build dir for developers.
> > 
> > Daniel P. Berrange (2):
> >   makefile: merge GENERATED_HEADERS & GENERATED_SOURCES variables
> >   makefile: generate trace-events-all upfront
> > 
> >  Makefile                   | 39 +++++++++++++++++++--------------------
> >  Makefile.target            |  6 +++---
> >  target/s390x/Makefile.objs |  2 +-
> >  tests/Makefile.include     |  2 +-
> >  4 files changed, 24 insertions(+), 25 deletions(-)
> > 
> > -- 
> > 2.9.3
> > 
> > 
> 
> Thanks, applied to my tracing tree:
> https://github.com/stefanha/qemu/commits/tracing

Could you apply the two typo fixes eric mentioned on the commit message

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|