From nobody Thu Dec 18 19:32:54 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1487960691613741.8042065935323; Fri, 24 Feb 2017 10:24:51 -0800 (PST) Received: from localhost ([::1]:39168 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1chKXy-0004SC-4n for importer@patchew.org; Fri, 24 Feb 2017 13:24:50 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1chJxV-0006Hp-Sh for qemu-devel@nongnu.org; Fri, 24 Feb 2017 12:47:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1chJxU-0004uP-Ty for qemu-devel@nongnu.org; Fri, 24 Feb 2017 12:47:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38624) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1chJxS-0004sY-NJ; Fri, 24 Feb 2017 12:47:06 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7A6393A7698; Fri, 24 Feb 2017 17:47:05 +0000 (UTC) Received: from localhost (ovpn-116-95.phx2.redhat.com [10.3.116.95]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1OHl4IR001040 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 24 Feb 2017 12:47:05 -0500 From: Jeff Cody To: qemu-block@nongnu.org Date: Fri, 24 Feb 2017 12:46:59 -0500 Message-Id: <20170224174700.30816-3-jcody@redhat.com> In-Reply-To: <20170224174700.30816-1-jcody@redhat.com> References: <20170224174700.30816-1-jcody@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 24 Feb 2017 17:47:05 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 2/3] block/nfs: try to avoid the bounce buffer in pwritev X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, jcody@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Peter Lieven if the passed qiov contains exactly one iov we can pass the buffer directly. Signed-off-by: Peter Lieven Reviewed-by: Jeff Cody Message-id: 1487349541-10201-3-git-send-email-pl@kamp.de Signed-off-by: Jeff Cody --- block/nfs.c | 35 ++++++++++++++++++++++------------- 1 file changed, 22 insertions(+), 13 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index c11c4c9..ffb54be 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -302,30 +302,39 @@ static int coroutine_fn nfs_co_pwritev(BlockDriverSta= te *bs, uint64_t offset, NFSClient *client =3D bs->opaque; NFSRPC task; char *buf =3D NULL; + bool my_buffer =3D false; =20 nfs_co_init_task(bs, &task); =20 - buf =3D g_try_malloc(bytes); - if (bytes && buf =3D=3D NULL) { - return -ENOMEM; + if (iov->niov !=3D 1) { + buf =3D g_try_malloc(bytes); + if (bytes && buf =3D=3D NULL) { + return -ENOMEM; + } + qemu_iovec_to_buf(iov, 0, buf, bytes); + my_buffer =3D true; + } else { + buf =3D iov->iov[0].iov_base; } =20 - qemu_iovec_to_buf(iov, 0, buf, bytes); - if (nfs_pwrite_async(client->context, client->fh, offset, bytes, buf, nfs_co_generic_cb, &task) !=3D 0) { + if (my_buffer) { + g_free(buf); + } + return -ENOMEM; + } + + nfs_set_events(client); + while (!task.complete) { + qemu_coroutine_yield(); + } + + if (my_buffer) { g_free(buf); - return -ENOMEM; } =20 - nfs_set_events(client); - while (!task.complete) { - qemu_coroutine_yield(); - } - - g_free(buf); - if (task.ret !=3D bytes) { return task.ret < 0 ? task.ret : -EIO; } --=20 2.9.3