From nobody Thu Nov 6 20:33:18 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1487747553929400.82509626741626; Tue, 21 Feb 2017 23:12:33 -0800 (PST) Received: from localhost ([::1]:50334 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cgR6F-0007fw-Vy for importer@patchew.org; Wed, 22 Feb 2017 02:12:32 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cgQVI-0003HQ-C4 for qemu-devel@nongnu.org; Wed, 22 Feb 2017 01:34:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cgQVD-0008GC-J3 for qemu-devel@nongnu.org; Wed, 22 Feb 2017 01:34:20 -0500 Received: from ozlabs.org ([103.22.144.67]:56851) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cgQVD-0008DZ-7P; Wed, 22 Feb 2017 01:34:15 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 3vSndM6jBFz9sNH; Wed, 22 Feb 2017 17:33:58 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1487745239; bh=0gtijOfm80Ix/CGyTdi9DPXOivHwgu5CJ4Kus/lawvk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OSCoQUUyPylpzOfN1gHQ8TguvAYeFNwRlTCaOPn1AF++SS9osr9nbanjehJCZSgEW +hLce9hX2eIc8dD4SFvO2kxMQdnRZX5WbK094hW39PG6DX0RXVFiyawsHCU1z1xd3p 9DvejMONNrSgQyDJxsPzBuoecdF5GLLSQNq9ZfBc= From: David Gibson To: peter.maydell@linaro.org Date: Wed, 22 Feb 2017 17:33:46 +1100 Message-Id: <20170222063348.32176-42-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170222063348.32176-1-david@gibson.dropbear.id.au> References: <20170222063348.32176-1-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 103.22.144.67 Subject: [Qemu-devel] [PULL 41/43] target-ppc: fix Book-E TLB matching X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, thuth@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, agraf@suse.de, Alex Zuepke , qemu-ppc@nongnu.org, imammedo@redhat.com, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Alex Zuepke The Book-E TLB matching process should bail out early when a TLB entry matches, but the access permissions are wrong. The CPU will then raise a DSI error instead of a Data TLB error, as described for TLB matching in Freescale and IBM documents. Signed-off-by: Alex Zuepke Signed-off-by: David Gibson --- target/ppc/mmu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c index 172a305..eb2d482 100644 --- a/target/ppc/mmu_helper.c +++ b/target/ppc/mmu_helper.c @@ -825,7 +825,7 @@ static int mmubooke_get_physical_address(CPUPPCState *e= nv, mmu_ctx_t *ctx, tlb =3D &env->tlb.tlbe[i]; ret =3D mmubooke_check_tlb(env, tlb, &raddr, &ctx->prot, address, = rw, access_type, i); - if (!ret) { + if (ret !=3D -1) { break; } } --=20 2.9.3