From nobody Thu Nov 6 20:33:19 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1487747291828517.9459485633928; Tue, 21 Feb 2017 23:08:11 -0800 (PST) Received: from localhost ([::1]:50312 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cgR22-00020X-I5 for importer@patchew.org; Wed, 22 Feb 2017 02:08:10 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cgQVB-00038D-Bi for qemu-devel@nongnu.org; Wed, 22 Feb 2017 01:34:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cgQV8-00089e-H2 for qemu-devel@nongnu.org; Wed, 22 Feb 2017 01:34:13 -0500 Received: from ozlabs.org ([2401:3900:2:1::2]:46427) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cgQV7-00082b-V4; Wed, 22 Feb 2017 01:34:10 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 3vSndL3zG0z9sD9; Wed, 22 Feb 2017 17:33:55 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1487745238; bh=ZReJ/jO18lQgv5O1yWy1z90csCxTzYCh9fDfmo2uTQY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j/RZdJQCp9hdxoVm+C48im/lgnzzwQnqSjE0gS5nF8htQaFB84GolaVc3cvh2PT3x UkOgKzFd8L8foaNtbP7Xt+6jY1SwlMeo8o+0vpbhnD05iDf5JU4Z+O063cNoJ3uurQ JpjyDtKJoMPX5/uWc+GDL90z4eBRZWuTMXMz9yZM= From: David Gibson To: peter.maydell@linaro.org Date: Wed, 22 Feb 2017 17:33:24 +1100 Message-Id: <20170222063348.32176-20-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170222063348.32176-1-david@gibson.dropbear.id.au> References: <20170222063348.32176-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PULL 19/43] mac99: replace debug printf with trace points X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, thuth@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, agraf@suse.de, qemu-ppc@nongnu.org, imammedo@redhat.com, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" From: Laurent Vivier Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: David Gibson --- hw/ppc/mac_newworld.c | 15 +++------------ hw/ppc/trace-events | 4 ++++ 2 files changed, 7 insertions(+), 12 deletions(-) diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c index 716aea6..68aaedc 100644 --- a/hw/ppc/mac_newworld.c +++ b/hw/ppc/mac_newworld.c @@ -72,6 +72,7 @@ #include "exec/address-spaces.h" #include "hw/sysbus.h" #include "qemu/cutils.h" +#include "trace.h" =20 #define MAX_IDE_BUS 2 #define CFG_ADDR 0xf0000510 @@ -79,21 +80,11 @@ #define CLOCKFREQ (266UL * 1000UL * 1000UL) #define BUSFREQ (100UL * 1000UL * 1000UL) =20 -/* debug UniNorth */ -//#define DEBUG_UNIN - -#ifdef DEBUG_UNIN -#define UNIN_DPRINTF(fmt, ...) \ - do { printf("UNIN: " fmt , ## __VA_ARGS__); } while (0) -#else -#define UNIN_DPRINTF(fmt, ...) -#endif - /* UniN device */ static void unin_write(void *opaque, hwaddr addr, uint64_t value, unsigned size) { - UNIN_DPRINTF("write addr " TARGET_FMT_plx " val %"PRIx64"\n", addr, va= lue); + trace_mac99_uninorth_write(addr, value); if (addr =3D=3D 0x0) { *(int*)opaque =3D value; } @@ -109,7 +100,7 @@ static uint64_t unin_read(void *opaque, hwaddr addr, un= signed size) value =3D *(int*)opaque; } =20 - UNIN_DPRINTF("readl addr " TARGET_FMT_plx " val %x\n", addr, value); + trace_mac99_uninorth_read(addr, value); =20 return value; } diff --git a/hw/ppc/trace-events b/hw/ppc/trace-events index f46995c..6122a12 100644 --- a/hw/ppc/trace-events +++ b/hw/ppc/trace-events @@ -85,3 +85,7 @@ rs6000mc_presence_read(uint32_t addr, uint32_t val) "read= addr=3D%x val=3D%x" rs6000mc_size_read(uint32_t addr, uint32_t val) "read addr=3D%x val=3D%x" rs6000mc_size_write(uint32_t addr, uint32_t val) "write addr=3D%x val=3D%x" rs6000mc_parity_read(uint32_t addr, uint32_t val) "read addr=3D%x val=3D%x" + +# hw/ppc/mac_newworld.c +mac99_uninorth_write(uint64_t addr, uint64_t value) "addr=3D0x%" PRIx64 " = val=3D0x%"PRIx64 +mac99_uninorth_read(uint64_t addr, uint64_t value) "addr=3D0x%" PRIx64 " v= al=3D0x%"PRIx64 --=20 2.9.3