From nobody Thu Nov 6 20:32:04 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1487745870964691.6853144172139; Tue, 21 Feb 2017 22:44:30 -0800 (PST) Received: from localhost ([::1]:50166 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cgQf7-0004nP-N2 for importer@patchew.org; Wed, 22 Feb 2017 01:44:29 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cgQV2-0002xR-Nq for qemu-devel@nongnu.org; Wed, 22 Feb 2017 01:34:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cgQV0-0007wf-QG for qemu-devel@nongnu.org; Wed, 22 Feb 2017 01:34:04 -0500 Received: from ozlabs.org ([2401:3900:2:1::2]:50863) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cgQV0-0007qS-CK; Wed, 22 Feb 2017 01:34:02 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 3vSndH1qlVz9s8B; Wed, 22 Feb 2017 17:33:54 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1487745235; bh=2z5c1+u2hmnKuX6rrcq+9RpXHyk+D92mKcJyT3qK6oM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pY2DZ5utq1Ce0pRJBDzAhid3CQGvJitWuis9tV4Il4oScHNEn1RJ4KklMFwgdEU5S vUF6wR4btUP4bNJbD+E7fqbOE0C6dAt/ygWVOeq3mCA2SxpFayvoRiWD3DcsOLOjDM GQQEULN35VqNSW8XZyTQsfdEm8PycjSDHhToh55Q= From: David Gibson To: peter.maydell@linaro.org Date: Wed, 22 Feb 2017 17:33:16 +1100 Message-Id: <20170222063348.32176-12-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170222063348.32176-1-david@gibson.dropbear.id.au> References: <20170222063348.32176-1-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PULL 11/43] spapr: fix off-by-one error in spapr_ovec_populate_dt() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, thuth@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, agraf@suse.de, qemu-ppc@nongnu.org, imammedo@redhat.com, Sam Bobroff , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Sam Bobroff The last byte of the option vector was missing due to an off-by-one error. Without this fix, client architecture support negotiation will fail because the last byte of option vector 5, which contains the MMU support, will be missed. Signed-off-by: Sam Bobroff Reviewed-by: Thomas Huth Reviewed-by: Michael Roth Signed-off-by: David Gibson --- hw/ppc/spapr_ovec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr_ovec.c b/hw/ppc/spapr_ovec.c index 3eb1d59..0bcf311 100644 --- a/hw/ppc/spapr_ovec.c +++ b/hw/ppc/spapr_ovec.c @@ -250,5 +250,5 @@ int spapr_ovec_populate_dt(void *fdt, int fdt_offset, } } =20 - return fdt_setprop(fdt, fdt_offset, name, vec, vec_len); + return fdt_setprop(fdt, fdt_offset, name, vec, vec_len + 1); } --=20 2.9.3