[Qemu-devel] [PATCH v4 0/5] SLIRP VMStatification

Dr. David Alan Gilbert (git) posted 5 patches 142 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170220185020.774-1-dgilbert@redhat.com
Test checkpatch failed
Test docker passed
Test s390x passed
slirp/sbuf.h    |   4 +-
slirp/slirp.c   | 449 ++++++++++++++++++++++++++++----------------------------
slirp/socket.h  |  24 ++-
slirp/tcp_var.h |   6 +-
4 files changed, 238 insertions(+), 245 deletions(-)

[Qemu-devel] [PATCH v4 0/5] SLIRP VMStatification

Posted by Dr. David Alan Gilbert (git) 142 weeks ago
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>


Hi,
  This is an update to my previous SLIRP vmstatification, but finally
the dependent patches have gone in, so this can now follow.


Dave

v4
  Fix 'VMStatify socket level' for mingw64 build; it has some different
  choices for the type of IPv4 addresses.

Dr. David Alan Gilbert (5):
  slirp: VMState conversion; tcpcb
  slirp: VMStatify sbuf
  slirp: Common lhost/fhost union
  slirp: VMStatify socket level
  slirp: VMStatify remaining except for loop

 slirp/sbuf.h    |   4 +-
 slirp/slirp.c   | 449 ++++++++++++++++++++++++++++----------------------------
 slirp/socket.h  |  24 ++-
 slirp/tcp_var.h |   6 +-
 4 files changed, 238 insertions(+), 245 deletions(-)

-- 
2.9.3


Re: [Qemu-devel] [PATCH v4 0/5] SLIRP VMStatification

Posted by no-reply@patchew.org 142 weeks ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH v4 0/5] SLIRP VMStatification
Message-id: 20170220185020.774-1-dgilbert@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/1487597638-28323-1-git-send-email-armbru@redhat.com -> patchew/1487597638-28323-1-git-send-email-armbru@redhat.com
 * [new tag]         patchew/20170220185020.774-1-dgilbert@redhat.com -> patchew/20170220185020.774-1-dgilbert@redhat.com
Switched to a new branch 'test'
42ec6e4 slirp: VMStatify remaining except for loop
8278228 slirp: VMStatify socket level
b2cd17c slirp: Common lhost/fhost union
af8192f slirp: VMStatify sbuf
3bb572c slirp: VMState conversion; tcpcb

=== OUTPUT BEGIN ===
Checking PATCH 1/5: slirp: VMState conversion; tcpcb...
ERROR: code indent should never use tabs
#211: FILE: slirp/tcp_var.h:51:
+^Iuint8_t t_force;^I^I/* 1 if forcing out a byte */$

ERROR: code indent should never use tabs
#221: FILE: slirp/tcp_var.h:112:
+^Iuint8_t^It_oobflags;^I^I/* have some */$

ERROR: code indent should never use tabs
#222: FILE: slirp/tcp_var.h:113:
+^Iuint8_t^It_iobc;^I^I^I/* input character */$

total: 3 errors, 0 warnings, 195 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/5: slirp: VMStatify sbuf...
ERROR: code indent should never use tabs
#26: FILE: slirp/sbuf.h:15:
+^Iuint32_t sb_cc;^I^I/* actual chars in buffer */$

ERROR: code indent should never use tabs
#27: FILE: slirp/sbuf.h:16:
+^Iuint32_t sb_datalen;^I/* Length of data  */$

total: 2 errors, 0 warnings, 155 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/5: slirp: Common lhost/fhost union...
Checking PATCH 4/5: slirp: VMStatify socket level...
ERROR: if this code is redundant consider removing it
#96: FILE: slirp/slirp.c:1297:
+#if 0

total: 1 errors, 0 warnings, 217 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/5: slirp: VMStatify remaining except for loop...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org