[Qemu-devel] [PATCH 0/3] qemu-img raw preallocation

Nir Soffer posted 3 patches 7 years, 1 month ago
Failed in applying to current master (apply log)
block/file-posix.c         | 19 ++++++++++++++-
tests/qemu-iotests/175     | 61 ++++++++++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/175.out | 18 ++++++++++++++
tests/qemu-iotests/group   |  1 +
4 files changed, 98 insertions(+), 1 deletion(-)
create mode 100755 tests/qemu-iotests/175
create mode 100644 tests/qemu-iotests/175.out
[Qemu-devel] [PATCH 0/3] qemu-img raw preallocation
Posted by Nir Soffer 7 years, 1 month ago
This series add missing tests for raw image preallocation, refine
preallocation=full and improve documentation.

Create on top of the commit	10ddfe7b6044 (qemu-img: Do not truncate
before preallocation) from Kevin block branch.

Nir Soffer (3):
  qemu-img: Add tests for raw image preallocation
  qemu-img: Truncate before full preallocation
  qemu-img: Improve documentation for PREALLOC_MODE_FALLOC

 block/file-posix.c         | 19 ++++++++++++++-
 tests/qemu-iotests/175     | 61 ++++++++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/175.out | 18 ++++++++++++++
 tests/qemu-iotests/group   |  1 +
 4 files changed, 98 insertions(+), 1 deletion(-)
 create mode 100755 tests/qemu-iotests/175
 create mode 100644 tests/qemu-iotests/175.out

-- 
2.9.3


Re: [Qemu-devel] [PATCH 0/3] qemu-img raw preallocation
Posted by Kevin Wolf 7 years, 1 month ago
Am 17.02.2017 um 01:51 hat Nir Soffer geschrieben:
> This series add missing tests for raw image preallocation, refine
> preallocation=full and improve documentation.
> 
> Create on top of the commit	10ddfe7b6044 (qemu-img: Do not truncate
> before preallocation) from Kevin block branch.

Thanks, applied to the block branch.

I changed the commit message of patch 2 so that it doesn't mention the
commit ID. This is because the commit ID is only stable once the commit
has made it into master. I also added a few words ("...so don't do that
here") to the comment in patch 3 because outside the context of the
patch, talking about a truncation seemed weird when there is no
truncation happening. I hope you're okay with these changes.

Kevin

Re: [Qemu-devel] [PATCH 0/3] qemu-img raw preallocation
Posted by Nir Soffer 7 years, 1 month ago
On Wed, Feb 22, 2017 at 2:31 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> Am 17.02.2017 um 01:51 hat Nir Soffer geschrieben:
>> This series add missing tests for raw image preallocation, refine
>> preallocation=full and improve documentation.
>>
>> Create on top of the commit   10ddfe7b6044 (qemu-img: Do not truncate
>> before preallocation) from Kevin block branch.
>
> Thanks, applied to the block branch.
>
> I changed the commit message of patch 2 so that it doesn't mention the
> commit ID. This is because the commit ID is only stable once the commit
> has made it into master. I also added a few words ("...so don't do that
> here") to the comment in patch 3 because outside the context of the
> patch, talking about a truncation seemed weird when there is no
> truncation happening. I hope you're okay with these changes.

Looks fine, thanks!