From nobody Mon Feb 9 19:37:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@gnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1506731815485494.6611315780266; Fri, 29 Sep 2017 17:36:55 -0700 (PDT) Received: from localhost ([::1]:37563 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dy5lq-0001Xr-NA for importer@patchew.org; Fri, 29 Sep 2017 20:36:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dy5W5-0004jc-Bi for qemu-devel@nongnu.org; Fri, 29 Sep 2017 20:20:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dy5W2-00066Q-41 for qemu-devel@nongnu.org; Fri, 29 Sep 2017 20:20:25 -0400 Received: from mail-by2nam03on0047.outbound.protection.outlook.com ([104.47.42.47]:42982 helo=NAM03-BY2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dy5W1-00064A-Fp for qemu-devel@nongnu.org; Fri, 29 Sep 2017 20:20:21 -0400 Received: from CY4PR02CA0046.namprd02.prod.outlook.com (10.175.57.160) by CY1PR0201MB1932.namprd02.prod.outlook.com (10.163.56.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Sat, 30 Sep 2017 00:20:18 +0000 Received: from SN1NAM02FT033.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e44::201) by CY4PR02CA0046.outlook.office365.com (2603:10b6:903:117::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11 via Frontend Transport; Sat, 30 Sep 2017 00:20:18 +0000 Received: from xsj-pvapsmtpgw01 (149.199.60.83) by SN1NAM02FT033.mail.protection.outlook.com (10.152.72.133) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.56.11 via Frontend Transport; Sat, 30 Sep 2017 00:20:17 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1dy5Vx-00083K-Cy; Fri, 29 Sep 2017 17:20:17 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1dy5Vx-0007Se-8H; Fri, 29 Sep 2017 17:20:17 -0700 Received: from xsj-pvapsmtp01 (xsj-pvapsmtp01.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id v8U0K9SA000955; Fri, 29 Sep 2017 17:20:09 -0700 Received: from [172.19.2.220] (helo=localhost.localdomain) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1dy5Vo-0007Pw-TM; Fri, 29 Sep 2017 17:20:08 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=OjZPkpCwu8QXQiIuoOx7lMdFBcb1jKqD/5uH2f/9mBQ=; b=WeUCKybCrnUpmS5TbEzvPRUHNpFxWYTiJJ6YlC8i4iBdVNH7OtsjFADduasarFUao2RNMlkvbw/nX94pCr7Sc9SiPn02OeXVjQD3+T1+eOt16ajN0hJCvKv1QQVvIfW9llG9XQh6ClZwNMrpIs30DfTv6aWtDIl4y5ZfwKaU1mU= Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@gnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; From: Alistair Francis To: Date: Fri, 29 Sep 2017 17:16:21 -0700 Message-ID: <1ff71065271df7d2b92af3008c7592ba20e2ed0c.1506730372.git.alistair.francis@xilinx.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23358.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(376002)(39860400002)(346002)(2980300002)(438002)(199003)(189002)(36756003)(6666003)(2950100002)(76176999)(305945005)(356003)(6916009)(50986999)(106002)(50466002)(106466001)(8936002)(81156014)(81166006)(8676002)(47776003)(5003940100001)(5660300001)(2351001)(48376002)(50226002)(63266004)(33646002)(118296001)(189998001)(39060400002)(478600001)(77096006)(2906002)(575784001)(316002)(36386004)(54906003)(16586007)(4326008)(9786002)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0201MB1932; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; PTR:unknown-60-83.xilinx.com; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; SN1NAM02FT033; 1:VUCTTfsspsm1eR/JNetY9siwXkv/zfbn1sL6WD+OnQi7coBJEISTCUy0g9JlmjjgwO24UEB0e00BMdnULyys4xAgoMnZJfns9b2n33GPx41Z5uTj8m6TG8YZzQKCV0q2 MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a8bec25d-95fd-4501-af04-08d5079907a3 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(8251501002)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:CY1PR0201MB1932; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0201MB1932; 3:/7TXXZVkZxvyflbV40LbfVCdcY6iVgiycncY8s+7dxJ16yLOJh38X/Pv/l6PplESDgaNTQww0QsCOzJc1lf1Y/A5vH7sQOjNTxWQ4ZYE/cRZyJyjwPav15uHiZJiw9woq+TfsCe+WXsYGn21xmjghz9yiNPBtC/oUkFeIBSGai46Bl/YGXbVnFWoykRkinSUufDi0N6giesvmdHi9pLiG2Zx43wm/fa9qL3nbNpZDZUW/l44TVZL4osF1s7hAIHk+sUa/9xSnGUPILopAQgvEW9xfX1/uIBHW7jujaqWFPJZ6zPCmej1A+RoV4iCzdP1WVCeDkTnUsaLfCeodPBVUfU74jJITGe0ZS/NpvEm/a0=; 25:txWZ8+NAzKVvhI/y/k773xwBhM2u5wQqprHrjUMXrom9EQLFVL6cMl4HEYKmfGi27rcKyM4h/eUWH3NSvZqn8bmWdNkBBKEAulRNwqS7aPg7iQ25ToUp2MxIxnloXaLbSDIZHLzyXznF6D4V8CqxkcTFDTmZUHRZaTzglvlj2YzffInYwjEvcOgcRn683fr4TJIZDULgTPG9j++YQ5UrnakmR1pPGBHdtFG7taQMYzT2SW9f4bk4GBMUV3pZGCtnzzVuTn1o4foLPUYP+BVz8Q6gLZEvFigwW1zsN7Ni5VCu2jD6IlmOZNi5Ut8sz6iefOQ/OdGfzxJ7uiIItKA5YA== X-MS-TrafficTypeDiagnostic: CY1PR0201MB1932: X-Microsoft-Exchange-Diagnostics: 1; CY1PR0201MB1932; 31:q6cXO5vzwJBEsXgJxRSexccCxSzDc66exRbspkrxCDCoVwBaMd2xu426FCqYRMS6AMIQ328iTuLMkqw7CZohwXI6S9FwtpULsAYZ2T/WWYclFbkafyl0UdconHjPquu/E+hGQifxqkvNdW6qtCLgY88jsHXEy7dDP7yMATMUI+/nbntPdZVm+hHG+ZlBuP2JCMwvw99RN9h0l1ZFKV/biUTjzAKUTjaH60qfKVxHK3k=; 20:EEkgKNCGb6bjtqxQdWl8PpjxkA4UY4OxwT1wQTT05HdfYJi18+3NJ+rv9dpL1ZpPlrSF/TO9yKXma1SdswtKKR8KwOv4qJ4jjzREuI+W5vE+sDYOsjcTTU4LCE0f4JbWAqrt9rxrco5rVwAgY8vswIfg99v3vDbr+B1FqY5hxhnJ3wTrIbT6tqiwzeH8I2AGQnGpxbb94JJH6ZEi5gpCyRSUT9WJaBUL+4mVGsdl2dGVDWAXVnXGIjQ6feDBvMXZowqd17NS5/RFaCXJjambl/Hrc9InfP2S4q3CRQS3McP2XYSF0abcQ2v1r66Rp8Ia7EgOpYELji/dmuZwavbGTUR/JVCtDx276DpkMHG79M9GOY0mMaEIRSdPp/fNbJTyRjkAlU9AlH0bpV2rF8Cm547IkAXtYdusI75afFhx+usQo7Hprf3vOGRo2K6nuyH0zdB0GtzuGi7wX2Abs1rhqIXkHgJb3V8eVbO4jjg0O+ouovvy8aj16DSKBYeWA/uW X-Exchange-Antispam-Report-Test: UriScan:(788757137089)(192813158149592); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(93006095)(93004095)(3002001)(6055026)(6041248)(20161123562025)(20161123560025)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR0201MB1932; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR0201MB1932; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0201MB1932; 4:9mvOtl96buiiyXm6SLs3Ssir+d69kUJ205G1N0UKkTffI4x7Gmi9eEUGfhutMo+97CVwxdnhvKi9MXlW/4uC0evwUz0UwfNzqTwm7HsQeD70sJEbMiTEA1NoDPE6Rcv9FlA6mM9nZ7aULt81cnzTl11E2seHLhS0mnYMk9LLYYxt63E9x96BfBQVUaPYK7dVO+0LGhdzlXuWQpkjHK11fouwjwomN+a54YKGt4UB2G3hgJ2jbSiKYSF32pTuS5Fui1dxwkBXrlqxM1LXtg5gZ9jurKeNHuJlOex87aTsUX4AFDap88ZqyTa0GsL4wfkV5i1DyC45Wvh/7DGQkZ8q2Q== X-Forefront-PRVS: 0446F0FCE1 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0201MB1932; 23:I1OE+9SmqKSttkrh4pMx282kFxeEFmm6a7XX9t9?= =?us-ascii?Q?C6UaaY7NDVWK5Yft4CvTU25N+8G3Qgj9I1NDiHSESqUzMwWmMw7qiuAnktGh?= =?us-ascii?Q?/7W1f6lcTqP0+dWkSt4cBp83S9jAEEZaNxeHN5tBHGB55QW2cC/hJewdZNcX?= =?us-ascii?Q?AmlpqBk0q94DZkrVFzW8wi5/z9rfdL6Rx6Yui8e5W08R5u8nOIg0q6uH9gi/?= =?us-ascii?Q?KObW7DhUGdT6YqIFWTb87VvCrDX2JlgHaqJnoSzFnARbmiKAS0pHBqr50d31?= =?us-ascii?Q?wper2Fa/rPF4ADh8mO57JFS1Lvm1/iDRS5S6DbixtIjHzSQAotGIT8PlmJCC?= =?us-ascii?Q?9nhP4vKzFka4ZsjCRpplNVY7SDk0EAfJ3KWKxWTeW7pIwv8nNSe6GVTNnVbD?= =?us-ascii?Q?dt2UWZ0o8iVG4weiztxVs7q83vGs9wxn3R6KFIQM2ptEy82dW45P2dIRdHeV?= =?us-ascii?Q?VzDCm4+qEYmiHsP1eYIrqWAQbhTGEqHJsI3Z6zNOCdE1nET9cnZbZz/oUFjX?= =?us-ascii?Q?hiqGssu5NUgK7Vpn7HpIwfDB2+tBJriL+GizaflSUDoJzsfbzP9vQRJcnsuF?= =?us-ascii?Q?hefnhEuPaAgK9kiaLXIOwABd18ZCiTzCB53G8Ze+24E2YWZp5yl4h5x0zJD6?= =?us-ascii?Q?818KFA0VGB+x+vjrU0FC+8QJRK/bewZBhATo1lRssI4WQjL4aXEr222HCVA2?= =?us-ascii?Q?MYrqnC1L1JO7Ajzjvqf3kfthuDht8CnQhva0lla2kiuBfj9HnqfRJubc7NVg?= =?us-ascii?Q?0sp6ahzVm81p44SySmlMvtjY4v139rD/bUttKsCpKiR/uuNrG+9Jw/pmg18i?= =?us-ascii?Q?R6Xh5jGZ5+EvwH5XN2IoJB4eUnisgbv+7erb9maRQY+41+PrM45TVC+mQFHV?= =?us-ascii?Q?4d3QO/LAviYi1xOzDHvzkRNSQlXN5zfPxDMoHOwSosq6qeJUdXg+nyXmVA7j?= =?us-ascii?Q?tLCpBcRj+f51DA/IPYcTKuy9YCfuD0V8hfahPGr8skEEGCPhkVJ9jwQzK07k?= =?us-ascii?Q?aXPiDovYQ9YKoWlPGio5mjrhnJgEoEIzdirmsTO8Xwg+HyuLUKbzu0seD5bh?= =?us-ascii?Q?VxqRByB8hCi9xYa6e2Ulpz+UL1EZr?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0201MB1932; 6:YRMCakiGlk56syGl8o+HH7FAA7m1MWNSkb2T6E8oiZn1dR5H8xBvt1dh6y91p3z/QWUndCqWBo7b8zcB0vkttatzh8W89C36QxesM+d8tCzJmUlJ291AFtFKB3SkMMpZ+5vTgwvsgk/JCfH/ewiwWudDF8v6g9AbNock14imQFjgo5uK1+uKhBzjZnr2gujQnWtzMlBrUleBBAmaH3+0BoCQA9NF7FeYRG3cioUrzCDFx5LnCLQc7r0bO+xvpwvXSGb/+01qVM+gKrUkGNJc8bTfXOOyzcn+UiEd0KCGfWFmaGufn0WFCTqSrbz3UytvgLo+Y3iCV8BgMPvBG9cqqQ==; 5:/wTrDoKUy2IpFMMPe2algjcy7dsRRyLRBqF4nNv9vnjmc2z6503oNo+g6ctL6/Nl81ENDSukffw07uamNnYJ8ntVB5jA1S8L12AXsMMZDpqyw2+KayBLaJ9ntyLtrwYyekZH9YkruDtjUfeiZ3cg0Fj9xlsqcWt1ArDwdDQUeLQ=; 24:ZaRwBCQFZa6usAW1j/iout16lvUvo/YnXBSinATPR8cdDmdkEjfqHwCbBtGE0LYMOEkNd3iTr8C5WqyB6PGCG/voEbjUDwAtEWMZr44xuFg=; 7:Vvxc1DbzRvSM/uDOPgMpGds7/mBjNFfeksYlXB9QD9XOiKVYFTkSr09yFnDUBk7ty4R4uCGa6ZbpE8tK15Z6QTL0SLS1OkTJQWoCgLAwxXlQ4KCHr6j8RH+lf1kVy2lNLaGw8PB0fHrQFaOUc/nwdQBgpP8C1zbX+gOIbDrrL7+Tz7XmHeDPq5ZTRIZngUHqqZ0XAzn8RGpVGnWTzn1neh9KMiuEly5g7lQjlopiqkI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2017 00:20:17.9382 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0201MB1932 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.42.47 Subject: [Qemu-devel] [PATCH v2 27/47] hw/net: Replace fprintf(stderr, "*\n" with error_report() X-BeenThere: qemu-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , Jason Wang , Alexander Graf , armbru@redhat.com, alistair23@gmail.com, alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@gnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_6 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_= report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_re= port("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report= ("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("= \1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1= "\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\= 2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2)= ;|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|= Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig= }' \ {} + find ./* -type f -exec sed -i \ 'N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}'= \ {} + find ./* -type f -exec sed -i \ 'N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + Some lines where then manually tweaked to pass checkpatch. Signed-off-by: Alistair Francis Cc: Alexander Graf Cc: Jason Wang Cc: "Michael S. Tsirkin" Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- V2: - Split hw patch into individual directories hw/net/fsl_etsec/etsec.c | 2 +- hw/net/pcnet.c | 2 +- hw/net/smc91c111.c | 5 +++-- hw/net/vhost_net.c | 16 ++++++++-------- 4 files changed, 13 insertions(+), 12 deletions(-) diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c index 9da1932970..965effa314 100644 --- a/hw/net/fsl_etsec/etsec.c +++ b/hw/net/fsl_etsec/etsec.c @@ -347,7 +347,7 @@ static ssize_t etsec_receive(NetClientState *nc, eTSEC *etsec =3D qemu_get_nic_opaque(nc); =20 #if defined(HEX_DUMP) - fprintf(stderr, "%s receive size:%zd\n", nc->name, size); + error_report("%s receive size:%zd", nc->name, size); qemu_hexdump((void *)buf, stderr, "", size); #endif /* Flush is unnecessary as are already in receiving path */ diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c index 654455355f..5f2b5fe046 100644 --- a/hw/net/pcnet.c +++ b/hw/net/pcnet.c @@ -1070,7 +1070,7 @@ ssize_t pcnet_receive(NetClientState *nc, const uint8= _t *buf, size_t size_) if (!s->looptest) { if (size > 4092) { #ifdef PCNET_DEBUG_RMD - fprintf(stderr, "pcnet: truncates rx packet.\n"); + error_report("pcnet: truncates rx packet."); #endif size =3D 4092; } diff --git a/hw/net/smc91c111.c b/hw/net/smc91c111.c index 3b16dcf5a1..ae40fd6e6e 100644 --- a/hw/net/smc91c111.c +++ b/hw/net/smc91c111.c @@ -8,6 +8,7 @@ */ =20 #include "qemu/osdep.h" +#include "qemu/error-report.h" #include "hw/sysbus.h" #include "net/net.h" #include "hw/devices.h" @@ -362,9 +363,9 @@ static void smc91c111_writeb(void *opaque, hwaddr offse= t, return; case 12: /* Control */ if (value & 1) - fprintf(stderr, "smc91c111:EEPROM store not implemented\n"= ); + error_report("smc91c111:EEPROM store not implemented"); if (value & 2) - fprintf(stderr, "smc91c111:EEPROM reload not implemented\n= "); + error_report("smc91c111:EEPROM reload not implemented"); value &=3D ~3; SET_LOW(ctr, value); return; diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c index e037db63a3..37d0cce560 100644 --- a/hw/net/vhost_net.c +++ b/hw/net/vhost_net.c @@ -135,7 +135,7 @@ static int vhost_net_get_fd(NetClientState *backend) case NET_CLIENT_DRIVER_TAP: return tap_get_fd(backend); default: - fprintf(stderr, "vhost-net requires tap backend\n"); + error_report("vhost-net requires tap backend"); return -EBADFD; } } @@ -148,7 +148,7 @@ struct vhost_net *vhost_net_init(VhostNetOptions *optio= ns) uint64_t features =3D 0; =20 if (!options->net_backend) { - fprintf(stderr, "vhost-net requires net backend to be setup\n"); + error_report("vhost-net requires net backend to be setup"); goto fail; } net->nc =3D options->net_backend; @@ -186,8 +186,8 @@ struct vhost_net *vhost_net_init(VhostNetOptions *optio= ns) net->dev.features &=3D ~(1ULL << VIRTIO_NET_F_MRG_RXBUF); } if (~net->dev.features & net->dev.backend_features) { - fprintf(stderr, "vhost lacks feature mask %" PRIu64 - " for backend\n", + error_report("vhost lacks feature mask %" PRIu64 + " for backend", (uint64_t)(~net->dev.features & net->dev.backend_featur= es)); goto fail; } @@ -197,8 +197,8 @@ struct vhost_net *vhost_net_init(VhostNetOptions *optio= ns) if (net->nc->info->type =3D=3D NET_CLIENT_DRIVER_VHOST_USER) { features =3D vhost_user_get_acked_features(net->nc); if (~net->dev.features & features) { - fprintf(stderr, "vhost lacks feature mask %" PRIu64 - " for backend\n", + error_report("vhost lacks feature mask %" PRIu64 + " for backend", (uint64_t)(~net->dev.features & features)); goto fail; } @@ -349,7 +349,7 @@ err_start: } e =3D k->set_guest_notifiers(qbus->parent, total_queues * 2, false); if (e < 0) { - fprintf(stderr, "vhost guest notifier cleanup failed: %d\n", e); + error_report("vhost guest notifier cleanup failed: %d", e); fflush(stderr); } err: @@ -370,7 +370,7 @@ void vhost_net_stop(VirtIODevice *dev, NetClientState *= ncs, =20 r =3D k->set_guest_notifiers(qbus->parent, total_queues * 2, false); if (r < 0) { - fprintf(stderr, "vhost guest notifier cleanup failed: %d\n", r); + error_report("vhost guest notifier cleanup failed: %d", r); fflush(stderr); } assert(r >=3D 0); --=20 2.11.0