From nobody Mon Feb 9 04:09:22 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=eik.bme.hu Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1635451458446234.66976161204195; Thu, 28 Oct 2021 13:04:18 -0700 (PDT) Received: from localhost ([::1]:50674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mgBdJ-0003ud-ET for importer@patchew.org; Thu, 28 Oct 2021 16:04:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49074) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgBWU-0003aS-5h for qemu-devel@nongnu.org; Thu, 28 Oct 2021 15:57:14 -0400 Received: from zero.eik.bme.hu ([152.66.115.2]:64456) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgBWQ-0008TH-7x for qemu-devel@nongnu.org; Thu, 28 Oct 2021 15:57:13 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id BFE4C7561D5; Thu, 28 Oct 2021 21:57:05 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 53746756036; Thu, 28 Oct 2021 21:57:05 +0200 (CEST) Message-Id: <1ecc1748443a161ecb988aab6b89c68e5ae631ff.1635449225.git.balaton@eik.bme.hu> In-Reply-To: References: From: BALATON Zoltan Subject: [PATCH v4 02/23] hw/char/sh_serial: Use hw_error instead of fprintf and abort Date: Thu, 28 Oct 2021 21:27:05 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: qemu-devel@nongnu.org X-Spam-Probability: 8% Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=152.66.115.2; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Richard Henderson , Magnus Damm , Yoshinori Sato Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZM-MESSAGEID: 1635451460249100005 Content-Type: text/plain; charset="utf-8" It does the same with dumping some more state but avoids calling abort directly and printing to stderr from the device model. Signed-off-by: BALATON Zoltan --- hw/char/sh_serial.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/char/sh_serial.c b/hw/char/sh_serial.c index 1b1e6a6a04..dbefb51d71 100644 --- a/hw/char/sh_serial.c +++ b/hw/char/sh_serial.c @@ -26,6 +26,7 @@ */ =20 #include "qemu/osdep.h" +#include "hw/hw.h" #include "hw/irq.h" #include "hw/sh4/sh.h" #include "chardev/char-fe.h" @@ -200,9 +201,7 @@ static void sh_serial_write(void *opaque, hwaddr offs, } } =20 - fprintf(stderr, "sh_serial: unsupported write to 0x%02" - HWADDR_PRIx "\n", offs); - abort(); + hw_error("sh_serial: unsupported write to 0x%02"HWADDR_PRIx"\n", offs); } =20 static uint64_t sh_serial_read(void *opaque, hwaddr offs, @@ -307,9 +306,7 @@ static uint64_t sh_serial_read(void *opaque, hwaddr off= s, #endif =20 if (ret & ~((1 << 16) - 1)) { - fprintf(stderr, "sh_serial: unsupported read from 0x%02" - HWADDR_PRIx "\n", offs); - abort(); + hw_error("sh_serial: unsupported read from 0x%02"HWADDR_PRIx"\n", = offs); } =20 return ret; --=20 2.21.4