From nobody Sun Feb 23 11:25:04 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1740146534; cv=none; d=zohomail.com; s=zohoarc; b=mOMuCREJm8SnUVfOOu/qzw6MVvsgSPgVx3vROLWfCjrRZN8ziaNSLT7IZCAdvY1LEhq/y73gWJ3P1a9FOUptXF8fBHj5IdTw+HhDrToi7pL+kbueATfQ6FnSq1Ha83W7CiqVGZ1aS4T0RrOcyhAxbE10tif1WqfeknV+mWqQD8M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1740146534; h=Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0JG/k2FedV3leSTYvugMKLbdpsUtL8gN3PYO9+FffHw=; b=blxd/Z4o1atkYbmgXm0MN/R1tw3XSxtaS6QDqVDhH8PRJ49EvMsCsk9A+VUtzEwXPz8Pw6JUAi+u1ziQWi9cJilSMtt19qxF4y+FqSEj9TClxyPXsmfX+zDB/cmD0mbzuycY2x8QeA3+G5gUs4D/0trlNumQ5EEZwxbovC6pfV4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1740146534505222.89274750078096; Fri, 21 Feb 2025 06:02:14 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tlTbD-0008CR-PI; Fri, 21 Feb 2025 09:01:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tlOWi-0006RI-Gn for qemu-devel@nongnu.org; Fri, 21 Feb 2025 03:36:55 -0500 Received: from linux.microsoft.com ([13.77.154.182]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tlOWf-00015v-RG for qemu-devel@nongnu.org; Fri, 21 Feb 2025 03:36:52 -0500 Received: by linux.microsoft.com (Postfix, from userid 1031) id A2E50204E5BB; Fri, 21 Feb 2025 00:36:29 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A2E50204E5BB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1740126989; bh=0JG/k2FedV3leSTYvugMKLbdpsUtL8gN3PYO9+FffHw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JWyJh10qkgA5ntWxsAZ1i9rMlmtoReT+RNQAoPkuVZvTxA6NoQA4xQBzgVHeBHzTr 4YWRjlYv5/5YlJ4xPGHHuNK+/VjXNPC8QDLHcWD2DaeqHWCilqXisp8Ei3yFUyqFiJ Y+oIecH0QvRP1V92g+eTVedrlvOFIhDwIE60cKZM= From: Wei Liu To: qemu-devel@nongnu.org Cc: wei.liu@kernel.org, dirty@apple.com, rbolshakov@ddn.com, phil@philjordan.eu, jinankjain@linux.microsoft.com, liuwe@microsoft.com, muislam@microsoft.com, ziqiaozhou@microsoft.com, mukeshrathor@microsoft.com, magnuskulke@microsoft.com, prapal@microsoft.com, jpiotrowski@microsoft.com, deviv@microsoft.com, Wei Liu Subject: [RFC PATCH v1 08/19] target/i386: rename hvf_mmio_buf to mmio_buf Date: Fri, 21 Feb 2025 00:36:16 -0800 Message-Id: <1740126987-8483-9-git-send-email-liuwe@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1740126987-8483-1-git-send-email-liuwe@linux.microsoft.com> References: <1740126987-8483-1-git-send-email-liuwe@linux.microsoft.com> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=13.77.154.182; envelope-from=liuwe@linux.microsoft.com; helo=linux.microsoft.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 21 Feb 2025 09:01:10 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linux.microsoft.com) X-ZM-MESSAGEID: 1740146536288019000 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" We want to refactor HVF's instruction emulator to a common component. Renam= ing hvf_mmio_buf removes the association between HVF and the instruction emulat= or. The definition of the field is still guarded by CONFIG_HVF for now, since i= t is the only user. No functional change. Signed-off-by: Wei Liu --- target/i386/cpu.h | 2 +- target/i386/hvf/hvf.c | 4 ++-- target/i386/hvf/x86_emu.c | 12 ++++++------ 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index c67b42d34f..bfdb1f87a3 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -2070,7 +2070,7 @@ typedef struct CPUArchState { #endif #if defined(CONFIG_HVF) HVFX86LazyFlags hvf_lflags; - void *hvf_mmio_buf; + void *mmio_buf; #endif =20 uint64_t mcg_cap; diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index 64e4154cdf..533b05577d 100644 --- a/target/i386/hvf/hvf.c +++ b/target/i386/hvf/hvf.c @@ -168,7 +168,7 @@ void hvf_arch_vcpu_destroy(CPUState *cpu) X86CPU *x86_cpu =3D X86_CPU(cpu); CPUX86State *env =3D &x86_cpu->env; =20 - g_free(env->hvf_mmio_buf); + g_free(env->mmio_buf); } =20 static void init_tsc_freq(CPUX86State *env) @@ -262,7 +262,7 @@ int hvf_arch_init_vcpu(CPUState *cpu) if (hvf_state->hvf_caps =3D=3D NULL) { hvf_state->hvf_caps =3D g_new0(struct hvf_vcpu_caps, 1); } - env->hvf_mmio_buf =3D g_new(char, 4096); + env->mmio_buf =3D g_new(char, 4096); =20 if (x86cpu->vmware_cpuid_freq) { init_tsc_freq(env); diff --git a/target/i386/hvf/x86_emu.c b/target/i386/hvf/x86_emu.c index 25912e82ca..d0a8e221ea 100644 --- a/target/i386/hvf/x86_emu.c +++ b/target/i386/hvf/x86_emu.c @@ -183,8 +183,8 @@ void write_val_ext(CPUX86State *env, target_ulong ptr, = target_ulong val, int siz =20 uint8_t *read_mmio(CPUX86State *env, target_ulong ptr, int bytes) { - vmx_read_mem(env_cpu(env), env->hvf_mmio_buf, ptr, bytes); - return env->hvf_mmio_buf; + vmx_read_mem(env_cpu(env), env->mmio_buf, ptr, bytes); + return env->mmio_buf; } =20 =20 @@ -486,9 +486,9 @@ static void exec_ins_single(CPUX86State *env, struct x8= 6_decode *decode) target_ulong addr =3D linear_addr_size(env_cpu(env), RDI(env), decode->addressing_size, R_ES); =20 - emul_ops->handle_io(env_cpu(env), DX(env), env->hvf_mmio_buf, 0, + emul_ops->handle_io(env_cpu(env), DX(env), env->mmio_buf, 0, decode->operand_size, 1); - vmx_write_mem(env_cpu(env), addr, env->hvf_mmio_buf, + vmx_write_mem(env_cpu(env), addr, env->mmio_buf, decode->operand_size); =20 string_increment_reg(env, R_EDI, decode); @@ -509,9 +509,9 @@ static void exec_outs_single(CPUX86State *env, struct x= 86_decode *decode) { target_ulong addr =3D decode_linear_addr(env, decode, RSI(env), R_DS); =20 - vmx_read_mem(env_cpu(env), env->hvf_mmio_buf, addr, + vmx_read_mem(env_cpu(env), env->mmio_buf, addr, decode->operand_size); - emul_ops->handle_io(env_cpu(env), DX(env), env->hvf_mmio_buf, 1, + emul_ops->handle_io(env_cpu(env), DX(env), env->mmio_buf, 1, decode->operand_size, 1); =20 string_increment_reg(env, R_ESI, decode); --=20 2.39.5 (Apple Git-154)