From nobody Sat May 4 12:55:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=163.com ARC-Seal: i=1; a=rsa-sha256; t=1660033819; cv=none; d=zohomail.com; s=zohoarc; b=gI7fc51eK+PVLCEEaa0blzpTf2FgzCHhp/0W/ouW5mGwd6fZMqgSLG3lgSDnt6KN/7+8+1skm4mjutAXKYIEdvUpYfEoHBftp4qHBtUfAQnxvZtneM/uIThI+VlYrpI47tQK7TuQ47zVYNR3XIwkVX7fQsJMV00XzmOYdMEvnlM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660033819; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=aiWJNppejmRxkx7z7+NlbLQXBKQrgl/xKt710qX+mZI=; b=gMNaerk9dzLt3tZP+qmni5OS04a9LiWhbIHX4OJGco7FM5iINVZPEuI3lcddB06pId2k8Sv1s1YCe8lJO2OwmMoWJYSgGaoi9GJmyG8gvIsDpuPqOs49hF3LbO7mxS7ML/q3mBp/6MSK/7IoXW1Ig/JzrPVnmIhMMKV7rJWTmRE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 166003381979879.55644963414909; Tue, 9 Aug 2022 01:30:19 -0700 (PDT) Received: from localhost ([::1]:43324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLKd0-0001Nc-90 for importer@patchew.org; Tue, 09 Aug 2022 04:30:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLDIs-00033T-5h for qemu-devel@nongnu.org; Mon, 08 Aug 2022 20:41:02 -0400 Received: from mail-m973.mail.163.com ([123.126.97.3]:42285) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLDIl-0000w9-8X for qemu-devel@nongnu.org; Mon, 08 Aug 2022 20:41:00 -0400 Received: from ubuntu.localdomain (unknown [220.202.227.199]) by smtp3 (Coremail) with SMTP id G9xpCgDnpJxoqfFiFyNXUg--.41503S3; Tue, 09 Aug 2022 08:25:15 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=aiWJNppejmRxkx7z7+ NlbLQXBKQrgl/xKt710qX+mZI=; b=bIYvDlfE5yHiH1YHhdSGZ92p4QwjFIKL+V M2ZfV6KYcpUkQdvxwnIJlY5nuLQxGYEYuPa2MacLkSeSN7GFTpW7ud3jdHXcLpA/ oCxO1s4cugtgo8XKHXWgP5vsaGabCQ1WaUSur5e5Qt73cbeFQsIDh/Cd0Sb4ud2u QEMzQZx78= From: Lei Xiang To: mst@redhat.com Cc: qemu-devel@nongnu.org, xieming@kylinos.cn, Lei Xiang , Lei Xiang Subject: [PATCH] virtio-pci: fix vector_irqfd leak in virtio_pci_set_guest_notifiers Date: Mon, 8 Aug 2022 17:25:09 -0700 Message-Id: <1660004709-61572-1-git-send-email-ninollx@163.com> X-Mailer: git-send-email 1.9.1 X-CM-TRANSID: G9xpCgDnpJxoqfFiFyNXUg--.41503S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrtr45XF1UXrW3Jw1fur1rJFb_yoWxtrbEgr 1Y9rWfWryUXF1qkrZ7Cwn3Xr1I9a4rWFs8WrZxtr18Aw4UAa4UAry7XrnI93W7Wr4xGFW3 Zw4rGrn0vwnIkjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU804iUUUUUU== X-Originating-IP: [220.202.227.199] X-CM-SenderInfo: pqlq0zlo06il2tof0z/1tbivgtYzFZceVK+GwAAsl Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=123.126.97.3; envelope-from=ninollx@163.com; helo=mail-m973.mail.163.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 09 Aug 2022 04:25:03 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @163.com) X-ZM-MESSAGEID: 1660033821120100001 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Lei Xiang proxy->vector_irqfd did not free when set guest notifier failed. Signed-off-by: Lei Xiang Tested-by: Zeng Chi Suggested-by: Xie Ming --- hw/virtio/virtio-pci.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 45327f0..75188a9 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -1058,6 +1058,10 @@ assign_error: while (--n >=3D 0) { virtio_pci_set_guest_notifier(d, n, !assign, with_irqfd); } + + g_free(proxy->vector_irqfd); + proxy->vector_irqfd =3D NULL; + return r; } =20 --=20 1.9.1