From nobody Mon Feb 9 22:04:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=oracle.com ARC-Seal: i=1; a=rsa-sha256; t=1655305445; cv=none; d=zohomail.com; s=zohoarc; b=LDd48zqEeH8bW+fWZVmSfw3A7VyN5y1t5cVkSfVJze0tGoXGvWAMGAjGr/+V12Wgoewo5pLy0JPMFNnSvvg0o2jq1OwIKP9LdlHq12SB9FZsc/VoMaJFVNAR06HS76hpKVEnc3JduobMN/R+UNf4DQZ2GyATLx/3stVzRU9v4zc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655305445; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=w8JE+eHobR41mMBRVUuuslpIICZ/Us2u5XSkZV3wT04=; b=c9l/35GMiZdPAgA/J0IvEfLjZZq4/vdK4LtMOjie1d8Gx3+Dx1rc2a9+vBfHnWuA3FIGKFUyWHObuQ8MD9lU3paXQ9zN2xdTgkBFNg2peTbAi8JfcVoXfGaLJV55fj56V2wDsroJKyGvFdllHq+Yj4zdKhOnqAX9sNBbbzEEJCc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1655305445722280.2887169096947; Wed, 15 Jun 2022 08:04:05 -0700 (PDT) Received: from localhost ([::1]:57256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o1UYu-0003ij-MA for importer@patchew.org; Wed, 15 Jun 2022 11:04:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47330) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1UOA-0006Hh-Kw for qemu-devel@nongnu.org; Wed, 15 Jun 2022 10:52:58 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:13080) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1UO8-00010s-Jt for qemu-devel@nongnu.org; Wed, 15 Jun 2022 10:52:58 -0400 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25FE7fd5002108; Wed, 15 Jun 2022 14:52:41 GMT Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3gmhfcrshj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Jun 2022 14:52:41 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 25FEQ7UQ023115; Wed, 15 Jun 2022 14:52:40 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3gpr25vpm4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Jun 2022 14:52:40 +0000 Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 25FEqSN1018501; Wed, 15 Jun 2022 14:52:39 GMT Received: from ca-dev63.us.oracle.com (ca-dev63.us.oracle.com [10.211.8.221]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3gpr25vpfm-10; Wed, 15 Jun 2022 14:52:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=corp-2021-07-09; bh=w8JE+eHobR41mMBRVUuuslpIICZ/Us2u5XSkZV3wT04=; b=aGAEa7/9McvA1PjJ8uHLfKreVtC8J0OVMwpBFXZiadjgT6VpH1usZLIfHKxfvz05GBFD imF0nlIN5ATGJhroGp1pzap4oHAtJYqQCHCgQAzmYVWZ5uHeqlbB5qPfJ1tJWwIy2ocT ySkW2d19mjtrg5laUZZHO1q+oB2zAmBx90CynCzBtIDFDKZ/Iw7SP8jA7hPEYvWEfMVV KhgbSIEUEMNZZ1touN7WxfI7AUZVVEhrUAhe7jT8uXsrjQE83ysKH4EDWEcBLq1Usmp2 iEunsp8NKUP6k+W5/xOMneEsGmO8VItEHb/ipW5cxT/V2wvnM4HPn5/5y+DiLWLoc/An Gw== From: Steve Sistare To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Stefan Hajnoczi , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , "Dr. David Alan Gilbert" , "Michael S. Tsirkin" , Marcel Apfelbaum , Alex Williamson , "Daniel P. Berrange" , Juan Quintela , Markus Armbruster , Eric Blake , Jason Zeng , Zheng Chuan , Steve Sistare , Mark Kanda , Guoyi Tu , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Igor Mammedov , David Hildenbrand , John Snow Subject: [PATCH V8 09/39] cpr: register blockers Date: Wed, 15 Jun 2022 07:51:56 -0700 Message-Id: <1655304746-102776-10-git-send-email-steven.sistare@oracle.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1655304746-102776-1-git-send-email-steven.sistare@oracle.com> References: <1655304746-102776-1-git-send-email-steven.sistare@oracle.com> X-Proofpoint-ORIG-GUID: H47cEWaOiEjK015ZDWgSNozFfBbZgOi5 X-Proofpoint-GUID: H47cEWaOiEjK015ZDWgSNozFfBbZgOi5 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.177.32; envelope-from=steven.sistare@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @oracle.com) X-ZM-MESSAGEID: 1655305446255100001 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Register the known cpr blockers. Signed-off-by: Steve Sistare --- accel/xen/xen-all.c | 3 +++ backends/hostmem-epc.c | 6 ++++++ migration/migration.c | 6 ++++++ replay/replay.c | 4 ++++ 4 files changed, 19 insertions(+) diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c index 69aa7d0..9dd0dc6 100644 --- a/accel/xen/xen-all.c +++ b/accel/xen/xen-all.c @@ -21,6 +21,7 @@ #include "sysemu/runstate.h" #include "migration/misc.h" #include "migration/global_state.h" +#include "migration/cpr.h" #include "hw/boards.h" =20 //#define DEBUG_XEN @@ -181,6 +182,8 @@ static int xen_init(MachineState *ms) * opt out of system RAM being allocated by generic code */ mc->default_ram_id =3D NULL; + + cpr_add_blocker_str("xen does not support cpr", &error_fatal, CPR_MODE= _ALL); return 0; } =20 diff --git a/backends/hostmem-epc.c b/backends/hostmem-epc.c index cb06255..094fed9 100644 --- a/backends/hostmem-epc.c +++ b/backends/hostmem-epc.c @@ -16,6 +16,7 @@ #include "qapi/error.h" #include "sysemu/hostmem.h" #include "hw/i386/hostmem-epc.h" +#include "migration/cpr.h" =20 static void sgx_epc_backend_memory_alloc(HostMemoryBackend *backend, Error **errp) @@ -23,6 +24,7 @@ sgx_epc_backend_memory_alloc(HostMemoryBackend *backend, = Error **errp) uint32_t ram_flags; char *name; int fd; + Error *blocker =3D NULL; =20 if (!backend->size) { error_setg(errp, "can't create backend with size 0"); @@ -41,6 +43,10 @@ sgx_epc_backend_memory_alloc(HostMemoryBackend *backend,= Error **errp) memory_region_init_ram_from_fd(&backend->mr, OBJECT(backend), name, backend->size, ram_flags, fd, 0, errp); + + error_setg(&blocker, "RAM_PROTECTED block %s does not support cpr", na= me); + cpr_add_blocker(&blocker, errp, CPR_MODE_ALL); + g_free(name); } =20 diff --git a/migration/migration.c b/migration/migration.c index 31739b2..1451bae 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -32,6 +32,7 @@ #include "savevm.h" #include "qemu-file-channel.h" #include "qemu-file.h" +#include "migration/cpr.h" #include "migration/vmstate.h" #include "block/block.h" #include "qapi/error.h" @@ -1283,6 +1284,11 @@ static bool migrate_caps_check(bool *cap_list, return false; } =20 + if (cap_list[MIGRATION_CAPABILITY_X_COLO]) { + return cpr_add_blocker_str("x-colo is not compatible with cpr", + errp, CPR_MODE_ALL); + } + return true; } =20 diff --git a/replay/replay.c b/replay/replay.c index 4c396bb..eb5456f 100644 --- a/replay/replay.c +++ b/replay/replay.c @@ -19,6 +19,7 @@ #include "qemu/option.h" #include "sysemu/cpus.h" #include "qemu/error-report.h" +#include "migration/cpr.h" =20 /* Current version of the replay mechanism. Increase it when file format changes. */ @@ -232,6 +233,9 @@ static void replay_enable(const char *fname, int mode) const char *fmode =3D NULL; assert(!replay_file); =20 + cpr_add_blocker_str("replay is not compatible with cpr", + &error_fatal, CPR_MODE_ALL); + switch (mode) { case REPLAY_MODE_RECORD: fmode =3D "wb"; --=20 1.8.3.1