From nobody Mon Feb 9 11:51:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail header.i=@quicinc.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=quicinc.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1633538230361814.8269594559811; Wed, 6 Oct 2021 09:37:10 -0700 (PDT) Received: from localhost ([::1]:59500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mY9un-0004zK-6P for importer@patchew.org; Wed, 06 Oct 2021 12:37:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mY99H-000802-PF for qemu-devel@nongnu.org; Wed, 06 Oct 2021 11:48:05 -0400 Received: from alexa-out-sd-01.qualcomm.com ([199.106.114.38]:26526) by eggs.gnu.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1mY99F-0001oQ-H0 for qemu-devel@nongnu.org; Wed, 06 Oct 2021 11:48:02 -0400 Received: from unknown (HELO ironmsg04-sd.qualcomm.com) ([10.53.140.144]) by alexa-out-sd-01.qualcomm.com with ESMTP; 06 Oct 2021 08:47:54 -0700 Received: from vu-tsimpson-aus.qualcomm.com (HELO vu-tsimpson1-aus.qualcomm.com) ([10.222.150.1]) by ironmsg04-sd.qualcomm.com with ESMTP; 06 Oct 2021 08:47:53 -0700 Received: by vu-tsimpson1-aus.qualcomm.com (Postfix, from userid 47164) id 511D1115A; Wed, 6 Oct 2021 10:47:53 -0500 (CDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1633535281; x=1665071281; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=R2uNPI4ZU+ZJpRZm4AVOZuHf0H99ndZVoMGIrxCx5l4=; b=iq1OyMgk4JIU04Ot8f8kO5NzTlzQ7GDF5nzCle/baNV95HBXxPb+aG7u tWKnhvIU+CluRcVf35H3O4k0k2OV8kT3TKDNOijwDOUvIHMN6Byvt0rc/ POz4LIy7JR7LRxnJ0gk+72dzS8BXnE141czobXT2bF2aWocXH0qA2SvNR o=; X-QCInternal: smtphost From: Taylor Simpson To: qemu-devel@nongnu.org Subject: [PULL 2/3] target/hexagon: Remove unused TCG temporary from predicated loads Date: Wed, 6 Oct 2021 10:47:50 -0500 Message-Id: <1633535271-17986-3-git-send-email-tsimpson@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1633535271-17986-1-git-send-email-tsimpson@quicinc.com> References: <1633535271-17986-1-git-send-email-tsimpson@quicinc.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=199.106.114.38; envelope-from=tsimpson@qualcomm.com; helo=alexa-out-sd-01.qualcomm.com X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, tsimpson@quicinc.com, richard.henderson@linaro.org, f4bug@amsat.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1633538232381100001 Content-Type: text/plain; charset="utf-8" From: Philippe Mathieu-Daud=C3=A9 The gen_pred_cancel() function, introduced in commit a646e99cb90 (Hexagon macros) doesn't use the 'one' TCG temporary; remove it. Reviewed-by: Richard Henderson Reviewed-by: Taylor Simpson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20211003004750.3608983-2-f4bug@amsat.org> --- target/hexagon/macros.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h index 094b8da..ae6663c 100644 --- a/target/hexagon/macros.h +++ b/target/hexagon/macros.h @@ -190,7 +190,6 @@ static inline void gen_pred_cancel(TCGv pred, int slot_= num) TCGv slot_mask =3D tcg_const_tl(1 << slot_num); TCGv tmp =3D tcg_temp_new(); TCGv zero =3D tcg_const_tl(0); - TCGv one =3D tcg_const_tl(1); tcg_gen_or_tl(slot_mask, hex_slot_cancelled, slot_mask); tcg_gen_andi_tl(tmp, pred, 1); tcg_gen_movcond_tl(TCG_COND_EQ, hex_slot_cancelled, tmp, zero, @@ -198,7 +197,6 @@ static inline void gen_pred_cancel(TCGv pred, int slot_= num) tcg_temp_free(slot_mask); tcg_temp_free(tmp); tcg_temp_free(zero); - tcg_temp_free(one); } #define PRED_LOAD_CANCEL(PRED, EA) \ gen_pred_cancel(PRED, insn->is_endloop ? 4 : insn->slot) --=20 2.7.4