From nobody Sat May 18 11:46:47 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=xilinx.com); dmarc=fail(p=none dis=none) header.from=xilinx.com ARC-Seal: i=2; a=rsa-sha256; t=1626732419; cv=pass; d=zohomail.com; s=zohoarc; b=CZs5VtECtbB9vNKQ32FWVTRO1hitOs8yKfLGWue6QTXFkaqweNl1ohVDh+lnqndBXb+AkPHelnMM2dnwZlC97xkc2WQ9yXgd/vLrbBXtkNsnoEI/kOkhJsoOORpvyrL9xRMs2OwEAytOGgl7Huk/UBHY1XAsfqlZTW7YQClu0j8= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626732419; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=n/J1YwR8vTO5lL4s+blaW6WOjmM2BEAZEXwdwi0vnlU=; b=BuayMi1LOeGasEKv1hlQ2X7qpW6TcFs4IAcdg4RCCAgL5+mxJjp5ZjR1Ssq5lch0FC/LJMMT5OoDxW06Ntj/leqGg05cQn2PKjDmhOT8jZFkMLd/gUfJNjqmG+0r6jqYP1CI+70lPfGWMsVV1jqfQkDnNlDRvoFWlq/p+gWsc4U= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=xilinx.com); dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 162673241996697.61906818609646; Mon, 19 Jul 2021 15:06:59 -0700 (PDT) Received: from localhost ([::1]:59072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5bPe-0000VJ-TV for importer@patchew.org; Mon, 19 Jul 2021 18:06:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5bLh-0004Ew-Ta for qemu-devel@nongnu.org; Mon, 19 Jul 2021 18:02:53 -0400 Received: from mail-dm6nam11on2080.outbound.protection.outlook.com ([40.107.223.80]:52028 helo=NAM11-DM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5bLg-0001Zn-2p for qemu-devel@nongnu.org; Mon, 19 Jul 2021 18:02:53 -0400 Received: from DS7PR03CA0181.namprd03.prod.outlook.com (2603:10b6:5:3b6::6) by SN4PR0201MB3456.namprd02.prod.outlook.com (2603:10b6:803:43::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.23; Mon, 19 Jul 2021 22:02:48 +0000 Received: from DM3NAM02FT006.eop-nam02.prod.protection.outlook.com (2603:10b6:5:3b6:cafe::7b) by DS7PR03CA0181.outlook.office365.com (2603:10b6:5:3b6::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.23 via Frontend Transport; Mon, 19 Jul 2021 22:02:48 +0000 Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT006.mail.protection.outlook.com (10.13.4.251) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4331.21 via Frontend Transport; Mon, 19 Jul 2021 22:02:48 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 19 Jul 2021 15:02:45 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Mon, 19 Jul 2021 15:02:45 -0700 Received: from [172.19.2.32] (port=56696 helo=xsjkomlodi50.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1m5bLZ-0003YW-Um; Mon, 19 Jul 2021 15:02:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dnMl4JGAYjFLNRd4QzjyQHx2jVSxima2/VxfRqLh5nOjEohI91D+6MJ4uuwyXFRmfASb5w9p4h+goq+RopmbLqQeSw3RL7oEc6CSLr+07lInWMdwTOO00VpdrAj+gWkWVMgvPw3q+ZQ1De4nLA+XdV5kzu+njVjyr7zG8jm0Z+i5zt2WYrT9akIx2C65zK3LcrH8qXwNLk+xpFVlQhDn0XXg6vtIbnAZQzpb4A0UHNbXmTgjqYlJwNtx3rEw6qKhBNNklC7RxmqFMDIAx7kzHBT5dlf7vYgiqVG4pXXNgweU98zsKOpGzTdAsxC1xjpZxf0HgUOoYQnPcuUQOq9vMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n/J1YwR8vTO5lL4s+blaW6WOjmM2BEAZEXwdwi0vnlU=; b=oeCStVuGB3C8KhhK5IarMPexbPnZACnZdr5AjTeyaALDTfvwi5ZxkxX96WQIW7fx0jgDNdiakIzc3/IKGedE6MA1t3QZaraLSCvZYyITCtd/d6rn7mYHIxUdQaF0qiBzZheyihWDWZk61KYlnUuwAwaMO1IW+A69aQuxq/ucE66NGB/4IoZvJ9YRCGwlQrkg+6aCOMnX9jS4GSFSWI5oS94dy6iwp1qudfwGled5snTMAmQPgKVGKDcucxQIghwG7Jq+d1KxKZ+rA0r9OO0cfCgPYdLjorcmyR8BMlmBT1z89eXl59jrhxTrPMlk8GudmNa692n23xcws8RXRLiIqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=nongnu.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n/J1YwR8vTO5lL4s+blaW6WOjmM2BEAZEXwdwi0vnlU=; b=nnWCZ3R4SKS6YUNpYAAkzDzgTiEvZGNaHZehm59QvPdgazfxN3xKB5ZdIW1llQCWeDfs2zezLLN0MFKwRDxmgSP4I2IVVGDa081FByl8Yp/X/MR/PsfWGKi0JsOqjTTxq7dHXwHQLTVgRjPpYndpV1cY+qgHSgl3F95V35orcrc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=pass action=none header.from=xilinx.com; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; From: Joe Komlodi To: Subject: [PATCH v2 1/2] hw/core/register: Add more 64-bit utilities Date: Mon, 19 Jul 2021 15:02:44 -0700 Message-ID: <1626732165-137461-2-git-send-email-joe.komlodi@xilinx.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1626732165-137461-1-git-send-email-joe.komlodi@xilinx.com> References: <1626732165-137461-1-git-send-email-joe.komlodi@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f7924a33-f503-498c-81ad-08d94b00f1fe X-MS-TrafficTypeDiagnostic: SN4PR0201MB3456: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wp29hgfWgxIgJTq21nGNX5PkmgAWYbPszp/itG4MZlldOFIjsyNZ8v1wZd5ZH3MndaevhqBOtdz62htvz+WVAszL+p8W0b68tFMEKXIa0rhcyoNr8SkEaM2GWWSw6NWp8VJEtUNJ/poUvuTvXo84/XInQVopxM8I7S2VMj8UhtS4AQ8W/v744w1oq7zM3H4JgmVx9C9ezRsLrm6ouQFyz62tRIYoNkRAolbmaVVcgSEbZvGO6JpSEIYC7kf77iLAGAQnlKn6lqBMMd5l/mkIQdm7+qlfR2DpvohjaczkazRvFZm4kuJgIImYi9WY6HRQJX291y0aEy/CgsCJfMaVF89Ur9GalD42nla81EQY3+oAnqaTCKdwkMOrcqcj+Xp29aRU/uYGkgDYnvzCWgAFUpeGXDsXGNq7Sd3JZ5LC55T525wMrL1XeH12gRpBt9quebXGE+erXSHlTJpL60KCLMB2LEMg4m+/t6pm+Y/MXj5YddMwV0d3RM5VxOm+OcYEahbufGLYNNzOVENpey87UHOn/DAKs+8Zx9ZS6pdfrzR0mRGWX3lpMuv/+T6QA5Wg45cTJLX8UnqrcRhhJ80O+MrnMzhYpM6KjWgLv20bu0LjDTEqA26gn/RmQTO1deopUT2Z9t7khWKMX8kYTsNpktYekXZRNu7Ze6sXjfKvbHFd3eTWr06cl1Ufiugb/MUoEl127sMXi6rEnBRSxg7ynBjw8HTXr73wHvui2EVA+9c= X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch01.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(4636009)(376002)(396003)(136003)(39860400002)(346002)(46966006)(36840700001)(4326008)(54906003)(9786002)(44832011)(6916009)(2906002)(36756003)(36860700001)(83380400001)(36906005)(356005)(316002)(8936002)(82740400003)(8676002)(7636003)(70206006)(47076005)(7696005)(70586007)(186003)(2616005)(5660300002)(478600001)(426003)(26005)(82310400003)(336012)(86362001)(102446001); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2021 22:02:48.0727 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f7924a33-f503-498c-81ad-08d94b00f1fe X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT006.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR0201MB3456 Received-SPF: pass client-ip=40.107.223.80; envelope-from=komlodi@xilinx.com; helo=NAM11-DM6-obe.outbound.protection.outlook.com X-Spam_score_int: 0 X-Spam_score: -0.0 X-Spam_bar: / X-Spam_report: (-0.0 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair@alistair23.me, richard.henderson@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @xilinx.onmicrosoft.com) X-ZM-MESSAGEID: 1626732421595100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We already have some utilities to handle 64-bit wide registers, so this just adds some more for: - Initializing 64-bit registers - Extracting and depositing to an array of 64-bit registers Signed-off-by: Joe Komlodi --- hw/core/register.c | 12 ++++++++++++ include/hw/register.h | 8 ++++++++ include/hw/registerfields.h | 8 ++++++++ 3 files changed, 28 insertions(+) diff --git a/hw/core/register.c b/hw/core/register.c index d6f8c20..ab20258 100644 --- a/hw/core/register.c +++ b/hw/core/register.c @@ -300,6 +300,18 @@ RegisterInfoArray *register_init_block32(DeviceState *= owner, data, ops, debug_enabled, memory_size, 32); } =20 +RegisterInfoArray *register_init_block64(DeviceState *owner, + const RegisterAccessInfo *rae, + int num, RegisterInfo *ri, + uint32_t *data, + const MemoryRegionOps *ops, + bool debug_enabled, + uint64_t memory_size) +{ + return register_init_block(owner, rae, num, ri, (void *) + data, ops, debug_enabled, memory_size, 64); +} + void register_finalize_block(RegisterInfoArray *r_array) { object_unparent(OBJECT(&r_array->mem)); diff --git a/include/hw/register.h b/include/hw/register.h index b480e38..0197e45 100644 --- a/include/hw/register.h +++ b/include/hw/register.h @@ -204,6 +204,14 @@ RegisterInfoArray *register_init_block32(DeviceState *= owner, bool debug_enabled, uint64_t memory_size); =20 +RegisterInfoArray *register_init_block64(DeviceState *owner, + const RegisterAccessInfo *rae, + int num, RegisterInfo *ri, + uint32_t *data, + const MemoryRegionOps *ops, + bool debug_enabled, + uint64_t memory_size); + /** * This function should be called to cleanup the registers that were initi= alized * when calling register_init_block32(). This function should only be call= ed diff --git a/include/hw/registerfields.h b/include/hw/registerfields.h index 93fa4a8..9a03ac5 100644 --- a/include/hw/registerfields.h +++ b/include/hw/registerfields.h @@ -30,6 +30,10 @@ enum { A_ ## reg =3D (addr) }; = \ enum { R_ ## reg =3D (addr) / 2 }; =20 +#define REG64(reg, addr) \ + enum { A_ ## reg =3D (addr) }; = \ + enum { R_ ## reg =3D (addr) / 8 }; + /* Define SHIFT, LENGTH and MASK constants for a field within a register */ =20 /* This macro will define R_FOO_BAR_MASK, R_FOO_BAR_SHIFT and R_FOO_BAR_LE= NGTH @@ -58,6 +62,8 @@ /* Extract a field from an array of registers */ #define ARRAY_FIELD_EX32(regs, reg, field) \ FIELD_EX32((regs)[R_ ## reg], reg, field) +#define ARRAY_FIELD_EX64(regs, reg, field) \ + FIELD_EX64((regs)[R_ ## reg], reg, field) =20 /* Deposit a register field. * Assigning values larger then the target field will result in @@ -99,5 +105,7 @@ /* Deposit a field to array of registers. */ #define ARRAY_FIELD_DP32(regs, reg, field, val) \ (regs)[R_ ## reg] =3D FIELD_DP32((regs)[R_ ## reg], reg, field, val); +#define ARRAY_FIELD_DP64(regs, reg, field, val) \ + (regs)[R_ ## reg] =3D FIELD_DP64((regs)[R_ ## reg], reg, field, val); =20 #endif --=20 2.7.4 From nobody Sat May 18 11:46:47 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=xilinx.com); dmarc=fail(p=none dis=none) header.from=xilinx.com ARC-Seal: i=2; a=rsa-sha256; t=1626732267; cv=pass; d=zohomail.com; s=zohoarc; b=BdmW+wR4DAh/QSsUcdeXLVb8kNe2/RNyl+Qvko4OKFyLGfuEC5jlPqHcxdMvpqp4A23DNPSxHzknHEiIBuxKYQo/Ms4bnWC6mQJK042JV2TJ//f2HvSjK3y8Xid9JQD9e4IO5j0OrXg/I6jNlBczT1mwLtNyDBdv1XAQrxUkmKQ= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626732267; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4mVexR5+lwXJzqk/7rc4qNiAiNrPFQtF4mHXUMePBks=; b=E5VZShiYfw17fNM8avuxWwE/UpehhRXPvB9vKLr68Q9M+h2G5h8OL2vug1/fDoBjH1ccQStZaKHXaOMppVz/splUUlOJXCvDuLBXp+VvScu2/yaRkXjIplU5xO4X2YTzYOhS+9OHOnCs8O90V/Ifilv5Mr8+EvdQVPvoe5b4d/Y= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=xilinx.com); dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1626732267101632.1464273449106; Mon, 19 Jul 2021 15:04:27 -0700 (PDT) Received: from localhost ([::1]:55732 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5bNB-0006Zo-UO for importer@patchew.org; Mon, 19 Jul 2021 18:04:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38040) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5bLi-0004Fe-7P for qemu-devel@nongnu.org; Mon, 19 Jul 2021 18:02:54 -0400 Received: from mail-mw2nam08on2082.outbound.protection.outlook.com ([40.107.101.82]:43393 helo=NAM04-MW2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5bLf-0001Xs-2s for qemu-devel@nongnu.org; Mon, 19 Jul 2021 18:02:54 -0400 Received: from DS7PR03CA0269.namprd03.prod.outlook.com (2603:10b6:5:3b3::34) by CH0PR02MB8105.namprd02.prod.outlook.com (2603:10b6:610:10a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.22; Mon, 19 Jul 2021 22:02:47 +0000 Received: from DM3NAM02FT036.eop-nam02.prod.protection.outlook.com (2603:10b6:5:3b3:cafe::b1) by DS7PR03CA0269.outlook.office365.com (2603:10b6:5:3b3::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21 via Frontend Transport; Mon, 19 Jul 2021 22:02:47 +0000 Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT036.mail.protection.outlook.com (10.13.5.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4331.21 via Frontend Transport; Mon, 19 Jul 2021 22:02:47 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 19 Jul 2021 15:02:46 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Mon, 19 Jul 2021 15:02:45 -0700 Received: from [172.19.2.32] (port=56696 helo=xsjkomlodi50.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1m5bLZ-0003YW-VE; Mon, 19 Jul 2021 15:02:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n1pIJ04X+/P2VJQ7oBTW0x2bXPaWpoMdScjWnUPgIJkN2/gAnhj3VodnYmBFw6OIFLBh8rXjc3JPRIANU86Ve06EfO5wlEok+rkfWOA8921gA+Cf6b6i8FBZMwEKwYHmkJrXNMDUFBK9Mx1+BUMG9cdEFibdU4UxBvmZmumGjGyCM4K1nJDoIGOjeiNDCSmgYY+0bGaNw+qiynYubGgI50YEdwW0SBZibAimWwnpR7yFecDJbjXcbAhpxaY6Ra0G3ysRHKRVrWdgZLYGGGNaAhKyu0aHkKN3BzThgMHsouPIYhvXlYuVmjpm8Wl4GG5qGvw8LLu4IJqupxzWT0TYew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4mVexR5+lwXJzqk/7rc4qNiAiNrPFQtF4mHXUMePBks=; b=g7GLJO0WqKCFSsYEg2qINdLFmnSxvZO2UWs38BN4gTuHChkgA5K75Ah3M9XblbZTwkK4iarYYZ3LyNmQEzuGZtwZcFu4tFZG+SA25an4xrgn9GqZqKFId3z3L++zYPiJs9zcZULAiiBN35yeFly2kVb3iEiH85iJaqnzHCrueR/oKGBZU1bh0YBnMJCp863S18Y7F2ZK3+r/eY2Q49SXVjL5BzD6/pdLBnlfVenT5dnm4xyanvkjcSMZGLPZeM+qR/zgta/5K+7OGiT8PZOieQ2vJ/HOBgUJIYXyrkpA2ci8Me7YrWScK8uD1zAbpMUoLKKaiNJId5cx+HL5sqK+ZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=nongnu.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4mVexR5+lwXJzqk/7rc4qNiAiNrPFQtF4mHXUMePBks=; b=ISpS9GoG7HfbQK33prqERoAdxRLwdekMhV/2fQkPEPl7qUn2KzMfsdHbK15pPNZXKHKzDoM8FDJ3g0dzkQJ+w6pSaRhlYErpwVOIttOcrNTWvRU/G9KxDvf7xTe5yQjNKk0dp4te5WmLomdWJxkk9vZuqbiedRLwN1RmfRkiY+4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=pass action=none header.from=xilinx.com; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; From: Joe Komlodi To: Subject: [PATCH v2 2/2] hw/registerfields: Use 64-bit bitfield for FIELD_DP64 Date: Mon, 19 Jul 2021 15:02:45 -0700 Message-ID: <1626732165-137461-3-git-send-email-joe.komlodi@xilinx.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1626732165-137461-1-git-send-email-joe.komlodi@xilinx.com> References: <1626732165-137461-1-git-send-email-joe.komlodi@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 678f13b0-a823-4b10-a628-08d94b00f184 X-MS-TrafficTypeDiagnostic: CH0PR02MB8105: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:2331; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m4URF+QURpYis9+Now0S8qMcUrbtCNFsl7Yg1gcNs7Apd1tZ3RcDJugQbES5HJ5gbVYXaG/Tv3e6G1uM/Cy5v/dBjpZUAIIVDlpqp0sOVJ6U+Gn2lV5x8xwHyGcEMqKKV0mGuTtWD9tG3UWWxcEylhKzz0ncDwmS1TBNnA0BOraCTo9TK09zub00s/l3F8cthahebstifNWLOWuwioix5tL56wFNwhzqc8rzeeOsbFUo79v3sdnnnAJvBMu+lOGYkugUWNyZ8Vn0ahvlac9LBjtdTFCR0bY7pHvBirrhgpSo2z9Nnlxr3pF6qnop7m0wWDWNCGGSVzK/LLc5DLjv6UINTe6hvAIljGpKEe6Qqfq9ffIYrYHCnvatK5vteQF5eredbX1cNl9/GYTGYB+X0iSTntdKGAGTtDgj0NGvHAav5CUyd87gH9Tg+Zs07lXEJaHGkF7BmnqQ6iytWKSQL8yvvrcz6wkxvTRJSD+jEVlO4gfbIUSLmhA2WFgLzaUFhBzQa7sotzj575gvF6+csJqNO6571QJYxR0syCcrHzghOOtqdnGljPY/sQ+p/oGKDe5Y9N6J8rsTJnUyw1tIG+AiALq/XkhH44foNLAekeh/jdiSWxVB++4+htzI5TUB2VuETPMYjz/Ig4+PdQWgz4NAK0+gKz4mGPV+hZeaZxD+sXwmNn+K36g7H/doo/GLzjWM9N7thc+ARYmb0QkhLZ9blGPDsn4E4uezf+sQRBw= X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch01.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(4636009)(396003)(136003)(346002)(376002)(39860400002)(46966006)(36840700001)(7696005)(2906002)(478600001)(4326008)(47076005)(54906003)(36860700001)(36906005)(316002)(82740400003)(4744005)(426003)(336012)(70586007)(44832011)(2616005)(5660300002)(70206006)(36756003)(86362001)(9786002)(82310400003)(8676002)(6916009)(26005)(356005)(8936002)(83380400001)(7636003)(186003)(102446001); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2021 22:02:47.2801 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 678f13b0-a823-4b10-a628-08d94b00f184 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT036.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR02MB8105 Received-SPF: pass client-ip=40.107.101.82; envelope-from=komlodi@xilinx.com; helo=NAM04-MW2-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair@alistair23.me, richard.henderson@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @xilinx.onmicrosoft.com) X-ZM-MESSAGEID: 1626732269439100002 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If we have a field that's wider than 32-bits, we need a data type wide enou= gh to be able to create the bitfield used to deposit the value. Signed-off-by: Joe Komlodi Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/registerfields.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/registerfields.h b/include/hw/registerfields.h index 9a03ac5..f2a3c9c 100644 --- a/include/hw/registerfields.h +++ b/include/hw/registerfields.h @@ -95,7 +95,7 @@ _d; }) #define FIELD_DP64(storage, reg, field, val) ({ \ struct { \ - unsigned int v:R_ ## reg ## _ ## field ## _LENGTH; \ + uint64_t v:R_ ## reg ## _ ## field ## _LENGTH; \ } _v =3D { .v =3D val }; = \ uint64_t _d; \ _d =3D deposit64((storage), R_ ## reg ## _ ## field ## _SHIFT, = \ --=20 2.7.4