From nobody Sat Feb 7 06:55:14 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail header.i=@quicinc.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=quicinc.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1626205840066354.4548781455311; Tue, 13 Jul 2021 12:50:40 -0700 (PDT) Received: from localhost ([::1]:44800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3OQR-00027x-22 for importer@patchew.org; Tue, 13 Jul 2021 15:50:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3ON4-0003wg-SA for qemu-devel@nongnu.org; Tue, 13 Jul 2021 15:47:11 -0400 Received: from alexa-out-sd-02.qualcomm.com ([199.106.114.39]:9796) by eggs.gnu.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1m3ON3-0002Kl-AL for qemu-devel@nongnu.org; Tue, 13 Jul 2021 15:47:10 -0400 Received: from unknown (HELO ironmsg03-sd.qualcomm.com) ([10.53.140.143]) by alexa-out-sd-02.qualcomm.com with ESMTP; 13 Jul 2021 12:47:04 -0700 Received: from vu-tsimpson-aus.qualcomm.com (HELO vu-tsimpson1-aus.qualcomm.com) ([10.222.150.1]) by ironmsg03-sd.qualcomm.com with ESMTP; 13 Jul 2021 12:47:03 -0700 Received: by vu-tsimpson1-aus.qualcomm.com (Postfix, from userid 47164) id 00207E5F; Tue, 13 Jul 2021 14:47:02 -0500 (CDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1626205629; x=1657741629; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=cRnEXpT8ddVZ8CLELYb3bek8bogcWgsdUE1PzhIzO7M=; b=FkdieQZfq4LkoAkl1Ih5QGcIkXdYMr3h9AGXVggYEYma7YbvPYv1wpvn MCM5LgJGd+3L0nCuL6bcFNvrtCcjkiu7C3zw2VmLzAM/6F+KBbtyS51dC LeWP1KachzQ/fTNX+pGV1GENFzKa7DGxEqDUwLuBMkkjcgWxCr9EcTMZZ U=; X-QCInternal: smtphost From: Taylor Simpson To: qemu-devel@nongnu.org Subject: [PATCH 1/2] Hexagon (target/hexagon) do probe_write in HELPER(commit_store) Date: Tue, 13 Jul 2021 14:46:28 -0500 Message-Id: <1626205589-19208-2-git-send-email-tsimpson@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1626205589-19208-1-git-send-email-tsimpson@quicinc.com> References: <1626205589-19208-1-git-send-email-tsimpson@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=199.106.114.39; envelope-from=tsimpson@qualcomm.com; helo=alexa-out-sd-02.qualcomm.com X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ale@rev.ng, bcain@quicinc.com, alex.bennee@linaro.org, richard.henderson@linaro.org, tsimpson@quicinc.com, philmd@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1626205840828100001 Check that access is OK before doing put_user_* Signed-off-by: Taylor Simpson --- target/hexagon/op_helper.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c index 4595559..d7f53a2 100644 --- a/target/hexagon/op_helper.c +++ b/target/hexagon/op_helper.c @@ -140,22 +140,27 @@ void HELPER(debug_check_store_width)(CPUHexagonState = *env, int slot, int check) =20 void HELPER(commit_store)(CPUHexagonState *env, int slot_num) { - switch (env->mem_log_stores[slot_num].width) { + uint8_t width =3D env->mem_log_stores[slot_num].width; + target_ulong va =3D env->mem_log_stores[slot_num].va; + +#ifdef CONFIG_USER_ONLY + g_assert(width =3D=3D 1 || width =3D=3D 2 || width =3D=3D 4 || width = =3D=3D 8); + /* We perform this check elsewhere in system mode */ + probe_write(env, va, width, MMU_USER_IDX, 0); +#endif + + switch (width) { case 1: - put_user_u8(env->mem_log_stores[slot_num].data32, - env->mem_log_stores[slot_num].va); + put_user_u8(env->mem_log_stores[slot_num].data32, va); break; case 2: - put_user_u16(env->mem_log_stores[slot_num].data32, - env->mem_log_stores[slot_num].va); + put_user_u16(env->mem_log_stores[slot_num].data32, va); break; case 4: - put_user_u32(env->mem_log_stores[slot_num].data32, - env->mem_log_stores[slot_num].va); + put_user_u32(env->mem_log_stores[slot_num].data32, va); break; case 8: - put_user_u64(env->mem_log_stores[slot_num].data64, - env->mem_log_stores[slot_num].va); + put_user_u64(env->mem_log_stores[slot_num].data64, va); break; default: g_assert_not_reached(); --=20 2.7.4 From nobody Sat Feb 7 06:55:14 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail header.i=@quicinc.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=quicinc.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1626205753494837.0154543063791; Tue, 13 Jul 2021 12:49:13 -0700 (PDT) Received: from localhost ([::1]:38888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3OP2-0006aN-EN for importer@patchew.org; Tue, 13 Jul 2021 15:49:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3ON3-0003uZ-HS for qemu-devel@nongnu.org; Tue, 13 Jul 2021 15:47:09 -0400 Received: from alexa-out-sd-01.qualcomm.com ([199.106.114.38]:23159) by eggs.gnu.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1m3ON1-0002K9-J4 for qemu-devel@nongnu.org; Tue, 13 Jul 2021 15:47:09 -0400 Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-01.qualcomm.com with ESMTP; 13 Jul 2021 12:47:04 -0700 Received: from vu-tsimpson-aus.qualcomm.com (HELO vu-tsimpson1-aus.qualcomm.com) ([10.222.150.1]) by ironmsg05-sd.qualcomm.com with ESMTP; 13 Jul 2021 12:47:03 -0700 Received: by vu-tsimpson1-aus.qualcomm.com (Postfix, from userid 47164) id 02D46F45; Tue, 13 Jul 2021 14:47:03 -0500 (CDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1626205627; x=1657741627; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=GNddvIau1IUhI6HbeGHihQhGOyut/P2fC5BWq18f60A=; b=dLtxu10tKdUDj8/ko15gUoCLmZVRXy9a3X7nKEV1AdaZEi9DiwwvrZbz MNnoOFfTe2SJP4j4TRs9NvvOyfJwJTszgReuGzpQXu3KcnW7DJwNS7D/X Lz+VWrqjBQ5h7zp1AgUMHbJ+bxjVpcEzufXg2kmiskluMkdqiRrcLF2O4 Y=; X-QCInternal: smtphost From: Taylor Simpson To: qemu-devel@nongnu.org Subject: [PATCH 2/2] linux-test (tests/tcg/multiarch/linux-test.c) add check Date: Tue, 13 Jul 2021 14:46:29 -0500 Message-Id: <1626205589-19208-3-git-send-email-tsimpson@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1626205589-19208-1-git-send-email-tsimpson@quicinc.com> References: <1626205589-19208-1-git-send-email-tsimpson@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=199.106.114.38; envelope-from=tsimpson@qualcomm.com; helo=alexa-out-sd-01.qualcomm.com X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ale@rev.ng, bcain@quicinc.com, alex.bennee@linaro.org, richard.henderson@linaro.org, tsimpson@quicinc.com, philmd@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1626205755690100003 Add a check that the SIGSEGV handler is called Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson --- tests/tcg/multiarch/linux-test.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux-t= est.c index c8c6aed..cb845c9 100644 --- a/tests/tcg/multiarch/linux-test.c +++ b/tests/tcg/multiarch/linux-test.c @@ -439,10 +439,13 @@ static void sig_alarm(int sig) alarm_count++; } =20 +static int sig_segv_called; + static void sig_segv(int sig, siginfo_t *info, void *puc) { if (sig !=3D SIGSEGV) error("signal"); + sig_segv_called =3D 1; longjmp(jmp_env, 1); } =20 @@ -492,6 +495,10 @@ static void test_signal(void) *(volatile uint8_t *)0 =3D 0; } =20 + if (sig_segv_called =3D=3D 0) { + error("SIGSEGV handler not called"); + } + act.sa_handler =3D SIG_DFL; sigemptyset(&act.sa_mask); act.sa_flags =3D 0; --=20 2.7.4