From nobody Mon Feb 9 10:12:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail header.i=@quicinc.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=quicinc.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1624987001858138.40706770825682; Tue, 29 Jun 2021 10:16:41 -0700 (PDT) Received: from localhost ([::1]:44542 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyHLk-000098-Kc for importer@patchew.org; Tue, 29 Jun 2021 13:16:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyHK4-0005sT-SR for qemu-devel@nongnu.org; Tue, 29 Jun 2021 13:14:56 -0400 Received: from alexa-out-sd-02.qualcomm.com ([199.106.114.39]:64090) by eggs.gnu.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lyHK2-0001dl-81 for qemu-devel@nongnu.org; Tue, 29 Jun 2021 13:14:56 -0400 Received: from unknown (HELO ironmsg04-sd.qualcomm.com) ([10.53.140.144]) by alexa-out-sd-02.qualcomm.com with ESMTP; 29 Jun 2021 10:14:51 -0700 Received: from vu-tsimpson-aus.qualcomm.com (HELO vu-tsimpson1-aus.qualcomm.com) ([10.222.150.1]) by ironmsg04-sd.qualcomm.com with ESMTP; 29 Jun 2021 10:14:50 -0700 Received: by vu-tsimpson1-aus.qualcomm.com (Postfix, from userid 47164) id 9FE69EE0; Tue, 29 Jun 2021 12:14:50 -0500 (CDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1624986894; x=1656522894; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=U7rXWaOOXZpLpJQOJXiUNrlSMCVamlhW+D5+ICNQuJw=; b=UBdnRE47aSnEKeoRXqhemdHNO4mfpdvfumVvNPJCt1hyFZ3OgOihsXkH P9uOa2+s6PXoZuAumiEB8tPuZZmz3KTzGq/XY0fp2+PddGiZ1Cpkeql8E pk+HybdZdVvRsjiIAnrVJnUz16QnHj6rFC89LwQSydgkC8AQW+bKHhQ5h 8=; X-QCInternal: smtphost From: Taylor Simpson To: qemu-devel@nongnu.org Subject: [PULL v2 4/4] Hexagon (target/hexagon) remove unused TCG variables Date: Tue, 29 Jun 2021 12:14:36 -0500 Message-Id: <1624986876-2264-5-git-send-email-tsimpson@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1624986876-2264-1-git-send-email-tsimpson@quicinc.com> References: <1624986876-2264-1-git-send-email-tsimpson@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=199.106.114.39; envelope-from=tsimpson@qualcomm.com; helo=alexa-out-sd-02.qualcomm.com X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ale@rev.ng, peter.maydell@linaro.org, bcain@quicinc.com, richard.henderson@linaro.org, tsimpson@quicinc.com, philmd@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1622589584-22571-5-git-send-email-tsimpson@quicinc.com> --- target/hexagon/genptr.c | 6 ------ target/hexagon/translate.c | 11 ++--------- 2 files changed, 2 insertions(+), 15 deletions(-) diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c index fba5ec6..7333299 100644 --- a/target/hexagon/genptr.c +++ b/target/hexagon/genptr.c @@ -115,10 +115,7 @@ static void gen_log_reg_write_pair(int rnum, TCGv_i64 = val) =20 static inline void gen_log_pred_write(DisasContext *ctx, int pnum, TCGv va= l) { - TCGv zero =3D tcg_const_tl(0); TCGv base_val =3D tcg_temp_new(); - TCGv and_val =3D tcg_temp_new(); - TCGv pred_written =3D tcg_temp_new(); =20 tcg_gen_andi_tl(base_val, val, 0xff); =20 @@ -137,10 +134,7 @@ static inline void gen_log_pred_write(DisasContext *ct= x, int pnum, TCGv val) } tcg_gen_ori_tl(hex_pred_written, hex_pred_written, 1 << pnum); =20 - tcg_temp_free(zero); tcg_temp_free(base_val); - tcg_temp_free(and_val); - tcg_temp_free(pred_written); } =20 static inline void gen_read_p3_0(TCGv control_reg) diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index 9a37644..b23d36a 100644 --- a/target/hexagon/translate.c +++ b/target/hexagon/translate.c @@ -273,7 +273,6 @@ static void gen_reg_writes(DisasContext *ctx) =20 static void gen_pred_writes(DisasContext *ctx, Packet *pkt) { - TCGv zero, control_reg, pval; int i; =20 /* Early exit if the log is empty */ @@ -281,10 +280,6 @@ static void gen_pred_writes(DisasContext *ctx, Packet = *pkt) return; } =20 - zero =3D tcg_const_tl(0); - control_reg =3D tcg_temp_new(); - pval =3D tcg_temp_new(); - /* * Only endloop instructions will conditionally * write a predicate. If there are no endloop @@ -292,6 +287,7 @@ static void gen_pred_writes(DisasContext *ctx, Packet *= pkt) * write of the predicates. */ if (pkt->pkt_has_endloop) { + TCGv zero =3D tcg_const_tl(0); TCGv pred_written =3D tcg_temp_new(); for (i =3D 0; i < ctx->preg_log_idx; i++) { int pred_num =3D ctx->preg_log[i]; @@ -302,6 +298,7 @@ static void gen_pred_writes(DisasContext *ctx, Packet *= pkt) hex_new_pred_value[pred_num], hex_pred[pred_num]); } + tcg_temp_free(zero); tcg_temp_free(pred_written); } else { for (i =3D 0; i < ctx->preg_log_idx; i++) { @@ -314,10 +311,6 @@ static void gen_pred_writes(DisasContext *ctx, Packet = *pkt) } } } - - tcg_temp_free(zero); - tcg_temp_free(control_reg); - tcg_temp_free(pval); } =20 static void gen_check_store_width(DisasContext *ctx, int slot_num) --=20 2.7.4