From nobody Tue Feb 10 02:55:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1624030668; cv=none; d=zohomail.com; s=zohoarc; b=QzxnbEAqhD9dPn1VVt7ul2OpwHMssvla39PzWAZO8FKlPl1airZ3UNRhq/4x3lrTBOyT3k6ZvfoI1MTuGUZ7pgp1RhZc8YMkKTCsKOJr13owQc2kpBsyhcYzg0W2gB0esFaPy0CJJoHLtS3LusQ1jEM+Q7bTrifB1B30LzT7fxY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1624030668; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=b497Plty6INS5DVpmKNuonj9C7Ksw1Na97HVdIQJWVo=; b=DmCNmhJqv9XEpvfr5jlYhWu9xveSBmMcH0P/qMQ9SeJUkpIlopjQQT9IvltTIeOZeBncIX/HCWN9qe3fqScV9t7wNR44t5bVvXS4hnP3yrdUXCe9orw1C6DLqIJnSg2NoziVJ6ieH27ICxYXdwTdirjD1u2swoJI2vpQ6DMT3Tk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1624030668680779.7995355807257; Fri, 18 Jun 2021 08:37:48 -0700 (PDT) Received: from localhost ([::1]:53210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luGZ1-0002no-HY for importer@patchew.org; Fri, 18 Jun 2021 11:37:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luGWb-0006Hh-JD for qemu-devel@nongnu.org; Fri, 18 Jun 2021 11:35:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:32100) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luGWZ-0004UC-AU for qemu-devel@nongnu.org; Fri, 18 Jun 2021 11:35:17 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-527-nJnlRGl1ONSpPZVvCWCngA-1; Fri, 18 Jun 2021 11:35:13 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1057A9F92A; Fri, 18 Jun 2021 15:35:12 +0000 (UTC) Received: from [172.30.41.16] (ovpn-112-106.phx2.redhat.com [10.3.112.106]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5EBA41001281; Fri, 18 Jun 2021 15:35:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624030514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b497Plty6INS5DVpmKNuonj9C7Ksw1Na97HVdIQJWVo=; b=aDMmxllWYQflErGjs8fgbm6+kdGQ6Y6KwigyNeGmJTyBoYpmgvgn4LsGjzUXle0kFfizNJ I8FWfJcmytgJzVPvsinPUwfBGgAIDIbhyOHHadU+mHs3oYv0UHAvb/O+30MWZArtbCu6LG +fwErPYRY4Fl3wcBzFSf5hE23tqMXHA= X-MC-Unique: nJnlRGl1ONSpPZVvCWCngA-1 Subject: [PULL 3/3] vfio/migration: Correct device state from vmstate change for savevm case From: Alex Williamson To: qemu-devel@nongnu.org Date: Fri, 18 Jun 2021 09:35:05 -0600 Message-ID: <162403050520.1793226.14555349399059942330.stgit@omen> In-Reply-To: <162403041204.1793226.16018359908572247606.stgit@omen> References: <162403041204.1793226.16018359908572247606.stgit@omen> User-Agent: StGit/1.0-8-g6af9-dirty MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=alex.williamson@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=alex.williamson@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.194, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kirti Wankhede , alex.williamson@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) From: Kirti Wankhede Set _SAVING flag for device state from vmstate change handler when it gets called from savevm. Currently State transition savevm/suspend is seen as: _RUNNING -> _STOP -> Stop-and-copy -> _STOP State transition savevm/suspend should be: _RUNNING -> Stop-and-copy -> _STOP State transition from _RUNNING to _STOP occurs from vfio_vmstate_change() where when vmstate changes from running to !running, _RUNNING flag is reset but at the same time when vfio_vmstate_change() is called for RUN_STATE_SAVE_VM, _SAVING bit should be set. Reported by: Yishai Hadas Signed-off-by: Kirti Wankhede Message-Id: <1623177441-27496-1-git-send-email-kwankhede@nvidia.com> Signed-off-by: Alex Williamson --- hw/vfio/migration.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c index ef397ebe6c09..82f654afb64a 100644 --- a/hw/vfio/migration.c +++ b/hw/vfio/migration.c @@ -724,7 +724,16 @@ static void vfio_vmstate_change(void *opaque, bool run= ning, RunState state) * _RUNNING bit */ mask =3D ~VFIO_DEVICE_STATE_RUNNING; - value =3D 0; + + /* + * When VM state transition to stop for savevm command, device sho= uld + * start saving data. + */ + if (state =3D=3D RUN_STATE_SAVE_VM) { + value =3D VFIO_DEVICE_STATE_SAVING; + } else { + value =3D 0; + } } =20 ret =3D vfio_migration_set_state(vbasedev, mask, value);