From nobody Fri Apr 11 15:57:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1622089676; cv=none; d=zohomail.com; s=zohoarc; b=cXPCMpoaEOikkfZJ8u8PhlabXmnJ0uGvyaVZCpyrRGoYCt0SaXfZrwcPoGvo+VBUg9ypTp+rlZHdaEuFUIoD82/wUXRpVRYKApWPN0PNsnX51x1shNhAXTB32TvjMEwSnpWRV1BRMkXSjS4sTqA4LAILnHCx/fgNdxpHHWvOUlc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622089676; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=NGxnL58cZ7J0FpLILJVl5iGWIs/UZR1ZMuS4cpTk2M0=; b=XRvr4Zh4moyRCoCwwq+hklFxCV1bXMLhN7Jci4WvfOwWrb0ggNEzE8KxoDAzVPo2ClanyuFzDqZO0Zz3VcLuuXtIqhVECfwlQs2msq8GXtAMegsLICGvaEm0L8ND+/ckpUKDMgzmOU4ZmgJqaH6TU0I7ccZ0fXvk/gfMlSTY+tE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1622089676632680.1103365059129; Wed, 26 May 2021 21:27:56 -0700 (PDT) Received: from localhost ([::1]:43392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lm7cf-0008Og-I8 for importer@patchew.org; Thu, 27 May 2021 00:27:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46408) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lm7Zl-0002kX-0n for qemu-devel@nongnu.org; Thu, 27 May 2021 00:24:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:42653) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lm7Zj-00064U-BO for qemu-devel@nongnu.org; Thu, 27 May 2021 00:24:52 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-236-j7tErrmzMPepC8pn5kPndQ-1; Thu, 27 May 2021 00:24:47 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 74D16107ACCA; Thu, 27 May 2021 04:24:46 +0000 (UTC) Received: from jason-ThinkPad-T430s.redhat.com (ovpn-13-43.pek2.redhat.com [10.72.13.43]) by smtp.corp.redhat.com (Postfix) with ESMTP id DDFEC5D6D3; Thu, 27 May 2021 04:24:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622089490; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type:in-reply-to:in-reply-to: references:references; bh=NGxnL58cZ7J0FpLILJVl5iGWIs/UZR1ZMuS4cpTk2M0=; b=XfPKXQyI8htwCa+Ov54tAPbcnswz2FY2aVZ6sOoxYbn+uWMmz4jm77CsDYOCRWR0R07wU5 hh+3B/720YrlqUGYdv7x4K7strF2/op0qTkqH1xtWQQp71CvL/ecwukRxph5adufKyz9+T dqCTKNAGFiK8Dr8cAWRqFxtlHHaJC1Q= X-MC-Unique: j7tErrmzMPepC8pn5kPndQ-1 From: Jason Wang To: peter.maydell@linaro.org Subject: [PULL V2 2/3] virtio-net: failover: add missing remove_migration_state_change_notifier() Date: Thu, 27 May 2021 12:24:37 +0800 Message-Id: <1622089478-5426-3-git-send-email-jasowang@redhat.com> In-Reply-To: <1622089478-5426-1-git-send-email-jasowang@redhat.com> References: <1622089478-5426-1-git-send-email-jasowang@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.371, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Jason Wang , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Laurent Vivier In the failover case configuration, virtio_net_device_realize() uses an add_migration_state_change_notifier() to add a state notifier, but this notifier is not removed by the unrealize function when the virtio-net card is unplugged. If the card is unplugged and a migration is started, the notifier is called and as it is not valid anymore QEMU crashes. This patch fixes the problem by adding the remove_migration_state_change_notifier() in virtio_net_device_unrealize(). The problem can be reproduced with: $ qemu-system-x86_64 -enable-kvm -m 1g -M q35 \ -device pcie-root-port,slot=3D4,id=3Droot1 \ -device pcie-root-port,slot=3D5,id=3Droot2 \ -device virtio-net-pci,id=3Dnet1,mac=3D52:54:00:6f:55:cc,failover=3Don,= bus=3Droot1 \ -monitor stdio disk.qcow2 (qemu) device_del net1 (qemu) migrate "exec:gzip -c > STATEFILE.gz" Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. 0x0000000000000000 in ?? () (gdb) bt #0 0x0000000000000000 in () #1 0x0000555555d726d7 in notifier_list_notify (...) at .../util/notify.c:39 #2 0x0000555555842c1a in migrate_fd_connect (...) at .../migration/migration.c:3975 #3 0x0000555555950f7d in migration_channel_connect (...) error@entry=3D0x0) at .../migration/channel.c:107 #4 0x0000555555910922 in exec_start_outgoing_migration (...) at .../migration/exec.c:42 Reported-by: Igor Mammedov Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Michael S. Tsirkin Signed-off-by: Laurent Vivier Signed-off-by: Jason Wang --- hw/net/virtio-net.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 66b9ff4..914051f 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -3373,6 +3373,7 @@ static void virtio_net_device_unrealize(DeviceState *= dev) =20 if (n->failover) { device_listener_unregister(&n->primary_listener); + remove_migration_state_change_notifier(&n->migration_state); } =20 max_queues =3D n->multiqueue ? n->max_queues : 1; --=20 2.7.4