From nobody Wed Nov 19 16:44:51 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1616641079; cv=none; d=zohomail.com; s=zohoarc; b=ekD1zHHqMujoDf5kxp5dHX7srNCZGuOjmDz7zn4BW0lKk0qQ7sQPmSuEnfH1DlLR4syX3rhDqWOxPXcH/LL8jEztdrxzTnUIBob+05gicL4ifOJwGwDcJA8s9gLmDGF0HfoY+r15wK1z+OQ1hi/OdMQ2cvJyTb5rw44It1DL6zE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616641079; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=P/dh3PmlTRcXBIa5nFoZ3LrmeOZgzrcgKG87cdBMEPE=; b=NqK/sQ1vXRX7fv8cuWnOHl5r0yn4uIpkYIK/iX5svgRCW4EFe4wcHA/zE38Wz6vXId0HJP05b51PemOidJyObSbrqGOg+ve7mUuA7bwGMlZR+DGfIF0iWT1/hO5mF1gCkkLBQJrzC7dKrM9xcDzPCyC4WffrjcIOScVwfSL9gS8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1616641079798812.3127125225599; Wed, 24 Mar 2021 19:57:59 -0700 (PDT) Received: from localhost ([::1]:46400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPGC6-0003nl-Ms for importer@patchew.org; Wed, 24 Mar 2021 22:57:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPG33-0001Bb-3F for qemu-devel@nongnu.org; Wed, 24 Mar 2021 22:48:37 -0400 Received: from mga07.intel.com ([134.134.136.100]:40272) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPG2x-0001k6-0i for qemu-devel@nongnu.org; Wed, 24 Mar 2021 22:48:34 -0400 Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 19:48:30 -0700 Received: from unknown (HELO localhost.localdomain.bj.intel.com) ([10.240.192.103]) by orsmga003.jf.intel.com with ESMTP; 24 Mar 2021 19:48:28 -0700 IronPort-SDR: xcEfYaul7xobVVyi7rx1+rCiOatV0PT7/9AHBA/pIG/jGzIy5ZEFX0l+xESQu1k3bHXt/tH0ar Oc21GRk/3srg== X-IronPort-AV: E=McAfee;i="6000,8403,9933"; a="254823147" X-IronPort-AV: E=Sophos;i="5.81,276,1610438400"; d="scan'208";a="254823147" IronPort-SDR: lS9PtaVqspX7CuAJOCnYi5yuZICnUAvnmiN+qvpMyZo8OMNlyw3smvHUoEN2EaGz5BEd34K9sO mNlaBc45Oisw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,276,1610438400"; d="scan'208";a="374881453" From: leirao To: chen.zhang@intel.com, lizhijian@cn.fujitsu.com, jasowang@redhat.com, quintela@redhat.com, dgilbert@redhat.com, pbonzini@redhat.com, lukasstraub2@web.de Subject: [PATCH v4 09/10] Add the function of colo_bitmap_clear_diry. Date: Thu, 25 Mar 2021 10:24:50 +0800 Message-Id: <1616639091-28279-10-git-send-email-lei.rao@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1616639091-28279-1-git-send-email-lei.rao@intel.com> References: <1616639091-28279-1-git-send-email-lei.rao@intel.com> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=134.134.136.100; envelope-from=lei.rao@intel.com; helo=mga07.intel.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Rao, Lei" , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Rao, Lei" When we use continuous dirty memory copy for flushing ram cache on secondary VM, we can also clean up the bitmap of contiguous dirty page memory. This also can reduce the VM stop time during checkpoint. Signed-off-by: Lei Rao --- migration/ram.c | 29 +++++++++++++++++++++++++---- 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index a258466..ae1e659 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -855,6 +855,30 @@ unsigned long colo_bitmap_find_dirty(RAMState *rs, RAM= Block *rb, return first; } =20 +/** + * colo_bitmap_clear_dirty:when we flush ram cache to ram, we will use + * continuous memory copy, so we can also clean up the bitmap of contiguous + * dirty memory. + */ +static inline bool colo_bitmap_clear_dirty(RAMState *rs, + RAMBlock *rb, + unsigned long start, + unsigned long num) +{ + bool ret; + unsigned long i =3D 0; + + qemu_mutex_lock(&rs->bitmap_mutex); + for (i =3D 0; i < num; i++) { + ret =3D test_and_clear_bit(start + i, rb->bmap); + if (ret) { + rs->migration_dirty_pages--; + } + } + qemu_mutex_unlock(&rs->bitmap_mutex); + return ret; +} + static inline bool migration_bitmap_clear_dirty(RAMState *rs, RAMBlock *rb, unsigned long page) @@ -3700,7 +3724,6 @@ void colo_flush_ram_cache(void) void *src_host; unsigned long offset =3D 0; unsigned long num =3D 0; - unsigned long i =3D 0; =20 memory_global_dirty_log_sync(); WITH_RCU_READ_LOCK_GUARD() { @@ -3722,9 +3745,7 @@ void colo_flush_ram_cache(void) num =3D 0; block =3D QLIST_NEXT_RCU(block, next); } else { - for (i =3D 0; i < num; i++) { - migration_bitmap_clear_dirty(ram_state, block, offset = + i); - } + colo_bitmap_clear_dirty(ram_state, block, offset, num); dst_host =3D block->host + (((ram_addr_t)offset) << TARGET_PAGE_BITS); src_host =3D block->colo_cache --=20 1.8.3.1