From nobody Wed Dec 17 21:48:38 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1616408922; cv=none; d=zohomail.com; s=zohoarc; b=kobmIN6Hz87WgNfaiRoBIJpgl0oq+2s24cXxW1ALDanrMXn7WxXU3FCirr41AV+87pWfdCcYnb4jMia0OlFMJ5LP6e+uuQzHjP3cBssBSoPrmNuTI10PozF1TUqxbAzSJx1QyGpQugD94Gxhv9lQDqQ1XnVbs9nNwyjmtAfQVQ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616408922; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=li1/W5hrKx84TypTdp+t+l1qRxUaNARzTlMho5yOCv4=; b=kO6X65tREZoyJpsnA8ViSy1FQVZHnJjisZUH6rEEKevwQ/T+FkUEV2LljypY6N/iXT11hVdNVqAceGwt+Oq8YM9DT8RoWVhoJKh1xCmAgHq9LHBSG40UFmsYWnjVLjl62PObKG2b5ens8Un+AFseNOAfjPD9VZQs9gmve8Wzoio= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1616408922527447.47927265912483; Mon, 22 Mar 2021 03:28:42 -0700 (PDT) Received: from localhost ([::1]:38864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOHnc-0000c6-Gb for importer@patchew.org; Mon, 22 Mar 2021 06:28:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56284) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOHUF-00085O-BQ for qemu-devel@nongnu.org; Mon, 22 Mar 2021 06:08:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:22996) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lOHUD-0002te-D4 for qemu-devel@nongnu.org; Mon, 22 Mar 2021 06:08:39 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-532-CBgDfmmVNoqAKJ3NBgpixQ-1; Mon, 22 Mar 2021 06:08:33 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B93BB612A9; Mon, 22 Mar 2021 10:08:32 +0000 (UTC) Received: from jason-ThinkPad-T430s.redhat.com (ovpn-12-83.pek2.redhat.com [10.72.12.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id B2EAF5D9CD; Mon, 22 Mar 2021 10:08:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616407716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type:in-reply-to:in-reply-to: references:references; bh=li1/W5hrKx84TypTdp+t+l1qRxUaNARzTlMho5yOCv4=; b=ZuomJQGcNGrJaJJ5kJ9N6D1NvkZNEazX672AMuJO2juRVotiaF8UUHb7ulytCImREUbQhS urek0JJU8t6CVt3nBqKYPZ4jOVlXYyuCiMk18/BKAJaAZzpb48XgsoaMZswqvM2wkUFEgQ iFRN00JKOucbj3KTAPDb4elOxBR1Le8= X-MC-Unique: CBgDfmmVNoqAKJ3NBgpixQ-1 From: Jason Wang To: qemu-devel@nongnu.org, peter.maydell@linaro.org Subject: [PULL 05/13] net/colo-compare.c: Fix memory leak for non-tcp packet Date: Mon, 22 Mar 2021 18:08:04 +0800 Message-Id: <1616407692-693-6-git-send-email-jasowang@redhat.com> In-Reply-To: <1616407692-693-1-git-send-email-jasowang@redhat.com> References: <1616407692-693-1-git-send-email-jasowang@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhang Chen , Jason Wang , Lukas Straub Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Lukas Straub Additional to removing the packet from the secondary queue, we also need to free it. Signed-off-by: Lukas Straub Signed-off-by: Zhang Chen Reviewed-by: Zhang Chen Signed-off-by: Jason Wang --- net/colo-compare.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/colo-compare.c b/net/colo-compare.c index 84db497..2e819ff 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -690,6 +690,7 @@ static void colo_compare_packet(CompareState *s, Connec= tion *conn, =20 if (result) { colo_release_primary_pkt(s, pkt); + packet_destroy(result->data, NULL); g_queue_remove(&conn->secondary_list, result->data); } else { /* --=20 2.7.4