From nobody Fri Apr 11 23:10:54 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1615800229; cv=none; d=zohomail.com; s=zohoarc; b=jSOFCGtws4G+9v9mMAA0nkhqUK1oFbXdeyupoA3zinPyBv1V3/UEI1y5w9xBs3vyKa8/SnTccepf1H5DNps4u0EbFLCoixl7zSF9DnWoIUu1KqfcUHeRZh3X26yem3X4/kOnYPP9qxAMVAG6MTgNWMQfNyhh3cGP0U2vMAf9MME= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615800229; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qKE7TWyoGxDr+8pHmWsEJIClKHQdRsabnkAaiD6An8s=; b=YNxJWIdcm5ElY7PO31TbjCKwmbShZZZ5T8CHGgJrhc3m2IqHjYJu4iswo/CtsrQhB48MVmS09iKoFlXXv7wbTc3lp94jY2n+6WBzmi4tXaV8RZin1Gw8x4Qtl5EQErOy00xF7FpNWiBZ8y2zBYlqQEv487NXfsKF8VRpxyrwG4k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16158002293433.033065364442109; Mon, 15 Mar 2021 02:23:49 -0700 (PDT) Received: from localhost ([::1]:47994 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLjRz-0000SV-Vy for importer@patchew.org; Mon, 15 Mar 2021 05:23:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLjJf-0007tB-9J for qemu-devel@nongnu.org; Mon, 15 Mar 2021 05:15:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:59171) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lLjJb-0007mU-4u for qemu-devel@nongnu.org; Mon, 15 Mar 2021 05:15:11 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-199--FOSbTI7NQur5kwFM3P3NQ-1; Mon, 15 Mar 2021 05:15:04 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E68F1760C1; Mon, 15 Mar 2021 09:15:02 +0000 (UTC) Received: from jason-ThinkPad-T430s.redhat.com (ovpn-13-105.pek2.redhat.com [10.72.13.105]) by smtp.corp.redhat.com (Postfix) with ESMTP id 035C81007625; Mon, 15 Mar 2021 09:15:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615799705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qKE7TWyoGxDr+8pHmWsEJIClKHQdRsabnkAaiD6An8s=; b=Bu3LxIY6LmDcCk5quz75MQYrVSjqhRO9MbrFF76AOb8x/JALHRg9F56JqW8CPMO9PliiSx 3f8E6PabgjrH/tB3TFfry19UHeutfZayEVTeZiZn2VJ9yH9cgJR1JwlsdTcZaCH2eDW9a4 MwJ4cM5BMHulkbuhOmf2eHka0ADGMAo= X-MC-Unique: -FOSbTI7NQur5kwFM3P3NQ-1 From: Jason Wang To: peter.maydell@linaro.org Subject: [PULL V2 07/20] dp8393x: switch to use qemu_receive_packet() for loopback packet Date: Mon, 15 Mar 2021 17:14:20 +0800 Message-Id: <1615799673-31549-8-git-send-email-jasowang@redhat.com> In-Reply-To: <1615799673-31549-1-git-send-email-jasowang@redhat.com> References: <1615799673-31549-1-git-send-email-jasowang@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , qemu-stable@nongnu.org, qemu-devel@nongnu.org, Prasad J Pandit Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) This patch switches to use qemu_receive_packet() which can detect reentrancy and return early. This is intended to address CVE-2021-3416. Cc: Prasad J Pandit Cc: qemu-stable@nongnu.org Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/net/dp8393x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index 205c0de..533a830 100644 --- a/hw/net/dp8393x.c +++ b/hw/net/dp8393x.c @@ -506,7 +506,7 @@ static void dp8393x_do_transmit_packets(dp8393xState *s) s->regs[SONIC_TCR] |=3D SONIC_TCR_CRSL; if (nc->info->can_receive(nc)) { s->loopback_packet =3D 1; - nc->info->receive(nc, s->tx_buffer, tx_len); + qemu_receive_packet(nc, s->tx_buffer, tx_len); } } else { /* Transmit packet */ --=20 2.7.4