From nobody Fri May 17 13:25:38 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail header.i=@quicinc.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=quicinc.com ARC-Seal: i=1; a=rsa-sha256; t=1615784236; cv=none; d=zohomail.com; s=zohoarc; b=BLN1ddrbsuLM4X+WU81j9sv77V/AUwehgllE4Ph2fklrUNxS6071UsvZjmwfjwcYzpnvJMIK1NoRzD8jMew9HL+EkSIeBXLgny+YnlerBjzyRLZlM1MZFuzeZODWIj3pSdUvSs/QUbMOXv4yQnk3rTw8hcyB8UsYXtNPAhHGQ3Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615784236; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=6TxhB2ga6uB2MT0TSi0EOS9YKlQYdqhNQ0WpUNZHuWA=; b=NrrUPTNUqFOTnMChW8Wilu9W2g6RGMHsEfY2kOuBTG+zWg26xbl8o52CsDuzu2cAXaGzLpqPG6XHdhI9viYGWrah7GQ1iViINpLfG/iuA8TrUWvdUfQ1LqKulXjBQK49EWREkDgfNm7soEbfPm7d3W7r6PTqDQZS0vxSBnzZ9kE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail header.i=@quicinc.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615784236645523.9272879724134; Sun, 14 Mar 2021 21:57:16 -0700 (PDT) Received: from localhost ([::1]:54188 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLfI3-0008Fp-JQ for importer@patchew.org; Mon, 15 Mar 2021 00:57:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLfFl-000665-7E for qemu-devel@nongnu.org; Mon, 15 Mar 2021 00:54:53 -0400 Received: from alexa-out-sd-02.qualcomm.com ([199.106.114.39]:40968) by eggs.gnu.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lLfFj-0003kf-GK for qemu-devel@nongnu.org; Mon, 15 Mar 2021 00:54:52 -0400 Received: from unknown (HELO ironmsg03-sd.qualcomm.com) ([10.53.140.143]) by alexa-out-sd-02.qualcomm.com with ESMTP; 14 Mar 2021 21:54:50 -0700 Received: from vu-tsimpson-aus.qualcomm.com (HELO vu-tsimpson1-aus.qualcomm.com) ([10.222.150.1]) by ironmsg03-sd.qualcomm.com with ESMTP; 14 Mar 2021 21:54:49 -0700 Received: by vu-tsimpson1-aus.qualcomm.com (Postfix, from userid 47164) id BEBBDC90; Sun, 14 Mar 2021 23:54:49 -0500 (CDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1615784091; x=1647320091; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=SIZrl0Bj0PYYrecgcb1RLy/TVXnXFFzOa5Iu8XMcSNc=; b=fo49E5UL2XDcM5/Lgpb1yjQRz4bLGs69eGs+EdA8AfJBw6mgVxPPt7AA oSW4Kh/mly4hET/AN9HuhVPH/Op9ZVHZA13N5ffjgH4zhzg7QUcjaKo40 9MzOunM2Ydrp/wBPoAO67wr1RYTbwghtoqKQoxHrjyNexjuNsBm1AAKZ8 E=; X-QCInternal: smtphost From: Taylor Simpson To: qemu-devel@nongnu.org Subject: [PATCH] Hexagon (target/hexagon) TCG generation cleanup Date: Sun, 14 Mar 2021 23:54:48 -0500 Message-Id: <1615784088-26384-1-git-send-email-tsimpson@quicinc.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=199.106.114.39; envelope-from=tsimpson@qualcomm.com; helo=alexa-out-sd-02.qualcomm.com X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: philmd@redhat.com, tsimpson@quicinc.com, richard.henderson@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Simplify TCG generation of hex_reg_written Address feedback from Richard Henderson < Signed-off-by: Taylor Simpson --- target/hexagon/genptr.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c index 7481f4c..0ad63fe 100644 --- a/target/hexagon/genptr.c +++ b/target/hexagon/genptr.c @@ -43,9 +43,15 @@ static inline void gen_log_predicated_reg_write(int rnum= , TCGv val, int slot) tcg_gen_movcond_tl(TCG_COND_EQ, hex_new_value[rnum], slot_mask, zero, val, hex_new_value[rnum]); #if HEX_DEBUG - /* Do this so HELPER(debug_commit_end) will know */ - tcg_gen_movcond_tl(TCG_COND_EQ, hex_reg_written[rnum], slot_mask, zero, - one, hex_reg_written[rnum]); + /* + * Do this so HELPER(debug_commit_end) will know + * + * Note that slot_mask indicates the value is not written + * (i.e., slot was cancelled), so we negate the value before + * or'ing with hex_reg_written[rnum]. + */ + tcg_gen_xori_tl(slot_mask, slot_mask, 1 << slot); + tcg_gen_or_tl(hex_reg_written[rnum], hex_reg_written[rnum], slot_mask); #endif =20 tcg_temp_free(one); --=20 2.7.4