From nobody Fri May 17 07:55:59 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail header.i=@quicinc.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=quicinc.com ARC-Seal: i=1; a=rsa-sha256; t=1614877129; cv=none; d=zohomail.com; s=zohoarc; b=lzE8lxaazxF60FKflf0us6C59ICnCDDxrpU+BkJd6Dfx21X2shD+sPz5FlyDItbqVX6BtLo4DNoqqOe6R0jyhvsx/YUvFjWSiO3cZc8MpnBE4P7uT2JuHigzoySZTx4b2fJHxr05sMfxuyKDcezus4hVZXDMQtPnnbBYMJqBIok= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614877129; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=SdHDsDSIc2+G5FcVx2srmgkWemmozeZIWa72OZ9cKq4=; b=Pghd2uwuh/TT7Zd1W4rjewO160bhWwDfkL5zjfXxB3ka/+pLplnPNtRvIp/faEfzPGYh6OWn7IjkA0xb4t9dsR9MFqhq7TOzDjnhzmyn/wNAcnfxvbU5Ql5VH89M9M9iIqgsGaylfFb14kb4xM+zzHFNaqPVr1HtYSliSepzdgE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail header.i=@quicinc.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1614877129663625.7995401685474; Thu, 4 Mar 2021 08:58:49 -0800 (PST) Received: from localhost ([::1]:60252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHrJI-0008La-IG for importer@patchew.org; Thu, 04 Mar 2021 11:58:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40470) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHrHH-0007Lr-Rh for qemu-devel@nongnu.org; Thu, 04 Mar 2021 11:56:43 -0500 Received: from alexa-out-sd-01.qualcomm.com ([199.106.114.38]:14692) by eggs.gnu.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lHrHF-0008Nh-TN for qemu-devel@nongnu.org; Thu, 04 Mar 2021 11:56:43 -0500 Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-01.qualcomm.com with ESMTP; 04 Mar 2021 08:56:38 -0800 Received: from vm-tsimpson-sd.qualcomm.com ([10.53.72.70]) by ironmsg05-sd.qualcomm.com with ESMTP; 04 Mar 2021 08:56:37 -0800 Received: by vm-tsimpson-sd.qualcomm.com (Postfix, from userid 47164) id E892D19FE; Thu, 4 Mar 2021 08:56:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1614877001; x=1646413001; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=wb6SGyUnZszCkPF9lQmtuTZiJudDthnHtYd2iNHtJiU=; b=EKELWZKyCr+35OemNMIvH0kIvAYfoiMWCxqpqyETW+VB1C4cpwgFq1TS +ArSopdSVlUH86Vud7oI0PBiXmjA6bQbpbmqjn3wc+0W61M1dzpeBr/8N fzROJ0jcKLOoPrtdf0/YtusJiK/lk6L2i89LAGStqb9U+UWINNIKmBm+4 E=; X-QCInternal: smtphost From: Taylor Simpson To: qemu-devel@nongnu.org Subject: [PATCH] Hexagon (target/hexagon) Fix shift amount check in fASHIFTL/fLSHIFTR Date: Thu, 4 Mar 2021 08:56:35 -0800 Message-Id: <1614876995-30187-1-git-send-email-tsimpson@quicinc.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=199.106.114.38; envelope-from=tsimpson@qualcomm.com; helo=alexa-out-sd-01.qualcomm.com X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ale@rev.ng, bcain@quicinc.com, peter.maydell@linaro.org, richard.henderson@linaro.org, tsimpson@quicinc.com, philmd@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Address Coverity warnings Signed-off-by: Taylor Simpson --- target/hexagon/macros.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h index 78c4efb..cfcb817 100644 --- a/target/hexagon/macros.h +++ b/target/hexagon/macros.h @@ -459,7 +459,7 @@ static inline void gen_logical_not(TCGv dest, TCGv src) : (fCAST##REGSTYPE##s(SRC) >> (SHAMT))) #define fASHIFTR(SRC, SHAMT, REGSTYPE) (fCAST##REGSTYPE##s(SRC) >> (SHAMT)) #define fLSHIFTR(SRC, SHAMT, REGSTYPE) \ - (((SHAMT) >=3D 64) ? 0 : (fCAST##REGSTYPE##u(SRC) >> (SHAMT))) + (((SHAMT) >=3D (sizeof(SRC) * 8)) ? 0 : (fCAST##REGSTYPE##u(SRC) >> (S= HAMT))) #define fROTL(SRC, SHAMT, REGSTYPE) \ (((SHAMT) =3D=3D 0) ? (SRC) : ((fCAST##REGSTYPE##u(SRC) << (SHAMT)) | \ ((fCAST##REGSTYPE##u(SRC) >> \ @@ -469,7 +469,7 @@ static inline void gen_logical_not(TCGv dest, TCGv src) ((fCAST##REGSTYPE##u(SRC) << \ ((sizeof(SRC) * 8) - (SHAMT)))))) #define fASHIFTL(SRC, SHAMT, REGSTYPE) \ - (((SHAMT) >=3D 64) ? 0 : (fCAST##REGSTYPE##s(SRC) << (SHAMT))) + (((SHAMT) >=3D (sizeof(SRC) * 8)) ? 0 : (fCAST##REGSTYPE##s(SRC) << (S= HAMT))) =20 #ifdef QEMU_GENERATE #define fLOAD(NUM, SIZE, SIGN, EA, DST) MEM_LOAD##SIZE##SIGN(DST, EA) --=20 2.7.4