From nobody Tue May 21 08:14:05 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ispras.ru ARC-Seal: i=1; a=rsa-sha256; t=1612163201; cv=none; d=zohomail.com; s=zohoarc; b=hITLgF4c7PzLGjaiOTJAjFGOY2SNWGCKD4BBtVLcVEiKw1iCv/gih6BfjfIMkaDmW7n1CW8zDydW7xy6/pEv/XUvF/PcXAXHHkFNMQvPZ/7dNAGEuzmpLTwZYUO/HvezQWIARxzmUE8st/2gZIjCJzj9Ixuplp83pVYnVD0v4dM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612163201; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=cPdfv69w7SILnQr1GNh1F3+Cfzf2gbGMjdtHSRSac4w=; b=eC0T9JCM2iQJhSmVzzkUxtODd1VwYGMXwmfZ1yvQw8oNVqZV6BwAr/tDMH376+IL7LecVxBMQfah0kbcxTR8NdUiDmNcmz3NwdOK68qhsmmsg/RqsVyU4A/TjDkxKT2NS2xhx0VSvHUNKwaLyDCsGMAgXfY1tC45XBfuQcpvAmI= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612163200756603.9990873975485; Sun, 31 Jan 2021 23:06:40 -0800 (PST) Received: from localhost ([::1]:34570 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6TIE-0003od-RW for importer@patchew.org; Mon, 01 Feb 2021 02:06:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6THH-0003MP-Ty for qemu-devel@nongnu.org; Mon, 01 Feb 2021 02:05:39 -0500 Received: from mail.ispras.ru ([83.149.199.84]:32956) by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6THD-0007Uq-5i for qemu-devel@nongnu.org; Mon, 01 Feb 2021 02:05:39 -0500 Received: from [127.0.1.1] (unknown [62.118.151.149]) by mail.ispras.ru (Postfix) with ESMTPSA id 59761407626D; Mon, 1 Feb 2021 07:05:28 +0000 (UTC) Subject: [PATCH v2] replay: fix replay of the interrupts From: Pavel Dovgalyuk To: qemu-devel@nongnu.org Date: Mon, 01 Feb 2021 10:05:27 +0300 Message-ID: <161216312794.2030770.1709657858900983160.stgit@pasha-ThinkPad-X280> User-Agent: StGit/0.23 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=83.149.199.84; envelope-from=pavel.dovgalyuk@ispras.ru; helo=mail.ispras.ru X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, pavel.dovgalyuk@ispras.ru, richard.henderson@linaro.org, f4bug@amsat.org, cfontana@suse.de, pbonzini@redhat.com, alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Sometimes interrupt event comes at the same time with the virtual timers. In this case replay tries to proceed the timers, because deadline for them is zero. This patch allows processing interrupts and exceptions by entering the vCPU execution loop, when deadline is zero, but checkpoint associated with virtual timers is not ready to be replayed. Signed-off-by: Pavel Dovgalyuk --- v2: - changed replay mode check condition --- accel/tcg/tcg-cpus-icount.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/accel/tcg/tcg-cpus-icount.c b/accel/tcg/tcg-cpus-icount.c index 9f45432275..8ed485db01 100644 --- a/accel/tcg/tcg-cpus-icount.c +++ b/accel/tcg/tcg-cpus-icount.c @@ -81,7 +81,13 @@ void icount_handle_deadline(void) int64_t deadline =3D qemu_clock_deadline_ns_all(QEMU_CLOCK_VIRTUAL, QEMU_TIMER_ATTR_ALL); =20 - if (deadline =3D=3D 0) { + /* + * Instructions, interrupts, and exceptions are processed in cpu-exec. + * Don't interrupt cpu thread, when these events are waiting + * (i.e., there is no checkpoint) + */ + if (deadline =3D=3D 0 + && (replay_mode !=3D REPLAY_MODE_PLAY || replay_has_checkpoint()))= { icount_notify_aio_contexts(); } }