From nobody Sun Feb 8 15:46:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1610506993; cv=none; d=zohomail.com; s=zohoarc; b=Z+5lyhKTlKbKPrNofubal+pfJdywjCY19kx0FWqgdbce4t8bgHxn1x15mwvs3f4w0nua0lWuG0faWFclVRTROU2R/fbJJ2uFoxYkCz+4MfCxZ7BYe5bJZNKrSJh/1nB77QjQVaB5J4IsEZ1EaBwocoIXVZ63w0C76w4QlKe79T4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610506993; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=v7iX9hJzzU8QstsyCzg2NoeLtNBBWQORX3Nc9D2E1ys=; b=KpsL5qepVsew8vOtvCpBBahczhznMMhSa4jMtnXs3VHFZ4Y44fPR0GI823ZPmQsy21hleQEvsvGLP5bKoIrMUSiq12mrLTEzgQzqpEW+El+8DIBwBRGnW3n3rWYzBC1WCnDXlimgouFKlRYN4cAHAd7IHVErUZtnCxiHCOx50rk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1610506993021592.8448383126496; Tue, 12 Jan 2021 19:03:13 -0800 (PST) Received: from localhost ([::1]:36400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzWRD-00077r-Vd for importer@patchew.org; Tue, 12 Jan 2021 22:03:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzWIE-0005z8-2b for qemu-devel@nongnu.org; Tue, 12 Jan 2021 21:53:55 -0500 Received: from mga09.intel.com ([134.134.136.24]:58694) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzWI8-0003yA-1Q for qemu-devel@nongnu.org; Tue, 12 Jan 2021 21:53:51 -0500 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2021 18:53:46 -0800 Received: from unknown (HELO localhost.localdomain.bj.intel.com) ([10.240.192.103]) by fmsmga001.fm.intel.com with ESMTP; 12 Jan 2021 18:53:44 -0800 IronPort-SDR: JfYZYjHYqmcnkCClAsKb25wvgPGiqdDWDENIKViOzsM9sVTH0i/yAFgDXPgOw2j5ZX6LSbypb3 3c84a0JpwToA== X-IronPort-AV: E=McAfee;i="6000,8403,9862"; a="178289700" X-IronPort-AV: E=Sophos;i="5.79,343,1602572400"; d="scan'208";a="178289700" IronPort-SDR: sDyrYsaZ+rckSDDiVcEMb7UnAcdGXRJ2gfa/AuPcR/IiKwR72vGd2U1YMqe7KA6gRrLApQJ5LF 3JmO+QUiKrRw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,343,1602572400"; d="scan'208";a="464750362" From: leirao To: chen.zhang@intel.com, lizhijian@cn.fujitsu.com, jasowang@redhat.com, zhang.zhanghailiang@huawei.com, quintela@redhat.com, dgilbert@redhat.com Subject: [PATCH 09/10] Add the function of colo_bitmap_clear_diry Date: Wed, 13 Jan 2021 10:46:34 +0800 Message-Id: <1610505995-144129-10-git-send-email-lei.rao@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1610505995-144129-1-git-send-email-lei.rao@intel.com> References: <1610505995-144129-1-git-send-email-lei.rao@intel.com> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=134.134.136.24; envelope-from=lei.rao@intel.com; helo=mga09.intel.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Rao, Lei" , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Rao, Lei" When we use continuous dirty memory copy for flushing ram cache on secondary VM, we can also clean up the bitmap of contiguous dirty page memory. This also can reduce the VM stop time during checkpoint. Signed-off-by: Lei Rao --- migration/ram.c | 29 +++++++++++++++++++++++++---- 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index d875e9a..0f43b79 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -839,6 +839,30 @@ unsigned long colo_bitmap_find_dirty(RAMState *rs, RAM= Block *rb, return first; } =20 +/** + * colo_bitmap_clear_dirty:when we flush ram cache to ram, we will use + * continuous memory copy, so we can also clean up the bitmap of contiguous + * dirty memory. + */ +static inline bool colo_bitmap_clear_dirty(RAMState *rs, + RAMBlock *rb, + unsigned long start, + unsigned long num) +{ + bool ret; + unsigned long i =3D 0; + + qemu_mutex_lock(&rs->bitmap_mutex); + for (i =3D 0; i < num; i++) { + ret =3D test_and_clear_bit(start + i, rb->bmap); + if (ret) { + rs->migration_dirty_pages--; + } + } + qemu_mutex_unlock(&rs->bitmap_mutex); + return ret; +} + static inline bool migration_bitmap_clear_dirty(RAMState *rs, RAMBlock *rb, unsigned long page) @@ -3406,7 +3430,6 @@ void colo_flush_ram_cache(void) void *src_host; unsigned long offset =3D 0; unsigned long num =3D 0; - unsigned long i =3D 0; =20 memory_global_dirty_log_sync(); WITH_RCU_READ_LOCK_GUARD() { @@ -3428,9 +3451,7 @@ void colo_flush_ram_cache(void) num =3D 0; block =3D QLIST_NEXT_RCU(block, next); } else { - for (i =3D 0; i < num; i++) { - migration_bitmap_clear_dirty(ram_state, block, offset = + i); - } + colo_bitmap_clear_dirty(ram_state, block, offset, num); dst_host =3D block->host + (((ram_addr_t)offset) << TARGET_PAGE_BITS); src_host =3D block->colo_cache --=20 1.8.3.1