From nobody Fri May 17 22:32:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1607632247; cv=none; d=zohomail.com; s=zohoarc; b=fuDLsKT+wljX5his3efOO36nvkdPpbzMbMUk5+ES9o2ML4Hq4Jc4RZxC1otFHhjm5AwweEf5MOK1JoeFiO8OLjUCFvqOLNjURfUYnbS9tA7NJ6DGN+qZ/jWMRB1NW3VQEY0pMRcCEX8OumRsSwtePcQEiBPb22euEgRsTmvyN74= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607632247; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=zhTW2Y9/iIzSa8KmhfRffXZEL79KuIjBgeK6zCNDMBs=; b=nEx7xHm8RV9T4sc6LK2Ba6qtDH8M2Wvb6porqGPOMVsEofAZjjYeOZAZBUwhIYeLxgLX9kM0LOg+y8kC0sXkhnshrouc4JT3pLeKF/m7gyDmQIJN4rgFKMZBDs/25Koqg8LuP6I1q9D/6AWiF8Q5N2Gf39/1d40ELXOxpBL2gnM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607632247115765.7706672779141; Thu, 10 Dec 2020 12:30:47 -0800 (PST) Received: from localhost ([::1]:34932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knOIq-0006YC-PH for importer@patchew.org; Thu, 10 Dec 2020 10:56:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58218) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knOHH-0005Zg-Ll for qemu-devel@nongnu.org; Thu, 10 Dec 2020 10:54:47 -0500 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]:39813) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1knOHE-0003bi-Mu for qemu-devel@nongnu.org; Thu, 10 Dec 2020 10:54:47 -0500 Received: by mail-pg1-x543.google.com with SMTP id f17so4583514pge.6 for ; Thu, 10 Dec 2020 07:54:44 -0800 (PST) Received: from 64-217.abest.vip ([129.227.156.197]) by smtp.gmail.com with ESMTPSA id a18sm6746074pfg.107.2020.12.10.07.54.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Dec 2020 07:54:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smartx-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=zhTW2Y9/iIzSa8KmhfRffXZEL79KuIjBgeK6zCNDMBs=; b=R1jJ9FocvxPhY9KNOLd1Jfv44r6Zfq3zV0AM1enkTQMG64dn7jazOxjDVfwZWgyIfy YT41k5raM9dpNF9d/JMvdU4nCXC/g8BrDd32i/WQ7Fq8z196JR63ReVGX80JPcEY4EH6 sL1oI+gxG5ZpYEtPV8ya+jzHd60PGo67Xw69vjpA2Hz5sIjp5F7qWpxAgVYmyjNLwNOX viGCFBWSe9RZhXYri88A+dYoQaYTV20ESIbCJR43F8z6W/EEEaRg3nsIDjUMs2ANPLTJ Lu/TS9wOwUNfPGTx5Yvt9zu8/SB/2eV8rINQC5Z3dpW/kmePBVEhy9r0KiMdaOCdjKi/ g4fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zhTW2Y9/iIzSa8KmhfRffXZEL79KuIjBgeK6zCNDMBs=; b=qqIGtjXDrat3HedaDNDaJjxUHEUp9lbal+WsOEGruhLYIcHcBLNbd/nV7eEQOCPFJN 7T5GlDQvdFSLgXkT9levaLg3sy38fTvb98uQICdxKvj6SGj8YhiT2fekInxfPBya1Pv0 ueOoyTKm1VDBTmPIj8OBj0BDsxeQIIX63BX/xd95AhAlejMQmTypBhY1G0yXpApj2QVs 8CCY++SpsBP2LYE3p8wU5AyhZXSNHBGSwIibfgyW/5syIFUNIlXrVmWzr13y5e7CW9sk dzvTuLM9CDN47yBoSR8j5Yp/8V7V8icm6jACG4poFcOJD0mMONpqyeekiykMxM1p02Su iIog== X-Gm-Message-State: AOAM5315tIrZkPz0hgN4REbMS8mnix3z9FJfLvRF5f++1Q+norzRaA0Z I0G+6bxnK/gp7ub+sFbv3ekOww== X-Google-Smtp-Source: ABdhPJzyqmzRf0n85oxfiBNQWzNz4tsBsn1/HeCfYoC190mjtzz/VVvhTzNc8rtyJ27gSgDUOzh8dA== X-Received: by 2002:aa7:828c:0:b029:19e:3acf:98a with SMTP id s12-20020aa7828c0000b029019e3acf098amr7388595pfm.54.1607615682201; Thu, 10 Dec 2020 07:54:42 -0800 (PST) From: Li Feng To: berrange@redhat.com, Kevin Wolf , Max Reitz , qemu-block@nongnu.org (open list:raw), qemu-devel@nongnu.org (open list:All patches CC here) Subject: [PATCH v2] file-posix: detect the lock using the real file Date: Thu, 10 Dec 2020 23:54:26 +0800 Message-Id: <1607615666-59588-1-git-send-email-fengli@smartx.com> X-Mailer: git-send-email 1.8.3.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=2607:f8b0:4864:20::543; envelope-from=fengli@smartx.com; helo=mail-pg1-x543.google.com X-Spam_score_int: 14 X-Spam_score: 1.4 X-Spam_bar: + X-Spam_report: (1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lifeng1519@gmail.com, Li Feng , kyle@smartx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This patch addresses this issue: When accessing a volume on an NFS filesystem without supporting the file lo= ck, tools, like qemu-img, will complain "Failed to lock byte 100". In the original code, the qemu_has_ofd_lock will test the lock on the "/dev/null" pseudo-file. Actually, the file.locking is per-drive property, which depends on the underlay filesystem. In this patch, make the 'qemu_has_ofd_lock' with a filename be more generic and reasonable. Signed-off-by: Li Feng --- v2: remove the refactoring. --- block/file-posix.c | 32 ++++++++++++++++++-------------- include/qemu/osdep.h | 2 +- tests/test-image-locking.c | 2 +- util/osdep.c | 19 ++++++++++++------- 4 files changed, 32 insertions(+), 23 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c index 806764f7e3..03be1b188c 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -595,7 +595,7 @@ static int raw_open_common(BlockDriverState *bs, QDict = *options, switch (locking) { case ON_OFF_AUTO_ON: s->use_lock =3D true; - if (!qemu_has_ofd_lock()) { + if (!qemu_has_ofd_lock(filename)) { warn_report("File lock requested but OFD locking syscall is " "unavailable, falling back to POSIX file locks"); error_printf("Due to the implementation, locks can be lost " @@ -606,7 +606,7 @@ static int raw_open_common(BlockDriverState *bs, QDict = *options, s->use_lock =3D false; break; case ON_OFF_AUTO_AUTO: - s->use_lock =3D qemu_has_ofd_lock(); + s->use_lock =3D qemu_has_ofd_lock(filename); break; default: abort(); @@ -2388,6 +2388,7 @@ raw_co_create(BlockdevCreateOptions *options, Error *= *errp) int fd; uint64_t perm, shared; int result =3D 0; + bool use_lock; =20 /* Validate options and set default values */ assert(options->driver =3D=3D BLOCKDEV_DRIVER_FILE); @@ -2428,19 +2429,22 @@ raw_co_create(BlockdevCreateOptions *options, Error= **errp) perm =3D BLK_PERM_WRITE | BLK_PERM_RESIZE; shared =3D BLK_PERM_ALL & ~BLK_PERM_RESIZE; =20 - /* Step one: Take locks */ - result =3D raw_apply_lock_bytes(NULL, fd, perm, ~shared, false, errp); - if (result < 0) { - goto out_close; - } + use_lock =3D qemu_has_ofd_lock(file_opts->filename); + if (use_lock) { + /* Step one: Take locks */ + result =3D raw_apply_lock_bytes(NULL, fd, perm, ~shared, false, er= rp); + if (result < 0) { + goto out_close; + } =20 - /* Step two: Check that nobody else has taken conflicting locks */ - result =3D raw_check_lock_bytes(fd, perm, shared, errp); - if (result < 0) { - error_append_hint(errp, - "Is another process using the image [%s]?\n", - file_opts->filename); - goto out_unlock; + /* Step two: Check that nobody else has taken conflicting locks */ + result =3D raw_check_lock_bytes(fd, perm, shared, errp); + if (result < 0) { + error_append_hint(errp, + "Is another process using the image [%s]?\n", + file_opts->filename); + goto out_unlock; + } } =20 /* Clear the file by truncating it to 0 */ diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index f9ec8c84e9..349adad465 100644 --- a/include/qemu/osdep.h +++ b/include/qemu/osdep.h @@ -512,7 +512,7 @@ int qemu_dup(int fd); int qemu_lock_fd(int fd, int64_t start, int64_t len, bool exclusive); int qemu_unlock_fd(int fd, int64_t start, int64_t len); int qemu_lock_fd_test(int fd, int64_t start, int64_t len, bool exclusive); -bool qemu_has_ofd_lock(void); +bool qemu_has_ofd_lock(const char *filename); #endif =20 #if defined(__HAIKU__) && defined(__i386__) diff --git a/tests/test-image-locking.c b/tests/test-image-locking.c index ba057bd66c..3e80246081 100644 --- a/tests/test-image-locking.c +++ b/tests/test-image-locking.c @@ -149,7 +149,7 @@ int main(int argc, char **argv) =20 g_test_init(&argc, &argv, NULL); =20 - if (qemu_has_ofd_lock()) { + if (qemu_has_ofd_lock(NULL)) { g_test_add_func("/image-locking/basic", test_image_locking_basic); g_test_add_func("/image-locking/set-perm-abort", test_set_perm_abo= rt); } diff --git a/util/osdep.c b/util/osdep.c index 66d01b9160..20119aa9ae 100644 --- a/util/osdep.c +++ b/util/osdep.c @@ -187,7 +187,7 @@ static int qemu_parse_fdset(const char *param) return qemu_parse_fd(param); } =20 -static void qemu_probe_lock_ops(void) +static void qemu_probe_lock_ops(const char *filename) { if (fcntl_op_setlk =3D=3D -1) { #ifdef F_OFD_SETLK @@ -200,10 +200,15 @@ static void qemu_probe_lock_ops(void) .l_type =3D F_WRLCK, }; =20 - fd =3D open("/dev/null", O_RDWR); + if (filename) { + fd =3D open(filename, O_RDWR); + } else { + fd =3D open("/dev/null", O_RDONLY); + } if (fd < 0) { fprintf(stderr, - "Failed to open /dev/null for OFD lock probing: %s\n", + "Failed to open %s for OFD lock probing: %s\n", + filename ? filename : "/dev/null", strerror(errno)); fcntl_op_setlk =3D F_SETLK; fcntl_op_getlk =3D F_GETLK; @@ -225,9 +230,9 @@ static void qemu_probe_lock_ops(void) } } =20 -bool qemu_has_ofd_lock(void) +bool qemu_has_ofd_lock(const char *filename) { - qemu_probe_lock_ops(); + qemu_probe_lock_ops(filename); #ifdef F_OFD_SETLK return fcntl_op_setlk =3D=3D F_OFD_SETLK; #else @@ -244,7 +249,7 @@ static int qemu_lock_fcntl(int fd, int64_t start, int64= _t len, int fl_type) .l_len =3D len, .l_type =3D fl_type, }; - qemu_probe_lock_ops(); + qemu_probe_lock_ops(NULL); do { ret =3D fcntl(fd, fcntl_op_setlk, &fl); } while (ret =3D=3D -1 && errno =3D=3D EINTR); @@ -270,7 +275,7 @@ int qemu_lock_fd_test(int fd, int64_t start, int64_t le= n, bool exclusive) .l_len =3D len, .l_type =3D exclusive ? F_WRLCK : F_RDLCK, }; - qemu_probe_lock_ops(); + qemu_probe_lock_ops(NULL); ret =3D fcntl(fd, fcntl_op_getlk, &fl); if (ret =3D=3D -1) { return -errno; --=20 2.24.3