From nobody Mon Apr 29 12:05:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606185995; cv=none; d=zohomail.com; s=zohoarc; b=Z9QYE+YYUYiJKhRHGebbT+v+iaeC6jwKszxw52aQepJQblNC34qK4psWfJEVzbw8l1QItPqr1cbbpYTJ7lMEHwTvXtUx7zenW3fPXVtZzdXwtLqQ8/23hhvqQZQ4HvAK/EWRglctcYtCJfxeiEwDhRXQFJ8g26otc5NBuDfVNMc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606185995; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=MM1KCRtmdZhv/stmi7fLoaBTZ2wgzxNLrP4QiX2B3kE=; b=WOXJ0kOSPMj/i305Qac81ZRy2IfoOwOh5/5pNO4A4Ro7FrgjJs2SMmh9mQFfL5CLCZRyRzN07Iaq9uEf6FQNduj+PxzKc9PrjHzFpaPnfspBsP6v9Ad439ibUJDY1zJv5k7mEsjt71kaWOtp2siL4zBZmM4QEWu3+DqYI0U/FSU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606185995906270.53969967752084; Mon, 23 Nov 2020 18:46:35 -0800 (PST) Received: from localhost ([::1]:39336 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khOLi-0001S1-AP for importer@patchew.org; Mon, 23 Nov 2020 21:46:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37302) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khOJn-0008GL-ES for qemu-devel@nongnu.org; Mon, 23 Nov 2020 21:44:36 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:47699) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1khOJl-00027J-6w for qemu-devel@nongnu.org; Mon, 23 Nov 2020 21:44:34 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-436-oYK2-BD_MNuX1qUPMphyHQ-1; Mon, 23 Nov 2020 21:44:29 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E8C345212; Tue, 24 Nov 2020 02:44:28 +0000 (UTC) Received: from jason-ThinkPad-T430s.redhat.com (ovpn-13-43.pek2.redhat.com [10.72.13.43]) by smtp.corp.redhat.com (Postfix) with ESMTP id 531A75D9CA; Tue, 24 Nov 2020 02:44:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606185872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type:in-reply-to:in-reply-to: references:references; bh=MM1KCRtmdZhv/stmi7fLoaBTZ2wgzxNLrP4QiX2B3kE=; b=E9XVGZeeWiuECfTACJax3F0mK3Q4Fclu1toCyxh4re1pcxKGJxT3dTCZwgDFd/vdJfEzyU RsWXk6v3NkWxQEI60tYOA7vfQGsuJ8uoTLPPOLfSGiMM3jin3upBSjux6699WzECCJ8z+t p+aqnCpludQsEdKh1dg+/YQKfnoh7QM= X-MC-Unique: oYK2-BD_MNuX1qUPMphyHQ-1 From: Jason Wang To: peter.maydell@linaro.org, qemu-devel@nongnu.org Subject: [PULL 1/5] hw/net/e1000e: advance desc_offset in case of null descriptor Date: Tue, 24 Nov 2020 10:44:19 +0800 Message-Id: <1606185863-25996-2-git-send-email-jasowang@redhat.com> In-Reply-To: <1606185863-25996-1-git-send-email-jasowang@redhat.com> References: <1606185863-25996-1-git-send-email-jasowang@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , Prasad J Pandit Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Prasad J Pandit While receiving packets via e1000e_write_packet_to_guest() routine, 'desc_offset' is advanced only when RX descriptor is processed. And RX descriptor is not processed if it has NULL buffer address. This may lead to an infinite loop condition. Increament 'desc_offset' to process next descriptor in the ring to avoid infinite loop. Reported-by: Cheol-woo Myung <330cjfdn@gmail.com> Signed-off-by: Prasad J Pandit Signed-off-by: Jason Wang --- hw/net/e1000e_core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index d8b9e4b..095c01e 100644 --- a/hw/net/e1000e_core.c +++ b/hw/net/e1000e_core.c @@ -1596,13 +1596,13 @@ e1000e_write_packet_to_guest(E1000ECore *core, stru= ct NetRxPkt *pkt, (const char *) &fcs_pad, e1000x_fcs_len(core->ma= c)); } } - desc_offset +=3D desc_size; - if (desc_offset >=3D total_size) { - is_last =3D true; - } } else { /* as per intel docs; skip descriptors with null buf addr= */ trace_e1000e_rx_null_descriptor(); } + desc_offset +=3D desc_size; + if (desc_offset >=3D total_size) { + is_last =3D true; + } =20 e1000e_write_rx_descr(core, desc, is_last ? core->rx_pkt : NULL, rss_info, do_ps ? ps_hdr_len : 0, &bastate.writ= ten); --=20 2.7.4 From nobody Mon Apr 29 12:05:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606186012; cv=none; d=zohomail.com; s=zohoarc; b=XXunQFo8d1KBm+Tq0SIgZm4Kth4i9+O/f5qnwuCKbZPoulX63TVBhGQ3vUgp2I0o9P2+JCkIvGQtL5ldIO7QoeJ5xp4Nw1RBWZfyS5UBGvlfsqKFFAKx5j942ahxAr03egKPdpGCKZZyBvEJurPt3j82OpCH1GPMWqvqXgponEc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606186012; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=Dj6qND8KUHYnGns/ra46a7m3rapbWc3KQkUtUfQE218=; b=PI4dfC+qOyqqHi8m8My5EDAcqI/nlJ6kZuRiWkoW1KM626h2q06ZjybM5p4+SFhHTYfkwoDbcktN0HwObzNs1tW1er/lROsthlnw/i2ovfQZSlSwutFHajXjcvGbEbreMOr27U4C1cQZ3Ea5tL3Z/oYICrxm6G7Qbm7nejLIE9k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606186012538688.8981152348956; Mon, 23 Nov 2020 18:46:52 -0800 (PST) Received: from localhost ([::1]:39594 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khOLy-0001YU-Qk for importer@patchew.org; Mon, 23 Nov 2020 21:46:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37332) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khOJr-0008Hs-5n for qemu-devel@nongnu.org; Mon, 23 Nov 2020 21:44:39 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:51935) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1khOJp-000281-6n for qemu-devel@nongnu.org; Mon, 23 Nov 2020 21:44:38 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-196-h2eeXb1_NhWsx0w0H5i0XA-1; Mon, 23 Nov 2020 21:44:32 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 32DA81007461; Tue, 24 Nov 2020 02:44:31 +0000 (UTC) Received: from jason-ThinkPad-T430s.redhat.com (ovpn-13-43.pek2.redhat.com [10.72.13.43]) by smtp.corp.redhat.com (Postfix) with ESMTP id 735F45D9CA; Tue, 24 Nov 2020 02:44:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606185876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type:in-reply-to:in-reply-to: references:references; bh=Dj6qND8KUHYnGns/ra46a7m3rapbWc3KQkUtUfQE218=; b=C7pe7FYhzRhlqZi6+utZ1TbCzh7KSJQ3hQeekwDvsAvQ8ANWVG2WjWwixxYYlahO/o2/9g NUekGZZkWvndeEJxf1OJzoFslM2wEOxDNKOPSX4tYeCdwddvCwWFOg4HX+2UP/5py67Snl sJAYsrwCGp/OL+00S1TXin2CZo8/TMU= X-MC-Unique: h2eeXb1_NhWsx0w0H5i0XA-1 From: Jason Wang To: peter.maydell@linaro.org, qemu-devel@nongnu.org Subject: [PULL 2/5] net: do not exit on "netdev_add help" monitor command Date: Tue, 24 Nov 2020 10:44:20 +0800 Message-Id: <1606185863-25996-3-git-send-email-jasowang@redhat.com> In-Reply-To: <1606185863-25996-1-git-send-email-jasowang@redhat.com> References: <1606185863-25996-1-git-send-email-jasowang@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Jason Wang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Paolo Bonzini "netdev_add help" is causing QEMU to exit because the code that invokes show_netdevs is shared between CLI and HMP processing. Move the check to the callers so that exit(0) remains only in the CLI flow. "netdev_add help" is not fixed by this patch; that is left for later work. Signed-off-by: Paolo Bonzini Signed-off-by: Jason Wang --- include/net/net.h | 1 + monitor/hmp-cmds.c | 6 +++++ net/net.c | 68 +++++++++++++++++++++++++++-----------------------= ---- 3 files changed, 41 insertions(+), 34 deletions(-) diff --git a/include/net/net.h b/include/net/net.h index 897b2d7..778fc78 100644 --- a/include/net/net.h +++ b/include/net/net.h @@ -199,6 +199,7 @@ extern const char *host_net_devices[]; =20 /* from net.c */ int net_client_parse(QemuOptsList *opts_list, const char *str); +void show_netdevs(void); int net_init_clients(Error **errp); void net_check_clients(void); void net_cleanup(void); diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index a6a6684..65d8ff4 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -24,6 +24,7 @@ #include "qemu/option.h" #include "qemu/timer.h" #include "qemu/sockets.h" +#include "qemu/help_option.h" #include "monitor/monitor-internal.h" #include "qapi/error.h" #include "qapi/clone-visitor.h" @@ -1631,7 +1632,12 @@ void hmp_netdev_add(Monitor *mon, const QDict *qdict) { Error *err =3D NULL; QemuOpts *opts; + const char *type =3D qdict_get_try_str(qdict, "type"); =20 + if (type && is_help_option(type)) { + show_netdevs(); + return; + } opts =3D qemu_opts_from_qdict(qemu_find_opts("netdev"), qdict, &err); if (err) { goto out; diff --git a/net/net.c b/net/net.c index 794c652..6362d30 100644 --- a/net/net.c +++ b/net/net.c @@ -44,6 +44,7 @@ #include "qemu/config-file.h" #include "qemu/ctype.h" #include "qemu/iov.h" +#include "qemu/qemu-print.h" #include "qemu/main-loop.h" #include "qemu/option.h" #include "qapi/error.h" @@ -1025,7 +1026,7 @@ static int net_client_init1(const Netdev *netdev, boo= l is_netdev, Error **errp) return 0; } =20 -static void show_netdevs(void) +void show_netdevs(void) { int idx; const char *available_netdevs[] =3D { @@ -1055,9 +1056,9 @@ static void show_netdevs(void) #endif }; =20 - printf("Available netdev backend types:\n"); + qemu_printf("Available netdev backend types:\n"); for (idx =3D 0; idx < ARRAY_SIZE(available_netdevs); idx++) { - puts(available_netdevs[idx]); + qemu_printf("%s\n", available_netdevs[idx]); } } =20 @@ -1068,42 +1069,35 @@ static int net_client_init(QemuOpts *opts, bool is_= netdev, Error **errp) int ret =3D -1; Visitor *v =3D opts_visitor_new(opts); =20 - const char *type =3D qemu_opt_get(opts, "type"); - - if (is_netdev && type && is_help_option(type)) { - show_netdevs(); - exit(0); - } else { - /* Parse convenience option format ip6-net=3Dfec0::0[/64] */ - const char *ip6_net =3D qemu_opt_get(opts, "ipv6-net"); + /* Parse convenience option format ip6-net=3Dfec0::0[/64] */ + const char *ip6_net =3D qemu_opt_get(opts, "ipv6-net"); =20 - if (ip6_net) { - char *prefix_addr; - unsigned long prefix_len =3D 64; /* Default 64bit prefix lengt= h. */ + if (ip6_net) { + char *prefix_addr; + unsigned long prefix_len =3D 64; /* Default 64bit prefix length. */ =20 - substrings =3D g_strsplit(ip6_net, "/", 2); - if (!substrings || !substrings[0]) { - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "ipv6-net", - "a valid IPv6 prefix"); - goto out; - } + substrings =3D g_strsplit(ip6_net, "/", 2); + if (!substrings || !substrings[0]) { + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "ipv6-net", + "a valid IPv6 prefix"); + goto out; + } =20 - prefix_addr =3D substrings[0]; + prefix_addr =3D substrings[0]; =20 - /* Handle user-specified prefix length. */ - if (substrings[1] && - qemu_strtoul(substrings[1], NULL, 10, &prefix_len)) - { - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, - "ipv6-prefixlen", "a number"); - goto out; - } - - qemu_opt_set(opts, "ipv6-prefix", prefix_addr, &error_abort); - qemu_opt_set_number(opts, "ipv6-prefixlen", prefix_len, - &error_abort); - qemu_opt_unset(opts, "ipv6-net"); + /* Handle user-specified prefix length. */ + if (substrings[1] && + qemu_strtoul(substrings[1], NULL, 10, &prefix_len)) + { + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, + "ipv6-prefixlen", "a number"); + goto out; } + + qemu_opt_set(opts, "ipv6-prefix", prefix_addr, &error_abort); + qemu_opt_set_number(opts, "ipv6-prefixlen", prefix_len, + &error_abort); + qemu_opt_unset(opts, "ipv6-net"); } =20 /* Create an ID for -net if the user did not specify one */ @@ -1421,6 +1415,12 @@ static int net_init_client(void *dummy, QemuOpts *op= ts, Error **errp) =20 static int net_init_netdev(void *dummy, QemuOpts *opts, Error **errp) { + const char *type =3D qemu_opt_get(opts, "type"); + + if (type && is_help_option(type)) { + show_netdevs(); + exit(0); + } return net_client_init(opts, true, errp); } =20 --=20 2.7.4 From nobody Mon Apr 29 12:05:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606186126; cv=none; d=zohomail.com; s=zohoarc; b=QS7WAjr0Yn68OdR/ncTPEjtHvnPUQInNJNpeghS9JrcG1ycRfVoCUQRmAPYgD4OV/7Rj+KMcPHI0NWv+xdRdpqR22pq8N6zKKX3nfrvQxMexKMlFWL2wesz5MtUb6acVUq05E0gD8mal7rzLt0DvH1tY8NNa3XaCbblBC/Lq1bA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606186126; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=TqgxUaXyEV8ciQ2FOlVVvP861BSBMhvXtjEUk93f3EM=; b=kjVlz/GQVr1nzarQgtbPsaJO3TEp6fL+dfg3/kjWqRSMxN8o8O3A83pgbKSqDVGr9ZBSA6CUa4IcciQpxahmQ9K7eGBFVc4BxZmkF09yCv4tGAcKIK+GR0uAL2MdDGjgljqwBDyUweOer1034lP4P6RBDq9lTi8Wqa1eJHrrLD0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606186126315738.1950795422383; Mon, 23 Nov 2020 18:48:46 -0800 (PST) Received: from localhost ([::1]:44806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khONp-0003j1-8K for importer@patchew.org; Mon, 23 Nov 2020 21:48:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37344) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khOJs-0008I2-KL for qemu-devel@nongnu.org; Mon, 23 Nov 2020 21:44:40 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:60053) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1khOJp-000286-Qd for qemu-devel@nongnu.org; Mon, 23 Nov 2020 21:44:40 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-72-ONs6ZSMFONOdxu9Rdj2WoQ-1; Mon, 23 Nov 2020 21:44:34 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5BD73107AFA5; Tue, 24 Nov 2020 02:44:33 +0000 (UTC) Received: from jason-ThinkPad-T430s.redhat.com (ovpn-13-43.pek2.redhat.com [10.72.13.43]) by smtp.corp.redhat.com (Postfix) with ESMTP id B5D4A5D9CA; Tue, 24 Nov 2020 02:44:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606185876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type:in-reply-to:in-reply-to: references:references; bh=TqgxUaXyEV8ciQ2FOlVVvP861BSBMhvXtjEUk93f3EM=; b=CZMI4ivkBMHTu6++DhlomBNy2te5NQqTEGVoc2KSG1WSjAhW5CLH7tBZqjtWNpncbCSctr agfPlPxzCnipxNWl8HmdaFPMz4Kmf/01YwAJ6Ff7AmjWqxCWvrZP71JDpC6f/EhO8WEkJg OsGaJWQrhpA4nruL7GApTt7VA6r+Gtw= X-MC-Unique: ONs6ZSMFONOdxu9Rdj2WoQ-1 From: Jason Wang To: peter.maydell@linaro.org, qemu-devel@nongnu.org Subject: [PULL 3/5] net: purge queued rx packets on queue deletion Date: Tue, 24 Nov 2020 10:44:21 +0800 Message-Id: <1606185863-25996-4-git-send-email-jasowang@redhat.com> In-Reply-To: <1606185863-25996-1-git-send-email-jasowang@redhat.com> References: <1606185863-25996-1-git-send-email-jasowang@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yuri Benditovich , Jason Wang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Yuri Benditovich https://bugzilla.redhat.com/show_bug.cgi?id=3D1829272 When deleting queue pair, purge pending RX packets if any. Example of problematic flow: 1. Bring up q35 VM with tap (vhost off) and virtio-net or e1000e 2. Run ping flood to the VM NIC ( 1 ms interval) 3. Hot unplug the NIC device (device_del) During unplug process one or more packets come, the NIC can't receive, tap disables read_poll 4. Hot plug the device (device_add) with the same netdev The tap stays with read_poll disabled and does not receive any packets anymore (tap_send never triggered) Signed-off-by: Yuri Benditovich Signed-off-by: Jason Wang --- net/net.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/net/net.c b/net/net.c index 6362d30..6a2c3d9 100644 --- a/net/net.c +++ b/net/net.c @@ -412,10 +412,14 @@ void qemu_del_nic(NICState *nic) =20 qemu_macaddr_set_free(&nic->conf->macaddr); =20 - /* If this is a peer NIC and peer has already been deleted, free it no= w. */ - if (nic->peer_deleted) { - for (i =3D 0; i < queues; i++) { - qemu_free_net_client(qemu_get_subqueue(nic, i)->peer); + for (i =3D 0; i < queues; i++) { + NetClientState *nc =3D qemu_get_subqueue(nic, i); + /* If this is a peer NIC and peer has already been deleted, free i= t now. */ + if (nic->peer_deleted) { + qemu_free_net_client(nc->peer); + } else if (nc->peer) { + /* if there are RX packets pending, complete them */ + qemu_purge_queued_packets(nc->peer); } } =20 --=20 2.7.4 From nobody Mon Apr 29 12:05:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606186258; cv=none; d=zohomail.com; s=zohoarc; b=FEJmng4PvJBo18drkEDwOy+E2yxNdO6UCbr/JSUh6a63OriUs6MSpIzQe679cJGRaqEx02U67YembzkFlisehUiErR/JAguwSHbN0XQ6gekGbWD5yYTp4+yE8EpNthCWLEauA2tWLohERp34s3HgenUP11Rfg2sefB1uIrqPH+Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606186258; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=pMeXkB1AB/xl4g4gJSc84NMewiDMIKOU1AYZLOAF3V4=; b=g7m38R3E8aO+mcQcYpI+gspU5OK1iPxfWAnsGlFjh9jx3y7aboLUU82Bs2McP+J03CnNWUN9kY9thqs4P4zPMNWUUpCH3mGZHuWOsBp5dIFHw9/8r6OBaOBI0R7AfzyCKzhExBh41px0J0v8Gh+qG9pIEZE1C2VtRrvOJHUFsL4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606186258444777.3110754055534; Mon, 23 Nov 2020 18:50:58 -0800 (PST) Received: from localhost ([::1]:48060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khOPx-00059b-5m for importer@patchew.org; Mon, 23 Nov 2020 21:50:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37368) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khOJw-0008Kb-0K for qemu-devel@nongnu.org; Mon, 23 Nov 2020 21:44:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:54643) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1khOJu-000295-EU for qemu-devel@nongnu.org; Mon, 23 Nov 2020 21:44:43 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-158-BR_7kRyAOjqxHdSKgdg2tQ-1; Mon, 23 Nov 2020 21:44:37 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 80674805BE0; Tue, 24 Nov 2020 02:44:35 +0000 (UTC) Received: from jason-ThinkPad-T430s.redhat.com (ovpn-13-43.pek2.redhat.com [10.72.13.43]) by smtp.corp.redhat.com (Postfix) with ESMTP id DFA7B5D9CA; Tue, 24 Nov 2020 02:44:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606185881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type:in-reply-to:in-reply-to: references:references; bh=pMeXkB1AB/xl4g4gJSc84NMewiDMIKOU1AYZLOAF3V4=; b=hlJU9eLKVnfHvwlQZGesEbhpLXl4uWX+cixS8j0Xib3SCKwetFvtL8dYgaKR2kBy3AyIex hdi7t3czdgmo2P7Zf5ZmKr7NOg3cRbkz1rlH3wBsVQ6NvzuDOth76Oc8oO8fHhp/Hk5EVb f/i6xMnyBDnJUC5zJ9GezC2P+HAtH7Q= X-MC-Unique: BR_7kRyAOjqxHdSKgdg2tQ-1 From: Jason Wang To: peter.maydell@linaro.org, qemu-devel@nongnu.org Subject: [PULL 4/5] tap: fix a memory leak Date: Tue, 24 Nov 2020 10:44:22 +0800 Message-Id: <1606185863-25996-5-git-send-email-jasowang@redhat.com> In-Reply-To: <1606185863-25996-1-git-send-email-jasowang@redhat.com> References: <1606185863-25996-1-git-send-email-jasowang@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yuanjungong , Jason Wang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: yuanjungong Close fd before returning. Buglink: https://bugs.launchpad.net/qemu/+bug/1904486 Signed-off-by: yuanjungong Reviewed-by: Peter Maydell Signed-off-by: Jason Wang --- net/tap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/tap.c b/net/tap.c index c46ff66..fe95fa7 100644 --- a/net/tap.c +++ b/net/tap.c @@ -817,6 +817,7 @@ int net_init_tap(const Netdev *netdev, const char *name, if (ret < 0) { error_setg_errno(errp, -ret, "%s: Can't use file descriptor %d= ", name, fd); + close(fd); return -1; } =20 @@ -831,6 +832,7 @@ int net_init_tap(const Netdev *netdev, const char *name, vhostfdname, vnet_hdr, fd, &err); if (err) { error_propagate(errp, err); + close(fd); return -1; } } else if (tap->has_fds) { --=20 2.7.4 From nobody Mon Apr 29 12:05:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606186124; cv=none; d=zohomail.com; s=zohoarc; b=SyjAAw9L1/Xo8OxIvnEYBnmL0hXFDjs6RE5Ay9SclhNMpI4nQZ6VBzGtIM3z/csJbrOFBIYqI2lU85Qralpbt7U5CVhjAzMKiSHOpxES/yfaHu/p6M1aSb649KM1zt9CRXcYmECYviUljy5qKsDXLtoUNm3T6f99FDc1ZiIr+A0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606186124; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=ABx0p2qmAGxG+XfxGy7HrResy/wTlAIDE6SIuSRFQPY=; b=d2luLLhHIpvjt9/l3GBQLADy1+5R37RTSHxhZgapUdp/By9fq35LT8Tb0cltswd/b7WBUQrd5LR7d7iNtwMPyjJoQCKZsRaW83XfKXZ+fRHln2yGB0OqXvY9+MSRXqAqTFvZ3pXu2gZs+ESMe3VC87oVTf+Cq25t+zEq6tET4Jk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606186124649224.22642031251723; Mon, 23 Nov 2020 18:48:44 -0800 (PST) Received: from localhost ([::1]:44724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khONn-0003gv-Ks for importer@patchew.org; Mon, 23 Nov 2020 21:48:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37386) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khOJx-0008NF-Fo for qemu-devel@nongnu.org; Mon, 23 Nov 2020 21:44:45 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:41435) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1khOJv-00029V-S6 for qemu-devel@nongnu.org; Mon, 23 Nov 2020 21:44:45 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-568-791gNTF_NCugf9wUyYmy0w-1; Mon, 23 Nov 2020 21:44:38 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9F46B8049CF; Tue, 24 Nov 2020 02:44:37 +0000 (UTC) Received: from jason-ThinkPad-T430s.redhat.com (ovpn-13-43.pek2.redhat.com [10.72.13.43]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0AF285D9CC; Tue, 24 Nov 2020 02:44:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606185883; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type:in-reply-to:in-reply-to: references:references; bh=ABx0p2qmAGxG+XfxGy7HrResy/wTlAIDE6SIuSRFQPY=; b=TeJ6o1KJhsTng1YUUqbT9uqNr1/B9vQhuUwFKIWfQp6LL1BBi9IIEkik3lgfdefNyOxLSu 0w0pycLK6Tj+LmEi5INCnaMBxD8ty3yI8GCM7KcATzxuGEHjSvZVvNO09c7bdhY2va1PWb brWKcW/z1/AAe9EZK21WfwmxXG434aE= X-MC-Unique: 791gNTF_NCugf9wUyYmy0w-1 From: Jason Wang To: peter.maydell@linaro.org, qemu-devel@nongnu.org Subject: [PULL 5/5] net: Use correct default-path macro for downscript Date: Tue, 24 Nov 2020 10:44:23 +0800 Message-Id: <1606185863-25996-6-git-send-email-jasowang@redhat.com> In-Reply-To: <1606185863-25996-1-git-send-email-jasowang@redhat.com> References: <1606185863-25996-1-git-send-email-jasowang@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , Keqian Zhu Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Keqian Zhu Fixes: 63c4db4c2e6d (net: relocate paths to helpers and scripts) Signed-off-by: Keqian Zhu Signed-off-by: Jason Wang --- net/tap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/tap.c b/net/tap.c index fe95fa7..b751285 100644 --- a/net/tap.c +++ b/net/tap.c @@ -953,7 +953,8 @@ free_fail: script =3D default_script =3D get_relocated_path(DEFAULT_NETWO= RK_SCRIPT); } if (!downscript) { - downscript =3D default_downscript =3D get_relocated_path(DEFAU= LT_NETWORK_SCRIPT); + downscript =3D default_downscript =3D + get_relocated_path(DEFAULT_NETWORK_DOWN_S= CRIPT); } =20 if (tap->has_ifname) { --=20 2.7.4