From nobody Mon May 6 15:27:52 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605222513; cv=none; d=zohomail.com; s=zohoarc; b=ebCXJiwh3PCOfkUlesoNkzUaBxmxNsZL5YqRa2dvnfeFuioLFo2xnuwvkZWMdywJUUEYZi4sMTARRhUw9YE0uZQxUqpBWDd5x4ZaRU07qg1RDcsh+SYVlTDFwuBacItPfzPS63Xqd++f5eIvOOKtjJh/fpq1/VjHLPlNsvCrnl0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605222513; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xEZzBoUQ7qGKkcK1oxsvTD2HQhsJctzm4yku9y5OCAw=; b=llONbC6EVWDIRVJFlMQZvXmY9fV9IPZcJMAqZj4u6hAqNJiSOcb88UJ398FkD+Yq4MJA3w3C9vKH/4jUSlsbgByNfFs+Gtr3b7LkgSPWRqHFtA82Gxila6ryKj0mjQlyHyuYTwUfotJQoZdgxDJxgQOvEbKSq1DsOpqSpR7ZOT0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605222513289142.57728107803223; Thu, 12 Nov 2020 15:08:33 -0800 (PST) Received: from localhost ([::1]:38212 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdLhg-0000Q0-2k for importer@patchew.org; Thu, 12 Nov 2020 18:08:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdLfr-0007RC-VR for qemu-devel@nongnu.org; Thu, 12 Nov 2020 18:06:39 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:49134) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kdLfq-0005Xd-Ca for qemu-devel@nongnu.org; Thu, 12 Nov 2020 18:06:39 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-471-1AVAtIsbOdWLy90BOg1Cig-1; Thu, 12 Nov 2020 18:06:31 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9FE2F192AB60; Thu, 12 Nov 2020 23:06:30 +0000 (UTC) Received: from gimli.home (ovpn-112-213.phx2.redhat.com [10.3.112.213]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0122E6EF50; Thu, 12 Nov 2020 23:06:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605222394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xEZzBoUQ7qGKkcK1oxsvTD2HQhsJctzm4yku9y5OCAw=; b=gV4wuBgqX2MZght87p2QZ50Rb4fV1p6pzlMBvaP5eCXNAAzOxDmQ6QqhDt3rEQeiOfn4lY KDGO+q557z6Zx+zMQZ3C9Rd1gbxXHUGdtJnyljjzQILb97Nk8rsz8Dw8rywXwF4ihfByu/ BT8H3DxHXL1cNbP7OHG5XQtMDepjfEc= X-MC-Unique: 1AVAtIsbOdWLy90BOg1Cig-1 Subject: [PULL 1/1] Fix use after free in vfio_migration_probe From: Alex Williamson To: qemu-devel@nongnu.org Date: Thu, 12 Nov 2020 16:06:26 -0700 Message-ID: <160522236242.22563.14708258644629839877.stgit@gimli.home> In-Reply-To: <160522223115.22563.1877553897618141184.stgit@gimli.home> References: <160522223115.22563.1877553897618141184.stgit@gimli.home> User-Agent: StGit/0.21-dirty MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=alex.williamson@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=alex.williamson@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/12 08:00:44 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Philippe =?utf-8?q?Mathieu-Daud=C3=A9?= , Kirti Wankhede , Alex =?utf-8?q?Benn=C3=A9e?= , David Edmondson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Kirti Wankhede Fixes Coverity issue: CID 1436126: Memory - illegal accesses (USE_AFTER_FREE) Fixes: a9e271ec9b36 ("vfio: Add migration region initialization and finaliz= e function") Signed-off-by: Kirti Wankhede Reviewed-by: David Edmondson Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Alex Williamson --- hw/vfio/migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c index 3ce285ea395d..55261562d4f3 100644 --- a/hw/vfio/migration.c +++ b/hw/vfio/migration.c @@ -897,8 +897,8 @@ int vfio_migration_probe(VFIODevice *vbasedev, Error **= errp) goto add_blocker; } =20 - g_free(info); trace_vfio_migration_probe(vbasedev->name, info->index); + g_free(info); return 0; =20 add_blocker: