From nobody Mon Nov 17 17:53:07 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1605103919; cv=none; d=zohomail.com; s=zohoarc; b=lOYj0iB8qUaoL7z6IEcWxkjENu+0u9Kp0YxB9JaIGQBGx3TIEH6XM/0jGGC3+pouTHw1howFznPZsEIKWeNmwirTXJZN0f+vbrudfcijbq3BJUhd+H/onru0DP8rqTVVelgVjpqHcyvYEC9gmYyTJ2dt12it+67SAOh3CqzFHOs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605103919; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=lBZ/MB/QtZMhWs0J2L/dZowHGIX3u5Xem9bSWBRbzME=; b=BsUkc4ihpwG5qq9wB45m47uiCsNdpPoU3Y55+UT/GAabVSIInMcFW59LFIFOir2RmRS1Jj1sbXylYjNkEHqyQ3UoqrxfZG36d8uXSGZ+bR524EhEiLtC6Mt0IuQDBeK56SCWgCzwpHgHQdKH5St2MYNAq1BnqWMOynfiRYb0Ycc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605103918899774.9917361329614; Wed, 11 Nov 2020 06:11:58 -0800 (PST) Received: from localhost ([::1]:53398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcqqr-0000YP-8y for importer@patchew.org; Wed, 11 Nov 2020 09:11:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58678) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcqpp-00005B-0A for qemu-devel@nongnu.org; Wed, 11 Nov 2020 09:10:53 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2410) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcqpl-0004wG-1C for qemu-devel@nongnu.org; Wed, 11 Nov 2020 09:10:52 -0500 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CWRTJ3gLmz15MFT; Wed, 11 Nov 2020 22:10:28 +0800 (CST) Received: from huawei.com (10.175.101.6) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.487.0; Wed, 11 Nov 2020 22:10:29 +0800 From: Chuan Zheng To: , , Subject: [PATCH v2] multifd/tls: fix memoryleak of the QIOChannelSocket object when cancelling migration Date: Wed, 11 Nov 2020 22:26:03 +0800 Message-ID: <1605104763-118687-1-git-send-email-zhengchuan@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.101.6] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=zhengchuan@huawei.com; helo=szxga04-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/11 07:50:46 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yubihong@huawei.com, zhang.zhanghailiang@huawei.com, qemu-devel@nongnu.org, xiexiangyou@huawei.com, alex.chen@huawei.com, wanghao232@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" When creating new tls client, the tioc->master will be referenced which res= ults in socket leaking after multifd_save_cleanup if we cancel migration. Fix it by do object_unref() after tls client creation. Suggested-by: Daniel P. Berrang=C3=A9 Signed-off-by: Chuan Zheng Reviewed-by: Daniel P. Berrang=C3=A9 --- migration/multifd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/multifd.c b/migration/multifd.c index 68b171f..6992761 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -752,6 +752,7 @@ static void multifd_tls_channel_connect(MultiFDSendPara= ms *p, return; } =20 + object_unref(OBJECT(ioc)); trace_multifd_tls_outgoing_handshake_start(ioc, tioc, hostname); qio_channel_set_name(QIO_CHANNEL(tioc), "multifd-tls-outgoing"); qio_channel_tls_handshake(tioc, --=20 1.8.3.1