From nobody Mon Nov 17 15:41:07 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1605078010; cv=none; d=zohomail.com; s=zohoarc; b=mgMQfaZL9gvJQk1GlQUO64061kJJL1dydv18iRYDEGhuohlaKOXbrY/fuRgt+prLFLdaIg05gIWIyXBnPkzoSOO4E0IMPX5L3LxSXG4HCd2N9Geb5IYUEvouZqjTzr91RmC7IdDr0DJ8u+orcEVBWj4zQ2u4I4JH+XIWuy1uU6Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605078010; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=VKrvi9yfquRZZ4V1L8wuqpn3efwT4qbcE+49hfF2TIw=; b=ccYZNbr+W8688e0VUjhJIgwOxEUwBn/Y2aDjPvakpP4ex7UneDBqNOaejuNw4tcV58HW0ylvH5XO7/eBJnK0z37FFbDHz+sJoQ61sMl5xyCoTF5fXRbL42K7e1pRclZNoJgMEsp/vJHbZFz40BnwFZB8UUSrZUK51K8ogdHAlGE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605078010587688.0827514212151; Tue, 10 Nov 2020 23:00:10 -0800 (PST) Received: from localhost ([::1]:50144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kck6z-00038n-EI for importer@patchew.org; Wed, 11 Nov 2020 02:00:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kck5s-0002gz-Jo for qemu-devel@nongnu.org; Wed, 11 Nov 2020 01:59:00 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:2140) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kck5q-00074U-Og for qemu-devel@nongnu.org; Wed, 11 Nov 2020 01:59:00 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4CWFvB6TGYz75VB; Wed, 11 Nov 2020 14:58:46 +0800 (CST) Received: from huawei.com (10.175.101.6) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Wed, 11 Nov 2020 14:58:45 +0800 From: Chuan Zheng To: , , Subject: [RESEND][PATCH] multifd/tls: fix memoryleak of the QIOChannelSocket object when canceling migration Date: Wed, 11 Nov 2020 15:14:18 +0800 Message-ID: <1605078858-114607-1-git-send-email-zhengchuan@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.175.101.6] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.35; envelope-from=zhengchuan@huawei.com; helo=szxga07-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/11 01:53:36 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yubihong@huawei.com, zhang.zhanghailiang@huawei.com, qemu-devel@nongnu.org, xiexiangyou@huawei.com, alex.chen@huawei.com, wanghao232@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When creating new tls client, the tioc->master will be referenced, we need = dereferenced it after tls handshake. Signed-off-by: Chuan Zheng --- migration/multifd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/migration/multifd.c b/migration/multifd.c index 68b171f..df76a8e 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -728,7 +728,8 @@ static void multifd_tls_outgoing_handshake(QIOTask *tas= k, gpointer opaque) { MultiFDSendParams *p =3D opaque; - QIOChannel *ioc =3D QIO_CHANNEL(qio_task_get_source(task)); + QIOChannelTLS *tioc =3D QIO_CHANNEL_TLS(qio_task_get_source(task)); + QIOChannel *ioc =3D QIO_CHANNEL(tioc); Error *err =3D NULL; =20 if (qio_task_propagate_error(task, &err)) { @@ -737,6 +738,7 @@ static void multifd_tls_outgoing_handshake(QIOTask *tas= k, trace_multifd_tls_outgoing_handshake_complete(ioc); } multifd_channel_connect(p, ioc, err); + object_unref(OBJECT(tioc->master)); } =20 static void multifd_tls_channel_connect(MultiFDSendParams *p, --=20 1.8.3.1