From nobody Sun Nov 16 14:00:36 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1600768009; cv=none; d=zohomail.com; s=zohoarc; b=deYihiN3g7cxAOmSELLepkNaqi/mtPPZSva6Cgq8sakBbq5fcgfhP/QQKb9O0aO2P4UIKj4ywfDPCcOtT6UXJvQcnnr1J3e+k9EdVvWKE2O4b6ZXHEwR/e6fLD9VvFJIUYLkxXy7FKJ9yXmQMqBPy87K017JkmlTZsWkvmhxeYQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600768009; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=K3ZjbmtB8u4hZVhMijqlKgV0Q7c725hBKJ9SEow0JJw=; b=XgvnMy9Seqln6+PUw+MBXUsPn+roPh+WxJX2dLjre3rdgrACr0f8dKOO4oIfAo5IQW7bktXuxMQqR5te9aRNN/Q0XxDsvie2sjaVEf+9zj2h6cKCXUfV0e1AvYN4ijSVGVTg+tBqQfFblnucxAIdlLpKF29Mped9PSOYFdvvtyM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1600768009753182.7530478796508; Tue, 22 Sep 2020 02:46:49 -0700 (PDT) Received: from localhost ([::1]:48740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKesq-0004BJ-FR for importer@patchew.org; Tue, 22 Sep 2020 05:46:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKeoh-0008Av-FC for qemu-devel@nongnu.org; Tue, 22 Sep 2020 05:42:31 -0400 Received: from mga11.intel.com ([192.55.52.93]:64260) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKeof-0008QL-MP for qemu-devel@nongnu.org; Tue, 22 Sep 2020 05:42:31 -0400 Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2020 02:42:28 -0700 Received: from unknown (HELO localhost.localdomain.bj.intel.com) ([10.240.192.103]) by orsmga007.jf.intel.com with ESMTP; 22 Sep 2020 02:42:26 -0700 IronPort-SDR: BxImpKJwBpOIYeRSJEb9WZ4C+2ur3/45eXzaBsic6ahvfxHw0waCuNnmKmoIXYusl+pRl9T5jT 75RHSCm5uOFg== X-IronPort-AV: E=McAfee;i="6000,8403,9751"; a="157947015" X-IronPort-AV: E=Sophos;i="5.77,290,1596524400"; d="scan'208";a="157947015" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False IronPort-SDR: oH53HOW+Tg2JO2wYxA107xA81KstdBLDGU/HgV4bKh1CIi53UTNq8EIfJNh+08wEkPALNXS4Tj CHNzswQE6f6w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,290,1596524400"; d="scan'208";a="348424046" From: leirao To: chen.zhang@intel.com, lizhijian@cn.fujitsu.com, jasowang@redhat.com, quintela@redhat.com, dgilbert@redhat.com, pbonzini@redhat.com Subject: [PATCH v2 3/3] Fix the qemu crash when guest shutdown in COLO mode Date: Tue, 22 Sep 2020 05:24:50 -0400 Message-Id: <1600766690-94980-4-git-send-email-lei.rao@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1600766690-94980-1-git-send-email-lei.rao@intel.com> References: <1600766690-94980-1-git-send-email-lei.rao@intel.com> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.55.52.93; envelope-from=lei.rao@intel.com; helo=mga11.intel.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/22 05:42:20 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: leirao , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" In COLO mode, if the startup parameters of QEMU include "no-shutdown", QEMU will crash when the guest shutdown. The root cause is when the guest shutdown, the state of VM will switch COLO to SHUTDOWN. When do checkpoint again, the state will be changed to COLO. But the state switch is undefined in runstate_transitions_def, we should add it. This patch fixes the following: qemu-system-x86_64: invalid runstate transition: 'shutdown' -> 'colo' Aborted Signed-off-by: leirao Reviewed-by: Zhang Chen --- softmmu/vl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/softmmu/vl.c b/softmmu/vl.c index f7b1034..c21606c 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -631,6 +631,7 @@ static const RunStateTransition runstate_transitions_de= f[] =3D { { RUN_STATE_SHUTDOWN, RUN_STATE_PAUSED }, { RUN_STATE_SHUTDOWN, RUN_STATE_FINISH_MIGRATE }, { RUN_STATE_SHUTDOWN, RUN_STATE_PRELAUNCH }, + { RUN_STATE_SHUTDOWN, RUN_STATE_COLO }, =20 { RUN_STATE_DEBUG, RUN_STATE_SUSPENDED }, { RUN_STATE_RUNNING, RUN_STATE_SUSPENDED }, --=20 1.8.3.1