From nobody Sun Nov 16 14:02:00 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1600767995; cv=none; d=zohomail.com; s=zohoarc; b=YL07F+XijGtWUXqGMl1fbaIup4a3c6jrWok34f8Opb/IChjuKLADrB8z61oa5N9iAhpmlvLCpFYX+V0h5k2Lp2S02FFwm3h/Ur69qAqPTU50nk6KTS/sw//Xj4KtQ7AATlqkKX+RukVR043BIbIjEkzXA0u8SBRy1VwkmcgWmIg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600767995; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=4uhUnN2ntch2Amhllr2ZanhVoD2JjhtOqykqAE3B/Po=; b=QoS/sSZfn9bs9wZfgjHiH9Ajd2LI3oFrPfo0hoUP4vjhtMSABFHVFqT4vh8/aiD9R0X3nug+K+Bw3AXEGOo45y1RAWxJvmU+DwyF0+RTYmO4QPsFG3AVGpw1K/ugnyE8UJYq7r5Hi45Wjm2OkWaXvXSheuydpwEmCrvtpmtXuhs= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1600767995143718.1675060791587; Tue, 22 Sep 2020 02:46:35 -0700 (PDT) Received: from localhost ([::1]:47662 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKesb-0003il-S3 for importer@patchew.org; Tue, 22 Sep 2020 05:46:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKeof-00085g-3T for qemu-devel@nongnu.org; Tue, 22 Sep 2020 05:42:29 -0400 Received: from mga11.intel.com ([192.55.52.93]:64260) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKeod-0008QL-A8 for qemu-devel@nongnu.org; Tue, 22 Sep 2020 05:42:28 -0400 Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2020 02:42:25 -0700 Received: from unknown (HELO localhost.localdomain.bj.intel.com) ([10.240.192.103]) by orsmga007.jf.intel.com with ESMTP; 22 Sep 2020 02:42:23 -0700 IronPort-SDR: mggVKMBtr8PgRgvSyBpdo7zltvAm8+APlzTLgOZlZAZaeGonvALpFbdCoLet/K/9S6iImUx1ml 4NebgPAB3uAw== X-IronPort-AV: E=McAfee;i="6000,8403,9751"; a="157947014" X-IronPort-AV: E=Sophos;i="5.77,290,1596524400"; d="scan'208";a="157947014" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False IronPort-SDR: A4K+Odw0I/qaTsshUZePnEaQAYkuyRW4UAoEHmzZq63moPHdCUqyBjxpY666IGkG+gRRGQdGt9 QWxBi3cfNmYA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,290,1596524400"; d="scan'208";a="348424035" From: leirao To: chen.zhang@intel.com, lizhijian@cn.fujitsu.com, jasowang@redhat.com, quintela@redhat.com, dgilbert@redhat.com, pbonzini@redhat.com Subject: [PATCH v2 2/3] Reduce the time of checkpoint for COLO Date: Tue, 22 Sep 2020 05:24:49 -0400 Message-Id: <1600766690-94980-3-git-send-email-lei.rao@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1600766690-94980-1-git-send-email-lei.rao@intel.com> References: <1600766690-94980-1-git-send-email-lei.rao@intel.com> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.55.52.93; envelope-from=lei.rao@intel.com; helo=mga11.intel.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/22 05:42:20 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: leirao , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" we should set ram_bulk_stage to false after ram_state_init, otherwise the bitmap will be unused in migration_bitmap_find_dirty. all pages in ram cache will be flushed to the ram of secondary guest for each checkpoint. Signed-off-by: leirao Reviewed-by: Li Zhijian Reviewed-by: Zhang Chen --- migration/ram.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c index 76d4fee..59ff0cf 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -3018,6 +3018,18 @@ static void decompress_data_with_multi_threads(QEMUF= ile *f, qemu_mutex_unlock(&decomp_done_lock); } =20 + /* + * we must set ram_bulk_stage to fasle, otherwise in + * migation_bitmap_find_dirty the bitmap will be unused and + * all the pages in ram cache wil be flushed to the ram of + * secondary VM. + */ +static void colo_init_ram_state(void) +{ + ram_state_init(&ram_state); + ram_state->ram_bulk_stage =3D false; +} + /* * colo cache: this is for secondary VM, we cache the whole * memory of the secondary VM, it is need to hold the global lock @@ -3061,7 +3073,7 @@ int colo_init_ram_cache(void) } } =20 - ram_state_init(&ram_state); + colo_init_ram_state(); return 0; } =20 --=20 1.8.3.1