From nobody Sun Nov 16 14:00:36 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1600767844; cv=none; d=zohomail.com; s=zohoarc; b=hkCfMf+EmUukrGDSza/2LMHsPBor2G81e4e0sz1x3KyuqyZTA6Kn2tjDmQ6A0k+t1iS1Ln8vWXbnPqvE23Y0fBhp2TuBIHFlu++c9uN1/8wlvjHA4wMAtP7141BC0tzEEqcsIn1pQ2+FF/i59IC7ZRhD3n/fNPZRun8G4rX5DGA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600767844; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=8CDI3mAmYbmIXkT1QUWZyurOtSlI23epJ0kTIoQbxJ0=; b=eY+nDWnSvYgYQ/cDlWxG5kHa/hS7CZH7hwmpWclmQZ0QlXmEYFZNgIFRo5H0DRmf0K+zXyIVbL0TmFxDtzdUJWkVAZgJzmej7z6uSWtFkZZlk+EdNrM6bVdwHSXfyCfDfjGx4r9h5bY1/66pKdf4v++tJZ9muKvgI1UP9Djv7F8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1600767844643217.3006466059261; Tue, 22 Sep 2020 02:44:04 -0700 (PDT) Received: from localhost ([::1]:41916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKeqB-000185-5D for importer@patchew.org; Tue, 22 Sep 2020 05:44:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42342) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKeoe-000841-3y for qemu-devel@nongnu.org; Tue, 22 Sep 2020 05:42:28 -0400 Received: from mga11.intel.com ([192.55.52.93]:64259) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKeoc-0008QG-ET for qemu-devel@nongnu.org; Tue, 22 Sep 2020 05:42:27 -0400 Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2020 02:42:22 -0700 Received: from unknown (HELO localhost.localdomain.bj.intel.com) ([10.240.192.103]) by orsmga007.jf.intel.com with ESMTP; 22 Sep 2020 02:42:20 -0700 IronPort-SDR: d6C13df6ApyQK1YH438JHT2I5my0j8suxdyCYdk0ZIUVhXgOh3QvH422GOERC5ZLhyYRx8LpZq tk/C73/jCwqg== X-IronPort-AV: E=McAfee;i="6000,8403,9751"; a="157947008" X-IronPort-AV: E=Sophos;i="5.77,290,1596524400"; d="scan'208";a="157947008" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False IronPort-SDR: sHMxkHDDmZpLvLWvNpznEoksEikfWQ1PyCc09arBFlvD/Ths/xNkaBk4/c0ybPVC0PQ2bcX03K 2lSSNzoYSPSg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,290,1596524400"; d="scan'208";a="348424026" From: leirao To: chen.zhang@intel.com, lizhijian@cn.fujitsu.com, jasowang@redhat.com, quintela@redhat.com, dgilbert@redhat.com, pbonzini@redhat.com Subject: [PATCH v2 1/3] Optimize seq_sorter function for colo-compare Date: Tue, 22 Sep 2020 05:24:48 -0400 Message-Id: <1600766690-94980-2-git-send-email-lei.rao@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1600766690-94980-1-git-send-email-lei.rao@intel.com> References: <1600766690-94980-1-git-send-email-lei.rao@intel.com> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.55.52.93; envelope-from=lei.rao@intel.com; helo=mga11.intel.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/22 05:42:20 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: leirao , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The seq of tcp has been filled in fill_pkt_tcp_info, it can be used directly here. Signed-off-by: leirao Reviewed-by: Zhang Chen --- net/colo-compare.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index 3a45d64..86980ce 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -196,11 +196,7 @@ static void colo_compare_inconsistency_notify(CompareS= tate *s) =20 static gint seq_sorter(Packet *a, Packet *b, gpointer data) { - struct tcp_hdr *atcp, *btcp; - - atcp =3D (struct tcp_hdr *)(a->transport_header); - btcp =3D (struct tcp_hdr *)(b->transport_header); - return ntohl(atcp->th_seq) - ntohl(btcp->th_seq); + return a->tcp_seq - b->tcp_seq; } =20 static void fill_pkt_tcp_info(void *data, uint32_t *max_ack) --=20 1.8.3.1