From nobody Sat Nov 15 17:09:40 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1595927736; cv=none; d=zohomail.com; s=zohoarc; b=Wfef1Pb0Rs0cDHTu5CsrlVvc33/bnWpFIdOWD06onKJik3JVl5t//gII7RlbgYm54pfpBcZltaItsGx1WAPzdIpKbZzRKg6gCf6hPW+c/0OzzVpWPoSrFDsQJU4n0G2npmLps7tfzL5j9TPwGKLhirk9epYmNhjkQcrRUTdM/sw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595927736; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=sp4lH472CkPXcASqQs9UHixmq3ig6giI6oGkAeYU0iY=; b=LCqyL6e/GaWy8LE+H7MrYyLhV3NYNaUbAmIjQ5PEnHavtYaoGxauR/+1PwdXJOA0MOS0mInZdqItODsaR4OJGDDZSPqbPFh/ZKjLtD2F29054kFPqcyv6hCrrHwgDYUt/sNz9rxEa/UFn/ugRkJ4hrOK3Zksknp/pVu7EdWLRlI= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1595927736216107.77797453345715; Tue, 28 Jul 2020 02:15:36 -0700 (PDT) Received: from localhost ([::1]:58640 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k0Lhu-0002T6-Rf for importer@patchew.org; Tue, 28 Jul 2020 05:15:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60934) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k0Lgo-0001cy-JP for qemu-devel@nongnu.org; Tue, 28 Jul 2020 05:14:26 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:22948 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k0Lgk-0007eY-Ct for qemu-devel@nongnu.org; Tue, 28 Jul 2020 05:14:26 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-215-OXq25s6EMK2cdfmb7XeBKA-1; Tue, 28 Jul 2020 05:14:17 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DC51C79EC1; Tue, 28 Jul 2020 09:14:15 +0000 (UTC) Received: from bahia.lan (ovpn-114-208.ams2.redhat.com [10.36.114.208]) by smtp.corp.redhat.com (Postfix) with ESMTP id 10DC15C1BD; Tue, 28 Jul 2020 09:14:14 +0000 (UTC) X-MC-Unique: OXq25s6EMK2cdfmb7XeBKA-1 Subject: [PATCH for-5.2] spapr: Avoid some integer conversions in spapr_phb_realize() From: Greg Kurz To: David Gibson Date: Tue, 28 Jul 2020 11:14:13 +0200 Message-ID: <159592765385.99837.12059368746532345109.stgit@bahia.lan> User-Agent: StGit/0.21 MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: kaod.org Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: softfail client-ip=207.211.31.81; envelope-from=groug@kaod.org; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/28 00:06:48 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, Markus Armbruster , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Without this patch, the irq number gets converted uselessly from int to int32_t, back and forth. This doesn't fix an actual issue, it's just to make the code neater. Suggested-by: Markus Armbruster Signed-off-by: Greg Kurz Reviewed-by: Markus Armbruster --- This is a follow-up to my previous "spapr: Simplify error handling in spapr_phb_realize()" patch. Maybe worth squashing it there ? --- hw/ppc/spapr_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 59441e2117f3..0a418f1e6711 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -1964,7 +1964,7 @@ static void spapr_phb_realize(DeviceState *dev, Error= **errp) =20 /* Initialize the LSI table */ for (i =3D 0; i < PCI_NUM_PINS; i++) { - int32_t irq =3D SPAPR_IRQ_PCI_LSI + sphb->index * PCI_NUM_PINS + i; + int irq =3D SPAPR_IRQ_PCI_LSI + sphb->index * PCI_NUM_PINS + i; =20 if (smc->legacy_irq_allocation) { irq =3D spapr_irq_findone(spapr, errp);