From nobody Fri Dec 19 06:24:58 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1595927506; cv=none; d=zohomail.com; s=zohoarc; b=lTPoVDdVEsbWDFDsUvb8E08wod+F/jVUfpPZ0qkyLwIeZWSkCat2bZ5VNOcY0o/AR/I7w4RsrfgoJvzs6BxZMUskOcBm4JgjdLPBLCU2VngYGPY7NoybTSDlmD/5XB1nXHrvxIcgECqS2I8tPa7TEyt5lQlCFD6Az0Iitz9FBcI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595927506; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=QEWe54TC6Rr7+K7ziQiMtOrZqhkhpMwTIP1e/wV8VVU=; b=CVOmmn+t8ma8HkjbuNl2n5GTP8V5n69TYGl4NJbzqG7hpHJLFuxg7okTra9+gY3t6uqK985VMT3E6k6LA4T4scOL2g7Px3X4CwiuvAgzrX7HQ0x95XiWPeR75xQxJy7Q5+4veS7xM9/kcfKq2XzQmLT8H42T+12uJeAZ/PSXLlA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1595927506713133.23158616917192; Tue, 28 Jul 2020 02:11:46 -0700 (PDT) Received: from localhost ([::1]:50730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k0LeD-0007YW-7c for importer@patchew.org; Tue, 28 Jul 2020 05:11:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60000) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k0Ld6-0006KD-Jq for qemu-devel@nongnu.org; Tue, 28 Jul 2020 05:10:36 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:55962 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k0Ld4-0007CW-PE for qemu-devel@nongnu.org; Tue, 28 Jul 2020 05:10:36 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-377-6lPiy0tLPBKVRNr19AFrOw-1; Tue, 28 Jul 2020 05:10:31 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 85C971DE1; Tue, 28 Jul 2020 09:10:30 +0000 (UTC) Received: from jason-ThinkPad-T430s.redhat.com (ovpn-12-214.pek2.redhat.com [10.72.12.214]) by smtp.corp.redhat.com (Postfix) with ESMTP id 348FC90E62; Tue, 28 Jul 2020 09:10:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595927434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type:in-reply-to:in-reply-to: references:references; bh=QEWe54TC6Rr7+K7ziQiMtOrZqhkhpMwTIP1e/wV8VVU=; b=H7KAgO4leSvF33scLRrXrCWI39MZ0TAsebeG6S8oXDol/1PbED0gw8KDapDbgwWuH0jDEX /aJa2PR2Q4/mmsAd8vBNOgprDt1GdTvtSkzyXusShtSK7gSlihs+3AKVXjTfmnr70r4WQr AbU4IlsZ2BAx0cs7AaWKBXbZH1PU1oU= X-MC-Unique: 6lPiy0tLPBKVRNr19AFrOw-1 From: Jason Wang To: peter.maydell@linaro.org Subject: [PULL V2 1/3] virtio-pci: fix wrong index in virtio_pci_queue_enabled Date: Tue, 28 Jul 2020 17:10:17 +0800 Message-Id: <1595927419-27346-2-git-send-email-jasowang@redhat.com> In-Reply-To: <1595927419-27346-1-git-send-email-jasowang@redhat.com> References: <1595927419-27346-1-git-send-email-jasowang@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.120; envelope-from=jasowang@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/27 23:55:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yuri Benditovich , Jason Wang , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Yuri Benditovich We should use the index passed by the caller instead of the queue_sel when checking the enablement of a specific virtqueue. This is reported in https://bugzilla.redhat.com/show_bug.cgi?id=3D1702608 Fixes: f19bcdfedd53 ("virtio-pci: implement queue_enabled method") Signed-off-by: Yuri Benditovich Signed-off-by: Jason Wang --- hw/virtio/virtio-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 4ad3ad8..ccdf54e 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -1113,7 +1113,7 @@ static bool virtio_pci_queue_enabled(DeviceState *d, = int n) VirtIODevice *vdev =3D virtio_bus_get_device(&proxy->bus); =20 if (virtio_vdev_has_feature(vdev, VIRTIO_F_VERSION_1)) { - return proxy->vqs[vdev->queue_sel].enabled; + return proxy->vqs[n].enabled; } =20 return virtio_queue_enabled_legacy(vdev, n); --=20 2.7.4