From nobody Sat Nov 15 17:43:55 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1595646051; cv=none; d=zohomail.com; s=zohoarc; b=nstBWD6g5USBx+nE1eJmLcNOOAPsMEPldFwEDifPWYVi0vTB3AgDO/32LEQwqC9wUkSUlhI2vSgx2znuyxtim9ib4MbFCGo3XfbYIm2yPWkVZcEvGMIMrGknvn78tDwe8iNJfiirxUIp5aZfNii0+QNk0Mx5kqAa9/qnE6wDQqA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595646051; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UDw1UQknc+rKqrZbT0P/fgBeS7DotRYDG5DRTw0n32Y=; b=BHziQQgmgSTKx2m86u0Lwp95yHc1wF5HgnW1T9WcRL5cQ29QjTUgtzjIjUzyL9T3WZs0rTEeghc1W1CSl1y+tzKoMdB6KcEHYNuuAnhImV36G4upOBQyCfOEX8Znk5Oob0JbZVcvkqU+URpC9AvJAhr+xvwnu30BsS6aOBApRsQ= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1595646051539398.76110136666705; Fri, 24 Jul 2020 20:00:51 -0700 (PDT) Received: from localhost ([::1]:42942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jzAQc-0003uu-3B for importer@patchew.org; Fri, 24 Jul 2020 23:00:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jzAPU-00024a-7K for qemu-devel@nongnu.org; Fri, 24 Jul 2020 22:59:40 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:33220 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jzAPQ-0000k5-Mn for qemu-devel@nongnu.org; Fri, 24 Jul 2020 22:59:39 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 32288D51536A426CC409; Sat, 25 Jul 2020 10:59:28 +0800 (CST) Received: from huawei.com (10.175.101.6) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Sat, 25 Jul 2020 10:59:22 +0800 From: Chuan Zheng To: , Subject: [RFC PATCH 3/8] migration/dirtyrate: Add dirtyrate statistics series functions Date: Sat, 25 Jul 2020 11:11:04 +0800 Message-ID: <1595646669-109310-4-git-send-email-zhengchuan@huawei.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1595646669-109310-1-git-send-email-zhengchuan@huawei.com> References: <1595646669-109310-1-git-send-email-zhengchuan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.101.6] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.35; envelope-from=zhengchuan@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/24 22:59:28 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, linyilu@huawei.com, qemu-devel@nongnu.org, alex.chen@huawei.com, ann.zhuangyanying@huawei.com, fangying1@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Zheng Chuan Add dirtyrate statistics to record/update dirtyrate info. Signed-off-by: Zheng Chuan Signed-off-by: YanYing Zhang --- migration/dirtyrate.c | 47 ++++++++++++++++++++++++++++++----------------- migration/dirtyrate.h | 11 +++++++++++ 2 files changed, 41 insertions(+), 17 deletions(-) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index fc652fb..6baf674 100644 --- a/migration/dirtyrate.c +++ b/migration/dirtyrate.c @@ -13,19 +13,41 @@ #include "dirtyrate.h" =20 static uint64_t sample_pages_per_gigabytes =3D DIRTYRATE_DEFAULT_SAMPLE_PA= GES; -static uint64_t dirty_rate; /* MB/s */ +static struct dirtyrate_statistics dirty_stat; CalculatingDirtyRateStage calculating_dirty_rate_stage =3D CAL_DIRTY_RATE_= INIT; =20 -static bool calculate_dirtyrate(struct dirtyrate_config config, - uint64_t *dirty_rate, int64_t time) +static void reset_dirtyrate_stat(void) { - /* todo */ - return true; + dirty_stat.total_dirty_samples =3D 0; + dirty_stat.total_sample_count =3D 0; + dirty_stat.total_block_mem_MB =3D 0; + dirty_stat.dirty_rate =3D 0; +} + +static void update_dirtyrate_stat(struct block_dirty_info *info) +{ + dirty_stat.total_dirty_samples +=3D info->sample_dirty_count; + dirty_stat.total_sample_count +=3D info->sample_pages_count; + dirty_stat.total_block_mem_MB +=3D (info->block_pages << DIRTYRATE_PAG= E_SIZE_SHIFT) >> PAGE_SIZE_SHIFT; } =20 -static void set_dirty_rate(uint64_t drate) +static void update_dirtyrate(int64_t msec) { - dirty_rate =3D drate; + uint64_t dirty_rate; + unsigned int total_dirty_samples =3D dirty_stat.total_dirty_samples; + unsigned int total_sample_count =3D dirty_stat.total_sample_count; + unsigned long total_block_mem_MB =3D dirty_stat.total_block_mem_MB; + + dirty_rate =3D total_dirty_samples * total_block_mem_MB * + 1000 / (total_sample_count * msec); + + dirty_stat.dirty_rate =3D dirty_rate; +} + + +static void calculate_dirtyrate(struct dirtyrate_config config, int64_t ti= me) +{ + /* todo */ } =20 /* @@ -42,21 +64,12 @@ static void set_dirty_rate_stage(CalculatingDirtyRateSt= age ratestage) void *get_dirtyrate_thread(void *arg) { struct dirtyrate_config config =3D *(struct dirtyrate_config *)arg; - uint64_t dirty_rate; - uint64_t hash_dirty_rate; - bool query_succ; int64_t msec =3D 0; =20 set_dirty_rate_stage(CAL_DIRTY_RATE_ING); =20 - query_succ =3D calculate_dirtyrate(config, &hash_dirty_rate, msec); - if (!query_succ) { - dirty_rate =3D 0; - } else { - dirty_rate =3D hash_dirty_rate; - } + calculate_dirtyrate(config, msec); =20 - set_dirty_rate(dirty_rate); set_dirty_rate_stage(CAL_DIRTY_RATE_END); =20 return NULL; diff --git a/migration/dirtyrate.h b/migration/dirtyrate.h index 342b89f..2994535 100644 --- a/migration/dirtyrate.h +++ b/migration/dirtyrate.h @@ -15,6 +15,9 @@ =20 /* take 256 pages per GB for cal dirty rate */ #define DIRTYRATE_DEFAULT_SAMPLE_PAGES 256 +#define DIRTYRATE_PAGE_SIZE_SHIFT 12 +#define BLOCK_INFO_MAX_LEN 256 +#define PAGE_SIZE_SHIFT 20 =20 struct dirtyrate_config { uint64_t sample_pages_per_gigabytes; @@ -33,6 +36,14 @@ typedef enum { CAL_DIRTY_RATE_END =3D 2, } CalculatingDirtyRateStage; =20 +struct dirtyrate_statistics { + unsigned int total_dirty_samples; + unsigned int total_sample_count; + unsigned long total_block_mem_MB; + int64_t dirty_rate; +}; + + /*=20 * Store dirtypage info for each block. */ --=20 1.8.3.1