From nobody Tue Feb 10 02:01:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1594576267; cv=none; d=zohomail.com; s=zohoarc; b=jtaraYuUEPdvhgIAcux5CKlVMp6R7xjkCC9q7AWfV04YLmNGQWWd6cE7amSTYwIfbnVTiqOQ4GYzHW3DfikuxAiUIL5Us38qIOt+0WV6qcjobboTBOGMGSr9TUKxFUl9+M7S1kUQVvm23IL1cDTXIx9jAlmucGZSNlnn/EEYR2c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594576267; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=uFozjjy5YDKX6i1gwQDqv15WG8XzSWeGKQPnovWe4MU=; b=kae7ScExqGNBt54ERrO/rZv3ETAnF5vCUKSpwpCEjx9At4GF8vfhco6P+niPCjkkxwI46MMy2wtSNklZhtOqy++MngBRXmh2PB1+cm5OkoFgbXyFTZvPoVeBY3AaC2FXdQDUbg/Pa5ztfcm+13CX/tnF/bef+Oc0B4Q6Zz+JFuA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1594576266946491.9762484709256; Sun, 12 Jul 2020 10:51:06 -0700 (PDT) Received: from localhost ([::1]:49318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jug81-0004tN-HE for importer@patchew.org; Sun, 12 Jul 2020 13:51:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jug6Q-00039S-DK; Sun, 12 Jul 2020 13:49:26 -0400 Received: from relay.sw.ru ([185.231.240.75]:60378 helo=relay3.sw.ru) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jug6N-0001lB-6e; Sun, 12 Jul 2020 13:49:26 -0400 Received: from [172.16.25.136] (helo=localhost.sw.ru) by relay3.sw.ru with esmtp (Exim 4.93) (envelope-from ) id 1jug6B-0005LT-JN; Sun, 12 Jul 2020 20:49:11 +0300 From: Andrey Shinkevich To: qemu-block@nongnu.org Subject: [PATCH v4 2/3] scripts/simplebench: allow writing to non-empty image Date: Sun, 12 Jul 2020 20:49:17 +0300 Message-Id: <1594576158-75884-3-git-send-email-andrey.shinkevich@virtuozzo.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1594576158-75884-1-git-send-email-andrey.shinkevich@virtuozzo.com> References: <1594576158-75884-1-git-send-email-andrey.shinkevich@virtuozzo.com> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=185.231.240.75; envelope-from=andrey.shinkevich@virtuozzo.com; helo=relay3.sw.ru X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/12 13:17:17 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, qemu-devel@nongnu.org, mreitz@redhat.com, andrey.shinkevich@virtuozzo.com, den@openvz.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Add 'empty_image' parameter to the function bench_write_req() and to the test cases that will allow writing to the non-empty clusters of the image if the 'empty_image' parameter set to False. Signed-off-by: Andrey Shinkevich --- scripts/simplebench/bench_write_req.py | 27 +++++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/scripts/simplebench/bench_write_req.py b/scripts/simplebench/b= ench_write_req.py index a285ef1..f758f90 100755 --- a/scripts/simplebench/bench_write_req.py +++ b/scripts/simplebench/bench_write_req.py @@ -29,7 +29,7 @@ def bench_func(env, case): """ Handle one "cell" of benchmarking table. """ return bench_write_req(env['qemu_img'], env['image_name'], case['block_size'], case['block_offset'], - case['requests']) + case['requests'], case['empty_image']) =20 =20 def qemu_img_pipe(*args): @@ -45,7 +45,8 @@ def qemu_img_pipe(*args): return subp.communicate()[0] =20 =20 -def bench_write_req(qemu_img, image_name, block_size, block_offset, reques= ts): +def bench_write_req(qemu_img, image_name, block_size, block_offset, reques= ts, + empty_image): """Benchmark write requests =20 The function creates a QCOW2 image with the given path/name and fills = it @@ -58,6 +59,7 @@ def bench_write_req(qemu_img, image_name, block_size, blo= ck_offset, requests): block_size -- size of a block to write to clusters block_offset -- offset of the block in clusters requests -- number of write requests per cluster + empty_image -- if not True, fills image with random data =20 Returns {'seconds': int} on success and {'error': str} on failure. Return value is compatible with simplebench lib. @@ -96,6 +98,15 @@ def bench_write_req(qemu_img, image_name, block_size, bl= ock_offset, requests): =20 try: qemu_img_pipe(*args_create) + + if not empty_image: + dd =3D ['dd', 'if=3D/dev/urandom', f'of=3D{image_name}', + f'bs=3D{cluster_size}', f'seek=3D{seek}', + f'count=3D{dd_count}'] + devnull =3D open('/dev/null', 'w') + subprocess.run(dd, stderr=3Ddevnull, stdout=3Ddevnull) + subprocess.run('sync') + except OSError as e: os.remove(image_name) return {'error': 'qemu_img create failed: ' + str(e)} @@ -130,25 +141,29 @@ if __name__ =3D=3D '__main__': 'id': '', 'block_size': 0, 'block_offset': 0, - 'requests': 10 + 'requests': 10, + 'empty_image': True }, { 'id': '', 'block_size': 4096, 'block_offset': 0, - 'requests': 10 + 'requests': 10, + 'empty_image': True }, { 'id': '', 'block_size': 4096, 'block_offset': 524288, - 'requests': 10 + 'requests': 10, + 'empty_image': True }, { 'id': '', 'block_size': 524288, 'block_offset': 4096, - 'requests': 2 + 'requests': 2, + 'empty_image': True }, ] =20 --=20 1.8.3.1