From nobody Sat Nov 15 01:02:07 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1592249756; cv=none; d=zohomail.com; s=zohoarc; b=C14H6BbpidDb1PMr1nHtDtXWiWeHJmoD9YQEhDEZQWkVfVy9BgO59eg+bXWCZ7r3XQTUM6mUuOzWtcaYdMuseFTt3PRjly+aQ05OYpD1BD0yCHtwiQVsjKsGk679wgSICMKpECKT2y03xjJGPNLNtpzD/NSEMeMhHmeclB86oGo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592249756; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=7HXj1vegb9I+RQsAUyfbJXvupzJ3jlIovDfaa6vKVts=; b=d6nl66Krt7ExPL9J4YHnMl8xM77aw/4/iSaWnnU5JY+2hpMdUMjmZCe7MCEmc3+zrFpRPnn3xTuYAoaZ2NN4wYxZuxxY1hd/uwiI25T2UVdZH1p3sDqNXdhAP1sg3kx6bNT9NaElT5WXW6GS94Yk6tOALbSP0jRWMfE8g/T/hy4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592249756228687.8435808982397; Mon, 15 Jun 2020 12:35:56 -0700 (PDT) Received: from localhost ([::1]:60472 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkute-00076f-Rm for importer@patchew.org; Mon, 15 Jun 2020 15:35:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkunG-0003lp-C9 for qemu-devel@nongnu.org; Mon, 15 Jun 2020 15:29:18 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:35371) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jkunD-0004lD-TV for qemu-devel@nongnu.org; Mon, 15 Jun 2020 15:29:18 -0400 Received: by mail-wm1-x332.google.com with SMTP id q25so763853wmj.0 for ; Mon, 15 Jun 2020 12:29:15 -0700 (PDT) Received: from rtrkw774-lin.syrmia.com ([46.240.135.226]) by smtp.gmail.com with ESMTPSA id 138sm713098wma.23.2020.06.15.12.29.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jun 2020 12:29:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7HXj1vegb9I+RQsAUyfbJXvupzJ3jlIovDfaa6vKVts=; b=SOPivRvCTiNmXHhqsMHizVET2NiJ647XaafmRUv8eHkPseAj7a8DfHuPwnUwkc2mL1 oswKPR7vcVZ6fjJKVBIC9OW/g7OBK+j7A2sWZPRnV0rgej0nbbAzhLv/9RBFLkyhrsoF iAN3ITsBFQ1m1lIjfNFncFb1EZCXfcRmcoQp3Ib5y7tXuyL4JnCAsfk7Juj5IwSWJ914 b4sCOhprVzA92QNGIESQiMLXKetAmEeCwnusj6Lvgizy6nStd9E8uBt8rr/pjij2hpnJ DNooO97Q58mpHa8oBXoZ+pvo6uRrPOxYP40m692Ah10jj/GYkeoAWVyMoA7frh/vVMHS vTqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7HXj1vegb9I+RQsAUyfbJXvupzJ3jlIovDfaa6vKVts=; b=IeXo9XWXTP8gm1YXeERTCBzq0lnDSku3m1+Sq/pJczzDLp/xG4KFBs6sXvelx3gLAt hSgvzeDioNSRD1MOKL00ulev1ttIiDk8EAXDIdMPU8neMDFAasgP/Na3tPRB/BiLcJsg rgUasIrjkRL7YD5+4c/+UuLcWut0AOMzsB8z2Cy72TxMbz7QxKykWxSgRLYBRODwGRXA 3eJHxySocJJ77UrzW+qs1TZMlMcjJt95jXtA+zmva5fERCfDZhvQjsnskS/UW+/GxOQs KGgYXcObEcsqToglFG7XQxTBES1EoBDSLv7mmz986woOqZ2lM7YKwXM59rGtn+ED7RLY 9zAw== X-Gm-Message-State: AOAM532jZzZWLa3nupWbJkgvCkSVFYmfjiS4Eh4sb7nqAwmxt+oXw2Rq EaHHnlVCM/SvqezbpYkGO6lwNewT X-Google-Smtp-Source: ABdhPJyok5f7YmZ9aTcEw0Y+lm1MEpFqBfL/mLUWxS5RW3Te8kLPdn0oI+Ez+TbZq+zGc4RzLrUUuw== X-Received: by 2002:a7b:c156:: with SMTP id z22mr816628wmi.43.1592249354213; Mon, 15 Jun 2020 12:29:14 -0700 (PDT) From: Aleksandar Markovic To: qemu-devel@nongnu.org, peter.maydell@linaro.org Subject: [PULL 15/18] target/mips: msa: Split helpers for SUBV. Date: Mon, 15 Jun 2020 21:28:57 +0200 Message-Id: <1592249340-8365-16-git-send-email-aleksandar.qemu.devel@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1592249340-8365-1-git-send-email-aleksandar.qemu.devel@gmail.com> References: <1592249340-8365-1-git-send-email-aleksandar.qemu.devel@gmail.com> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=aleksandar.qemu.devel@gmail.com; helo=mail-wm1-x332.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aleksandar.qemu.devel@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Achieves clearer code and slightly better performance. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <20200613152133.8964-14-aleksandar.qemu.devel@gmail.com> --- target/mips/helper.h | 6 +++- target/mips/msa_helper.c | 81 ++++++++++++++++++++++++++++++++++++++++++--= ---- target/mips/translate.c | 15 ++++++++- 3 files changed, 91 insertions(+), 11 deletions(-) diff --git a/target/mips/helper.h b/target/mips/helper.h index 4795c97..5d7ba6a 100644 --- a/target/mips/helper.h +++ b/target/mips/helper.h @@ -998,6 +998,11 @@ DEF_HELPER_4(msa_subsuu_s_h, void, env, i32, i32, i32) DEF_HELPER_4(msa_subsuu_s_w, void, env, i32, i32, i32) DEF_HELPER_4(msa_subsuu_s_d, void, env, i32, i32, i32) =20 +DEF_HELPER_4(msa_subv_b, void, env, i32, i32, i32) +DEF_HELPER_4(msa_subv_h, void, env, i32, i32, i32) +DEF_HELPER_4(msa_subv_w, void, env, i32, i32, i32) +DEF_HELPER_4(msa_subv_d, void, env, i32, i32, i32) + DEF_HELPER_4(msa_ilvev_b, void, env, i32, i32, i32) DEF_HELPER_4(msa_ilvev_h, void, env, i32, i32, i32) DEF_HELPER_4(msa_ilvev_w, void, env, i32, i32, i32) @@ -1093,7 +1098,6 @@ DEF_HELPER_5(msa_srlri_df, void, env, i32, i32, i32, = i32) =20 DEF_HELPER_5(msa_binsl_df, void, env, i32, i32, i32, i32) DEF_HELPER_5(msa_binsr_df, void, env, i32, i32, i32, i32) -DEF_HELPER_5(msa_subv_df, void, env, i32, i32, i32, i32) DEF_HELPER_5(msa_mulv_df, void, env, i32, i32, i32, i32) =20 DEF_HELPER_4(msa_dotp_s_h, void, env, i32, i32, i32) diff --git a/target/mips/msa_helper.c b/target/mips/msa_helper.c index 27a9c36..d099e00 100644 --- a/target/mips/msa_helper.c +++ b/target/mips/msa_helper.c @@ -3553,9 +3553,6 @@ void helper_msa_asub_u_d(CPUMIPSState *env, } =20 =20 -/* TODO: insert the rest of Int Subtract group helpers here */ - - static inline int64_t msa_hsub_s_df(uint32_t df, int64_t arg1, int64_t arg= 2) { return SIGNED_ODD(arg1, df) - SIGNED_EVEN(arg2, df); @@ -3970,6 +3967,78 @@ void helper_msa_subsuu_s_d(CPUMIPSState *env, } =20 =20 +static inline int64_t msa_subv_df(uint32_t df, int64_t arg1, int64_t arg2) +{ + return arg1 - arg2; +} + +void helper_msa_subv_b(CPUMIPSState *env, + uint32_t wd, uint32_t ws, uint32_t wt) +{ + wr_t *pwd =3D &(env->active_fpu.fpr[wd].wr); + wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); + wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); + + pwd->b[0] =3D msa_subv_df(DF_BYTE, pws->b[0], pwt->b[0]); + pwd->b[1] =3D msa_subv_df(DF_BYTE, pws->b[1], pwt->b[1]); + pwd->b[2] =3D msa_subv_df(DF_BYTE, pws->b[2], pwt->b[2]); + pwd->b[3] =3D msa_subv_df(DF_BYTE, pws->b[3], pwt->b[3]); + pwd->b[4] =3D msa_subv_df(DF_BYTE, pws->b[4], pwt->b[4]); + pwd->b[5] =3D msa_subv_df(DF_BYTE, pws->b[5], pwt->b[5]); + pwd->b[6] =3D msa_subv_df(DF_BYTE, pws->b[6], pwt->b[6]); + pwd->b[7] =3D msa_subv_df(DF_BYTE, pws->b[7], pwt->b[7]); + pwd->b[8] =3D msa_subv_df(DF_BYTE, pws->b[8], pwt->b[8]); + pwd->b[9] =3D msa_subv_df(DF_BYTE, pws->b[9], pwt->b[9]); + pwd->b[10] =3D msa_subv_df(DF_BYTE, pws->b[10], pwt->b[10]); + pwd->b[11] =3D msa_subv_df(DF_BYTE, pws->b[11], pwt->b[11]); + pwd->b[12] =3D msa_subv_df(DF_BYTE, pws->b[12], pwt->b[12]); + pwd->b[13] =3D msa_subv_df(DF_BYTE, pws->b[13], pwt->b[13]); + pwd->b[14] =3D msa_subv_df(DF_BYTE, pws->b[14], pwt->b[14]); + pwd->b[15] =3D msa_subv_df(DF_BYTE, pws->b[15], pwt->b[15]); +} + +void helper_msa_subv_h(CPUMIPSState *env, + uint32_t wd, uint32_t ws, uint32_t wt) +{ + wr_t *pwd =3D &(env->active_fpu.fpr[wd].wr); + wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); + wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); + + pwd->h[0] =3D msa_subv_df(DF_HALF, pws->h[0], pwt->h[0]); + pwd->h[1] =3D msa_subv_df(DF_HALF, pws->h[1], pwt->h[1]); + pwd->h[2] =3D msa_subv_df(DF_HALF, pws->h[2], pwt->h[2]); + pwd->h[3] =3D msa_subv_df(DF_HALF, pws->h[3], pwt->h[3]); + pwd->h[4] =3D msa_subv_df(DF_HALF, pws->h[4], pwt->h[4]); + pwd->h[5] =3D msa_subv_df(DF_HALF, pws->h[5], pwt->h[5]); + pwd->h[6] =3D msa_subv_df(DF_HALF, pws->h[6], pwt->h[6]); + pwd->h[7] =3D msa_subv_df(DF_HALF, pws->h[7], pwt->h[7]); +} + +void helper_msa_subv_w(CPUMIPSState *env, + uint32_t wd, uint32_t ws, uint32_t wt) +{ + wr_t *pwd =3D &(env->active_fpu.fpr[wd].wr); + wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); + wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); + + pwd->w[0] =3D msa_subv_df(DF_WORD, pws->w[0], pwt->w[0]); + pwd->w[1] =3D msa_subv_df(DF_WORD, pws->w[1], pwt->w[1]); + pwd->w[2] =3D msa_subv_df(DF_WORD, pws->w[2], pwt->w[2]); + pwd->w[3] =3D msa_subv_df(DF_WORD, pws->w[3], pwt->w[3]); +} + +void helper_msa_subv_d(CPUMIPSState *env, + uint32_t wd, uint32_t ws, uint32_t wt) +{ + wr_t *pwd =3D &(env->active_fpu.fpr[wd].wr); + wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); + wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); + + pwd->d[0] =3D msa_subv_df(DF_DOUBLE, pws->d[0], pwt->d[0]); + pwd->d[1] =3D msa_subv_df(DF_DOUBLE, pws->d[1], pwt->d[1]); +} + + /* * Interleave * ---------- @@ -5194,11 +5263,6 @@ void helper_msa_shf_df(CPUMIPSState *env, uint32_t d= f, uint32_t wd, msa_move_v(pwd, pwx); } =20 -static inline int64_t msa_subv_df(uint32_t df, int64_t arg1, int64_t arg2) -{ - return arg1 - arg2; -} - #define MSA_BINOP_IMM_DF(helper, func) \ void helper_msa_ ## helper ## _df(CPUMIPSState *env, uint32_t df, \ uint32_t wd, uint32_t ws, int32_t u5) \ @@ -5502,7 +5566,6 @@ void helper_msa_ ## func ## _df(CPUMIPSState *env, ui= nt32_t df, \ } \ } =20 -MSA_BINOP_DF(subv) MSA_BINOP_DF(mulv) =20 MSA_BINOP_DF(mul_q) diff --git a/target/mips/translate.c b/target/mips/translate.c index 6d9ae1d..9ca17ed 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -29324,7 +29324,20 @@ static void gen_msa_3r(CPUMIPSState *env, DisasCon= text *ctx) gen_helper_msa_vshf_df(cpu_env, tdf, twd, tws, twt); break; case OPC_SUBV_df: - gen_helper_msa_subv_df(cpu_env, tdf, twd, tws, twt); + switch (df) { + case DF_BYTE: + gen_helper_msa_subv_b(cpu_env, twd, tws, twt); + break; + case DF_HALF: + gen_helper_msa_subv_h(cpu_env, twd, tws, twt); + break; + case DF_WORD: + gen_helper_msa_subv_w(cpu_env, twd, tws, twt); + break; + case DF_DOUBLE: + gen_helper_msa_subv_d(cpu_env, twd, tws, twt); + break; + } break; case OPC_SUBS_U_df: switch (df) { --=20 2.7.4